DPDK patches and discussions
 help / color / mirror / Atom feed
From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Odi Assli <odia@nvidia.com>, "Rong, Leyi" <leyi.rong@intel.com>,
	"Zhang, Qi Z" <qi.z.zhang@intel.com>,
	"Lu, Wenzhuo" <wenzhuo.lu@intel.com>,
	"Richardson, Bruce" <bruce.richardson@intel.com>,
	"Xing, Beilei" <beilei.xing@intel.com>,
	"Kadam, Pallavi" <pallavi.kadam@intel.com>,
	"Menon, Ranjit" <ranjit.menon@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
	Tal Shnaiderman <talshn@nvidia.com>,
	NBU-Contact-Thomas Monjalon <thomas@monjalon.net>,
	Raslan Darawsheh <rasland@nvidia.com>,
	Ali Alnubani <alialnu@nvidia.com>
Subject: Re: [dpdk-dev] [PATCH v3 0/3] AVX512 vPMD on i40e
Date: Mon, 18 Jan 2021 16:36:47 +0000
Message-ID: <c0d0e722-2a3a-a822-0192-d3f2cf996545@intel.com> (raw)
In-Reply-To: <BYAPR12MB28244BDFF9D55F1FFED93547ABA40@BYAPR12MB2824.namprd12.prod.outlook.com>

On 1/18/2021 2:53 PM, Odi Assli wrote:
>> Subject: Re: [PATCH v3 0/3] AVX512 vPMD on i40e
>>
>> External email: Use caution opening links or attachments
>>
>>
>> On 1/18/2021 1:58 PM, Rong, Leyi wrote:
>>>
>>>> -----Original Message-----
>>>> From: Odi Assli <odia@nvidia.com>
>>>> Sent: Sunday, January 17, 2021 7:26 PM
>>>> To: Zhang, Qi Z <qi.z.zhang@intel.com>; Rong, Leyi
>>>> <leyi.rong@intel.com>; Lu, Wenzhuo <wenzhuo.lu@intel.com>; Yigit,
>>>> Ferruh <ferruh.yigit@intel.com>; Richardson, Bruce
>>>> <bruce.richardson@intel.com>; Xing, Beilei <beilei.xing@intel.com>;
>>>> Kadam, Pallavi <pallavi.kadam@intel.com>; Menon, Ranjit
>>>> <ranjit.menon@intel.com>
>>>> Cc: dev@dpdk.org; Tal Shnaiderman <talshn@nvidia.com>; NBU-Contact-
>>>> Thomas Monjalon <thomas@monjalon.net>; Raslan Darawsheh
>>>> <rasland@nvidia.com>; Ali Alnubani <alialnu@nvidia.com>
>>>> Subject: RE: [PATCH v3 0/3] AVX512 vPMD on i40e
>>>>
>>>>>> Subject: [PATCH v3 0/3] AVX512 vPMD on i40e
>>>>>>
>>>>>> This patchset aims to support AVX512 vPMD on i40e.
>>>>>> And the changes are only target to AVX512 vector path.
>>>>>>
>>>>>> ---
>>>>>> v3:
>>>>>> - Extract get_avx_supported() to get the proper vector data path to
>>>>> choose.
>>>>>>
>>>>>> v2:
>>>>>> - Add return value check on rte_mempool_default_cache().
>>>>>>
>>>>>>
>>>>>> Leyi Rong (3):
>>>>>>     net/i40e: remove devarg use-latest-supported-vec
>>>>>>     net/i40e: add AVX512 vector path
>>>>>>     net/i40e: optimize Tx by using AVX512
>>>>>>
>>>>>>    doc/guides/nics/i40e.rst                |    9 -
>>>>>>    drivers/net/i40e/i40e_ethdev.c          |   63 +-
>>>>>>    drivers/net/i40e/i40e_ethdev.h          |    3 -
>>>>>>    drivers/net/i40e/i40e_rxtx.c            |  196 ++--
>>>>>>    drivers/net/i40e/i40e_rxtx.h            |   13 +
>>>>>>    drivers/net/i40e/i40e_rxtx_vec_avx512.c | 1136
>>>>> +++++++++++++++++++++++
>>>>>>    drivers/net/i40e/meson.build            |   24 +
>>>>>>    7 files changed, 1301 insertions(+), 143 deletions(-)  create
>>>>>> mode
>>>>>> 100644 drivers/net/i40e/i40e_rxtx_vec_avx512.c
>>>>>>
>>>>>> --
>>>>>> 2.17.1
>>>>>
>>>>>
>>>>> Applied to dpdk-next-net-intel after revert v1.
>>>>>
>>>>> Thanks
>>>>> Qi
>>>>
>>>> Hi,
>>>> This patch series broke i40e compilation on windows with failure in
>>>> undefined __m_prefetchw function Please see details in bug: 619 [1].
>>>>
>>>> [1]:
>>>>
>> https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fbug
>>>>
>> s.dpdk.org%2Fshow_bug.cgi%3Fid%3D619&amp;data=04%7C01%7Codia%40
>> nvidia
>>>>
>> .com%7C4b212e1ae3d045b6264108d8bbbd7703%7C43083d15727340c1b7db3
>> 9efd9c
>>>>
>> cc17a%7C0%7C0%7C637465769725929951%7CUnknown%7CTWFpbGZsb3d8e
>> yJWIjoiMC
>>>>
>> 4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&
>> amp;s
>>>>
>> data=oSmKjG6Za9DCSthbn72YfsQ1JsrUoaVSUCLNt7c5R4o%3D&amp;reserve
>> d=0
>>>>
>>>
>>> Hi Ferruh,
>>>
>>> Could you help to squash my fix patch into the patch series? As I've verified
>> it works locally.
>>>
>>> Hi Assli,
>>>
>>> Could you help to check after Ferruh squashed the fix patch into the next-
>> net?
>>>
>>
>> Hi Assli,
>>
>> The other-way around is safer perhaps, can you please test with the patch:
>> https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fpatc
>> hes.dpdk.org%2Fpatch%2F86804%2F&amp;data=04%7C01%7Codia%40nvidia
>> .com%7C4b212e1ae3d045b6264108d8bbbd7703%7C43083d15727340c1b7db3
>> 9efd9ccc17a%7C0%7C0%7C637465769725939943%7CUnknown%7CTWFpbGZs
>> b3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn
>> 0%3D%7C1000&amp;sdata=ZQU7m8zNXw%2BKxeG6AcveYp9Dpa4k%2BdeO
>> 2hK5DiBT3lg%3D&amp;reserved=0
>>
>> If it is good, I can squash it in the next-net.
>>
>> Thanks,
>> ferruh
> 
> Hi Guys,
> 
> I tested it in my side and it works

Thanks Assli, Leyi, I will proceed with the patch.

> Can you please the Bugzilla bug 619?
> 


  reply	other threads:[~2021-01-18 16:37 UTC|newest]

Thread overview: 42+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-12-15  2:19 [dpdk-dev] [PATCH " Leyi Rong
2020-12-15  2:19 ` [dpdk-dev] [PATCH 1/3] net/i40e: remove devarg use-latest-supported-vec Leyi Rong
2020-12-15  2:19 ` [dpdk-dev] [PATCH 2/3] net/i40e: add AVX512 vector path Leyi Rong
2020-12-15  2:19 ` [dpdk-dev] [PATCH 3/3] net/i40e: optimize Tx by using AVX512 Leyi Rong
2021-01-07  7:44 ` [dpdk-dev] [PATCH v2 0/3] AVX512 vPMD on i40e Leyi Rong
2021-01-07  7:44   ` [dpdk-dev] [PATCH v2 1/3] net/i40e: remove devarg use-latest-supported-vec Leyi Rong
2021-01-13  6:12     ` Lu, Wenzhuo
2021-01-13 13:40     ` Ferruh Yigit
2021-01-07  7:44   ` [dpdk-dev] [PATCH v2 2/3] net/i40e: add AVX512 vector path Leyi Rong
2021-01-13  6:13     ` Lu, Wenzhuo
2021-01-07  7:44   ` [dpdk-dev] [PATCH v2 3/3] net/i40e: optimize Tx by using AVX512 Leyi Rong
2021-01-13  6:12     ` Lu, Wenzhuo
2021-01-13  9:53   ` [dpdk-dev] [PATCH v2 0/3] AVX512 vPMD on i40e Zhang, Qi Z
2021-01-14  6:39 ` [dpdk-dev] [PATCH v3 " Leyi Rong
2021-01-14  6:39   ` [dpdk-dev] [PATCH v3 1/3] net/i40e: remove devarg use-latest-supported-vec Leyi Rong
2021-01-15 13:36     ` Ferruh Yigit
2021-01-14  6:39   ` [dpdk-dev] [PATCH v3 2/3] net/i40e: add AVX512 vector path Leyi Rong
2021-01-14  6:39   ` [dpdk-dev] [PATCH v3 3/3] net/i40e: optimize Tx by using AVX512 Leyi Rong
2021-01-14  7:37   ` [dpdk-dev] [PATCH v3 0/3] AVX512 vPMD on i40e Zhang, Qi Z
2021-01-17 11:26     ` Odi Assli
2021-01-18 13:58       ` Rong, Leyi
2021-01-18 14:24         ` Ferruh Yigit
2021-01-18 14:53           ` Odi Assli
2021-01-18 16:36             ` Ferruh Yigit [this message]
2021-01-19 13:46               ` Ali Alnubani
2021-01-20  6:25                 ` Tal Shnaiderman
2021-01-20  8:36                   ` David Marchand
2021-01-20  9:18                     ` Ferruh Yigit
2021-01-20  9:23                     ` Thomas Monjalon
2021-01-20  9:53                       ` David Marchand
2021-01-20 10:05                         ` Ali Alnubani
2021-01-20 17:51                           ` Ferruh Yigit
2021-01-20 18:04                             ` Ferruh Yigit
2021-01-21  5:01                             ` Kadam, Pallavi
2021-01-25 14:35                               ` David Marchand
2021-01-26 16:17                                 ` Rong, Leyi
2021-01-26 16:22                                   ` Thomas Monjalon
2021-01-26 16:39                                     ` Ferruh Yigit
2021-01-26 16:48                                       ` Thomas Monjalon
2021-01-26 16:51                                         ` Ferruh Yigit
2021-01-28 20:35                                           ` Dmitry Kozlyuk
2021-01-28 21:24                                             ` Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c0d0e722-2a3a-a822-0192-d3f2cf996545@intel.com \
    --to=ferruh.yigit@intel.com \
    --cc=alialnu@nvidia.com \
    --cc=beilei.xing@intel.com \
    --cc=bruce.richardson@intel.com \
    --cc=dev@dpdk.org \
    --cc=leyi.rong@intel.com \
    --cc=odia@nvidia.com \
    --cc=pallavi.kadam@intel.com \
    --cc=qi.z.zhang@intel.com \
    --cc=ranjit.menon@intel.com \
    --cc=rasland@nvidia.com \
    --cc=talshn@nvidia.com \
    --cc=thomas@monjalon.net \
    --cc=wenzhuo.lu@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

DPDK patches and discussions

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://inbox.dpdk.org/dev/0 dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dev dev/ https://inbox.dpdk.org/dev \
		dev@dpdk.org
	public-inbox-index dev

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dev


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git