From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8452AA055A; Mon, 5 Sep 2022 17:38:26 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 28A05400D6; Mon, 5 Sep 2022 17:38:26 +0200 (CEST) Received: from NAM12-BN8-obe.outbound.protection.outlook.com (mail-bn8nam12on2050.outbound.protection.outlook.com [40.107.237.50]) by mails.dpdk.org (Postfix) with ESMTP id D399540041 for ; Mon, 5 Sep 2022 17:38:24 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=UWuZrXQ9YGtN0qYWseBeMHhwdB9SQMTxzf5RhjbJRDoOWNEo3eBc0Uvmj8k4nZwMJfgdlt0M/811Zxx8rL4PasGi+ubGRMSLhAkgqH1Ewip2ARWxJrt1+gZx0bao51JUCsk8oEdf39WXik5iImknA4FJYUdCJJUZ0IrHNOgvjZThIlkBGNHzWwMIvUrKOE8aRetvtSVmvPYNqjtW93H5qFbb3TErrxMovgFAcljcHoBuBmXIP36vvwpIZ/P+Q8xZUIGOfzcL8VetgX6P9P4pavsuYOgKMItYimRlRZaJNIAKZfJ9CO8pgo9oEur3ulK5T741scvKPJtN0XsRRsIS7g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=YpWHJciMjHByH6F/O/SzW1D/0IhU/aN1zE0S3nsLfSI=; b=nLEQG8ZV3A9mq916JmH+2U+nDjsM6r0g7nM6NFsYlp9zZBnv43n2nVIXBJFWH3M7N/DSnE6Pko4vLAt5b15+gPvuwXFICL+2IX75cBuMmGLqD0KMkKg5DPYGgQA0a/FsPFWIXlLsrGJjyMTAzEoR9p+ohPdpfY3KKjCimK6Uwv2905L4DmZW0Yovw306qduVdaIXEzOubPPmRXGdKeAXKFw7ZUlL6mFGDUG15l8QHz7YdDwDIoqqnSV9KnC+QiPdaP/LJ1q6QDXb+riaRGduOk+Zy0Fhu3AQZp5WzGboB6D3fQYx4/nnsXAsyOMS4dY5CJjNzc+mXljp1t/wvEvwjA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 149.199.80.198) smtp.rcpttodomain=corigine.com smtp.mailfrom=xilinx.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=xilinx.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=xilinx.onmicrosoft.com; s=selector2-xilinx-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=YpWHJciMjHByH6F/O/SzW1D/0IhU/aN1zE0S3nsLfSI=; b=U9qJS7pRIW+HfVefiXTAXCyblu1pdBieAKF0M3v90py7UaqEyIE7VnW9T6YR2MY5nyV+Q0+UHOGfaF9pRlq/n06MwNdDZLnchRSdqD3n0o1BvImgU2xdUTBWWm9PBrxjPiJ1sRQD+rPMQilzltWpiP+ArzRiGsJCyDwxmTAuFXI= Received: from SA1P222CA0003.NAMP222.PROD.OUTLOOK.COM (2603:10b6:806:22c::31) by DM6PR02MB5929.namprd02.prod.outlook.com (2603:10b6:5:153::25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.17; Mon, 5 Sep 2022 15:38:22 +0000 Received: from SN1NAM02FT0063.eop-nam02.prod.protection.outlook.com (2603:10b6:806:22c:cafe::70) by SA1P222CA0003.outlook.office365.com (2603:10b6:806:22c::31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.10 via Frontend Transport; Mon, 5 Sep 2022 15:38:22 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 149.199.80.198) smtp.mailfrom=xilinx.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=xilinx.com; Received-SPF: Pass (protection.outlook.com: domain of xilinx.com designates 149.199.80.198 as permitted sender) receiver=protection.outlook.com; client-ip=149.199.80.198; helo=xir-pvapexch01.xlnx.xilinx.com; pr=C Received: from xir-pvapexch01.xlnx.xilinx.com (149.199.80.198) by SN1NAM02FT0063.mail.protection.outlook.com (10.97.5.98) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5588.10 via Frontend Transport; Mon, 5 Sep 2022 15:38:20 +0000 Received: from xir-pvapexch01.xlnx.xilinx.com (172.21.17.15) by xir-pvapexch01.xlnx.xilinx.com (172.21.17.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.24; Mon, 5 Sep 2022 16:38:18 +0100 Received: from smtp.xilinx.com (172.21.105.197) by xir-pvapexch01.xlnx.xilinx.com (172.21.17.15) with Microsoft SMTP Server id 15.1.2375.24 via Frontend Transport; Mon, 5 Sep 2022 16:38:18 +0100 Envelope-to: chaoyong.he@corigine.com, dev@dpdk.org, oss-drivers@corigine.com, niklas.soderlund@corigine.com, heinrich.kuhn@corigine.com Received: from [10.71.194.74] (port=14704) by smtp.xilinx.com with esmtp (Exim 4.90) (envelope-from ) id 1oVEB0-0001ZR-HB; Mon, 05 Sep 2022 16:38:18 +0100 Message-ID: Date: Mon, 5 Sep 2022 16:38:18 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.2.1 From: Ferruh Yigit Subject: Re: [PATCH v7 01/12] net/nfp: move app specific attributes to own struct To: Chaoyong He , CC: , , Heinrich Kuhn References: <1660299750-10668-1-git-send-email-chaoyong.he@corigine.com> <1660299750-10668-2-git-send-email-chaoyong.he@corigine.com> Content-Language: en-US In-Reply-To: <1660299750-10668-2-git-send-email-chaoyong.he@corigine.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: e949d518-5bc0-47e3-21d6-08da8f54a91c X-MS-TrafficTypeDiagnostic: DM6PR02MB5929:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: oAAW337r+n1Q/htiA8mtxUueq3GbgqsbsDx+16Ui0pOKsQGjSTvqCmB1I1R5PD/07NhTmS/y9T2L3VpW4Ys/iS8zEIOz4vQCM0F1TRgHOivo1cMFNOCrljwzeacofJ6GRNZe+HtTQVfO8ey7AciNsXiX3jGKxmYUZoq6dvwo1p0ZyHvnfdBuZsisDxT8ePrbHMwfHtKxpTppmASpfsT6gDmg2Uznu/bZMm6LtQA+4n2oTacApfjnMLkfY2TTZ9t7QOyVMde4Ik86BY9dqk9Z7aedoayih8qPJsqGz8wYO4+B/3xYgd7CyX/ZlbUyIHbXydXGfHYLuPkktRYB+IA1Rzjl5cLREHG6SPi/hFQKxCHrwCj62zDct1dw1luwCmQUNum7amZ0PdtPWiT8eKgn/7nvsoKU2ORwaHw5WzVfb2B3q2I36ZEMgfDzqJEvQh8tHaIrrC+stF9N8a9SXbOO/Qzok6XnNTPwvhcl3O7A8ZjznrUeAlDnee3ZXOwKCqpL2S3z3FiFNHeYJFJlWXwwxWiNGhQLF7vGZoEQd0ye+vt6VDOuJb3C/0AFHzvDZ0Z4dpjrUrqEus5Zv0fnkSI60vSSBBsP1/UFJwllcEjynCFJ/+ETn3Q2W6MUeY7pczRAomKu8bjkrKn+rYb1ncO9hNl72SQJtCSGUP76XtlGMjBTTwPStPJ3x63DenHbu07FevZDCQPiArUu0mbtlPHcr2AOsk3olCSVU9yTykOSCEfP8PRUNM1hSWwyIKnMrLCvSShCbFd18F4E+NCxcpvZ2ZVwDsrb8HE5Q/UoT4sxCw0sxxP9Bh4LyRTw954eF4Ox X-Forefront-Antispam-Report: CIP:149.199.80.198; CTRY:IE; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:xir-pvapexch01.xlnx.xilinx.com; PTR:unknown-80-198.xilinx.com; CAT:NONE; SFS:(13230016)(4636009)(346002)(376002)(396003)(39860400002)(136003)(40470700004)(36840700001)(46966006)(36860700001)(7636003)(4326008)(70206006)(356005)(8676002)(70586007)(82740400003)(66574015)(2616005)(336012)(426003)(47076005)(186003)(41300700001)(316002)(40460700003)(26005)(54906003)(53546011)(110136005)(31686004)(83380400001)(9786002)(8936002)(5660300002)(478600001)(2906002)(44832011)(31696002)(82310400005)(4744005)(40480700001)(36756003)(50156003)(43740500002); DIR:OUT; SFP:1101; X-OriginatorOrg: xilinx.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Sep 2022 15:38:20.1220 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: e949d518-5bc0-47e3-21d6-08da8f54a91c X-MS-Exchange-CrossTenant-Id: 657af505-d5df-48d0-8300-c31994686c5c X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=657af505-d5df-48d0-8300-c31994686c5c; Ip=[149.199.80.198]; Helo=[xir-pvapexch01.xlnx.xilinx.com] X-MS-Exchange-CrossTenant-AuthSource: SN1NAM02FT0063.eop-nam02.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR02MB5929 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 8/12/2022 11:22 AM, Chaoyong He wrote: > The NFP Card can load different firmware applications. Currently > only the CoreNIC application is supported. This commit makes > needed infrastructure changes in order to support other firmware > applications too. > App (or firmware application) is a little confusing, why not just call it FW? Same for code variable/struct names, and other patches. > Clearer separation is made between the PF device and any application > specific concepts. The PF struct is now generic regardless of the > application loaded. A new struct is also made for the CoreNIC > application. Future additions to support other applications should > also add an applications specific struct. > > Signed-off-by: Chaoyong He > Signed-off-by: Heinrich Kuhn > Reviewed-by: Niklas Söderlund