From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id CED06A0C4C; Tue, 5 Oct 2021 17:19:28 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id B8895413D0; Tue, 5 Oct 2021 17:19:28 +0200 (CEST) Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by mails.dpdk.org (Postfix) with ESMTP id C4B1E413CC for ; Tue, 5 Oct 2021 17:19:26 +0200 (CEST) X-IronPort-AV: E=McAfee;i="6200,9189,10128"; a="289275450" X-IronPort-AV: E=Sophos;i="5.85,349,1624345200"; d="scan'208";a="289275450" Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 Oct 2021 08:19:25 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.85,349,1624345200"; d="scan'208";a="567737752" Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by fmsmga002.fm.intel.com with ESMTP; 05 Oct 2021 08:19:25 -0700 Received: from fmsmsx604.amr.corp.intel.com (10.18.126.84) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Tue, 5 Oct 2021 08:19:25 -0700 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx604.amr.corp.intel.com (10.18.126.84) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12 via Frontend Transport; Tue, 5 Oct 2021 08:19:25 -0700 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (104.47.55.169) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.12; Tue, 5 Oct 2021 08:19:23 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ilLxnEYCIq58ijTwK2td62uy4U4YJY0NEkWDBBBhoFpv7r4I9WGYXJLE8Hhsaj2JS2cbbv+jpse0z5hIM+UTVduTqbPLFPs7z/wla+NguF67A2PnSEa9/kCYg1NOCs1BGBTr1tGkvNaOVhk3eYEc4PhGRlzpc3IT1KsNOU3ysVtDNzo8uaqDJio9n/X4mHAw3OO1O6zgCdSOqhfFU0Exu3tTurTq6tJp4xpkFFLj3bUS9ywSAfk0yYEN49EiClBgCZyyKvVx594Fd+yKBpHXTff6aNbEYxpNCW3/ERucT6wpTXNO6EwX2UC2vHxU1HrGFoBhRQXM4z/qvy8knhk2Ew== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=w3C5pw4fjWeb7Zpg9DrYQLXgyt5i22zceg5q9kw3o+I=; b=BXkV38JmDPNHm/PhHAo5l8eRcDHqUS+qAoeUH6wlskbOd25n0NfRRka7Dyg6w5HhuOOipRRpZjDTrOFE3LJlCXjAOUTMq27dTBkc9crHfRMUhgV7yh3ooaygZhos+38lW1lxgOHWTQM7XtalKtlYgDXi248RoFDS41rsVRbkBd1a6NKyOqLNeDrUqodo3I5QDWlBIpfckCFwH07j3VArGQkrEqvHF8OsOzVCeGWmPSfOb14ks5AGNnYVu/+FpAY9/f9VPMLZJy0zZ7d2bP5VwnnJ2ncW2c/fDaMbrSCi6gdA2RqeYRue2K4n/vW+Wp9ZpPArZbmJRROW/QxQyALkWQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=w3C5pw4fjWeb7Zpg9DrYQLXgyt5i22zceg5q9kw3o+I=; b=VvmMmBT1PANMBs2IXSjla0OOxRQiijRA3XrjlozXid7ZzdMXxBHBCgU9DEO4S4lCTTVKELtA0clOWcubKq9r8XmGOyQJZFTg76OHEc8/0zdMYGxToZlfISpNK79xcHIYbgDVweX3QoV8i47GVkXN3a5+To48Mi3rAXPqq68NFDI= Authentication-Results: dpdk.org; dkim=none (message not signed) header.d=none;dpdk.org; dmarc=none action=none header.from=intel.com; Received: from SA2PR11MB5210.namprd11.prod.outlook.com (2603:10b6:806:fa::23) by SN6PR11MB2623.namprd11.prod.outlook.com (2603:10b6:805:5d::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4566.19; Tue, 5 Oct 2021 15:19:22 +0000 Received: from SA2PR11MB5210.namprd11.prod.outlook.com ([fe80::e5f6:85a1:af0d:705e]) by SA2PR11MB5210.namprd11.prod.outlook.com ([fe80::e5f6:85a1:af0d:705e%7]) with mapi id 15.20.4566.022; Tue, 5 Oct 2021 15:19:22 +0000 To: References: <20210915141030.23514-1-bruce.richardson@intel.com> <20211005135909.726091-1-bruce.richardson@intel.com> <20211005135909.726091-4-bruce.richardson@intel.com> <93a5ae93-7acf-658a-4413-0e879c65e14d@redhat.com> From: Conor Walsh Message-ID: Date: Tue, 5 Oct 2021 16:19:17 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.14.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US X-ClientProxiedBy: DB6PR0801CA0066.eurprd08.prod.outlook.com (2603:10a6:4:2b::34) To SA2PR11MB5210.namprd11.prod.outlook.com (2603:10b6:806:fa::23) MIME-Version: 1.0 Received: from [192.168.1.10] (109.78.83.30) by DB6PR0801CA0066.eurprd08.prod.outlook.com (2603:10a6:4:2b::34) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4566.14 via Frontend Transport; Tue, 5 Oct 2021 15:19:22 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: aa60538d-caf0-4781-b9c2-08d98813827e X-MS-TrafficTypeDiagnostic: SN6PR11MB2623: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:8882; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Tvlq8A4lY40qocF246UFZQt993DUiF3+NlDnTCEX3o81r+wmrHFVcwV14Aa/Uax7KIm2Z29nIDOsqV+Sl2EgS+Jpoo+KNcGHDlo0Q+P7nHJfNRUDQp4vMHMGRi1DR7uYtdrdwXpt2m8Lcvow8nHRBVcdjMzbZ85z/c9KBFNqEVKN00AIM4oHbnuaBW5mEFNXTnCXVoEc1QmTTi3MLRr6zgdOOep1FMx9fYYtcwH2+TPE7L6fzQk2fOzpp6XPERztarOuH4czoSyDhT7Z83SZDi1KdgOhjGCCMa3I5D1yc7i9yWMAW5xIJHdzbzMYJ0/3whhObpuAcjoWanjHhgPxaa3oNz2GY4oUuWZJRiLB7yKvKLvj39t+Yjst+8f7Q4FEqYRecWL5Tzc8pQdeLspNerYQTxzDOADvbBUhGRzL6W7TdPzMu+oFKF5MU6CnoOmrvQ0BrI20nuJp5jyw0qfAFvo1123ADPOh12Lkx9+O7tVDXwuCU5p5DAXF6CZP3I0mgQ9Y2PHFVnRtOIH0Rm2GoUvGY0Vgf+IbtQ/1Wo3QfnanqA0Abo1tc/LphxC+1MVJZD9VtEYOoP2BDZxZdkNh6Yi3xDFl51w/4nz2k5VzsNcsFiTT20WOJWbGbgiuh9XFVJeyaXJcwVyegYt1Hhv63i4uqulLU1oJ+DC+7zSZ9AbD1ebxTLM5EedNBtnDOffZQ21J+pRH2P1dunn5FzBFvlqk4CuyCYAQm+C5DS7iJC4= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SA2PR11MB5210.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(6916009)(66946007)(53546011)(66556008)(66476007)(8936002)(8676002)(31686004)(6666004)(6486002)(16576012)(38100700002)(316002)(36756003)(44832011)(26005)(508600001)(186003)(4744005)(31696002)(86362001)(2906002)(2616005)(956004)(5660300002)(43740500002)(45980500001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?cnZnSVl0STVxYm5tMnIrVnZncDBQK3NGeDdmYXRwUXFCQ0ZqcW5ZWXBJZHdP?= =?utf-8?B?bU44cXlFUU5HMmN4S3Y5WEpZWVdOTmd1NkNuWTZjc0tySDdRVUw4L2Z0R284?= =?utf-8?B?bkRIdzYzaUhYQk16RXZhVVVXWmk5b2twVmRkRE10RnFtb1ptNjBxU3ExVGxT?= =?utf-8?B?ejJBeE9MUnE4ZkNiR2N6cjZHdjJjUFhiakk4emV3RU84NzYrUlZMY0ZEeGxH?= =?utf-8?B?VllILzhwNzFsSDNFRFFIWnBtZzhoMzNrM0graXc4NDZYd0FteXZXUlRZZnRO?= =?utf-8?B?UlJPanJvdlBpV2k3NGxHNlhpbCtqOUJNY2tOMkp6MVpjcnlaTWQ4RmY5NEdC?= =?utf-8?B?RFVSK00rQ2Uya3M4TlBjcWxwYTZsZlFtb3VFWVhUS1kwQXZVNXFuWHI4bjF6?= =?utf-8?B?Nmd6Nzg0cWRuTkdnb25aMlZiTVZzdExMaC83ZThCOVRhclZKTFNBTWFIOGFE?= =?utf-8?B?QWVtcE5wTWlLUCsvZ1dVNFNGSlNiTWVVMDRLYkhhZEl1cUxBdXlKeHUxUElY?= =?utf-8?B?aTVoMHN5WEZKRlRhNmZ4bG1zQUFXRFVMTTROWWFJNG8wQTZpbno0ZlR5NWo3?= =?utf-8?B?dGY1QXYyVXVDbHNwRklmMEdkNDVLWStIR3doMkcreDZHN2JsUzhmaWJhcjRL?= =?utf-8?B?dEhrV3NmZ05WMkZIeGp4K2N2RFZsdzcyemlldEl1TisrbFd2ZWxPbUxxa2xY?= =?utf-8?B?RTZtbHc2ZEIxY2tBSGVGbUZDNTRwdEVqQ28vRFptdHZoZXpmREdVcmFGeDJ6?= =?utf-8?B?Z0tDY1pGaWZoZTYveDlBTTAwNHpiK3FQQjBQNjZQOFg0Mk1odXhvaWs2N1Y0?= =?utf-8?B?R0xQVDg3OE9EeWtEb3hXNFRhVDMrSGU4K3p1OEl2RHpuQlNMSWlhT0hUaHQ4?= =?utf-8?B?T1YySUlDUkozUys5NGM0WHhydHhyT2kvUG1ST1YvbXpTQ3FuN2hWWUErREV1?= =?utf-8?B?R3ZWb2dKazRHNEVaZ25kR1ZTR3g2UDQwa0gxRTZzMGdZOGo2cllGTEdsemFM?= =?utf-8?B?YXQySFF3S1JaWnN3NDAzYTkyZENIVjVpc29jWkNzQzcxdkUvQlFEdE5Ub2RF?= =?utf-8?B?N21pSmhKQ2xxeFBSV2VUeHBRMjA3TnpIQkdvRmx3ZXVXY3F3eXM5RnZzVnVD?= =?utf-8?B?cmhMcFJaWUtVKzdrQ00xRmxSNi9lKzNTQ0MvOU1mRCtvd0RjSkN2dkNteUNn?= =?utf-8?B?c0Jwcml1MjQ2U25GUElSM2x6ekQvNU4yeXVvbG1nUml3Zkd5SU1QV25MTVhi?= =?utf-8?B?SXk0bnBod1BISGRXMHJXUjNOcTVXYVNOZEtrQU5tZjMyUk9FNFZBTWx5STMx?= =?utf-8?B?aUNoQnUzbWt1dzY3aTZ4aE5rclBRUEhqZTh4MVNDOUFzaVhtZ3JnZGc2K3Nz?= =?utf-8?B?VU5pR1BBMU51blM2bUFVYUwzRHF2R3c2NnM3eG5PZjVvV1BoVTlKQkxZUXkz?= =?utf-8?B?SkYrVmE3N2VLb3p1WXF5Z3B6SndPY0ZFQ05Hb2ZJV3hVSUdjenJuampJOVMz?= =?utf-8?B?THZnT095Zm53S0NmMEFuRWVVVkxHZ1VyVm9uaktQS3lJL1VuYVhpeE94Vy9Z?= =?utf-8?B?SUQyLyt6VHB5RVJucUtjZ1F2c2xjaTgvQ3dzYnBrenpQZXAzaEhCT2ZLbnoz?= =?utf-8?B?YVdHQXRmL0VnMmoxSjk3QkE2aEdEeTgwMjlnQkNuNWFHM1Nxc2lZVTE5THZ1?= =?utf-8?B?TjRXNFVKeE9KTUVyU2QxT09QS3R6MGJaUFJ3VVFad21QRnlPV2R1djhSZFZj?= =?utf-8?Q?R2bJUq1m5Sr/ChJdCyleK3C5/JsB5hgfINUdUU1?= X-MS-Exchange-CrossTenant-Network-Message-Id: aa60538d-caf0-4781-b9c2-08d98813827e X-MS-Exchange-CrossTenant-AuthSource: SA2PR11MB5210.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Oct 2021 15:19:22.5491 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: yxuRezAIItqfQhL5vcGYez7lzrwLf/OYFvpvFkRL0FULG+5yRf57PIhL0ygWC+ao22BZmtulgcO4x86xh6kTlw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN6PR11MB2623 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH v6 3/5] telemetry: use unique socket paths for in-memory mode X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 05/10/2021 15:52, Bruce Richardson wrote: > On Tue, Oct 05, 2021 at 03:41:17PM +0100, Kevin Traynor wrote: >> Hi Bruce, I started reviewing v5 before v6 was pushed, so these are just >> comments from v5, >> > No problem. Changes V6-v5 are fairly small anyway. Thanks for the review. > >> On 05/10/2021 14:59, Bruce Richardson wrote: >>> When DPDK is run using "in-memory" flag, multiple processes can be run >>> using the same file-prefix and hence the same runtime directory. To >>> avoid problems with conflicting telemetry unix socket paths, we can >>> put the pid of the process into the socket name. As with the existing >>> telemetry socket files, these sockets are removed on normal program >>> exit. >>> >>> Signed-off-by: Bruce Richardson >>> --- Legacy telemetry does not prevent multiple v2 sockets anymore. Thanks, Conor. Tested-by: Conor Walsh