From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id F4236A0547; Mon, 19 Apr 2021 09:42:50 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 8283840683; Mon, 19 Apr 2021 09:42:50 +0200 (CEST) Received: from szxga06-in.huawei.com (szxga06-in.huawei.com [45.249.212.32]) by mails.dpdk.org (Postfix) with ESMTP id 91D9340040 for ; Mon, 19 Apr 2021 09:42:49 +0200 (CEST) Received: from DGGEMS401-HUB.china.huawei.com (unknown [172.30.72.58]) by szxga06-in.huawei.com (SkyGuard) with ESMTP id 4FNzJM68qXzlZ09 for ; Mon, 19 Apr 2021 15:40:51 +0800 (CST) Received: from [10.67.103.128] (10.67.103.128) by DGGEMS401-HUB.china.huawei.com (10.3.19.201) with Microsoft SMTP Server id 14.3.498.0; Mon, 19 Apr 2021 15:42:44 +0800 To: Ferruh Yigit , CC: References: <1616830586-46672-1-git-send-email-humin29@huawei.com> <89cedfc0-9a44-43ea-2390-7eeb65c1b4ab@intel.com> From: "Min Hu (Connor)" Message-ID: Date: Mon, 19 Apr 2021 15:42:44 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.3.1 MIME-Version: 1.0 In-Reply-To: <89cedfc0-9a44-43ea-2390-7eeb65c1b4ab@intel.com> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [10.67.103.128] X-CFilter-Loop: Reflected Subject: Re: [dpdk-dev] [PATCH] examples/ptpclient: delete wrong comments X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi, Ferruh and all, If no other comments, could your please merge it into the branch? Thanks. 在 2021/4/12 16:04, Ferruh Yigit 写道: > On 4/10/2021 10:11 AM, Min Hu (Connor) wrote: >> Hi, Ferruh, kirill and all, >>      Any comments about this patch? >> >> 在 2021/3/27 15:36, Min Hu (Connor) 写道: >>> This patch deletes the comments which are wrong and unnecessary. >>> >>> Fixes: ab129e9065a5 ("examples/ptpclient: add minimal PTP client") >>> Cc: stable@dpdk.org >>> >>> Signed-off-by: Min Hu (Connor) >>> --- >>>   examples/ptpclient/ptpclient.c | 4 ---- >>>   1 file changed, 4 deletions(-) >>> >>> diff --git a/examples/ptpclient/ptpclient.c >>> b/examples/ptpclient/ptpclient.c >>> index 33b297e..878d1a0 100644 >>> --- a/examples/ptpclient/ptpclient.c >>> +++ b/examples/ptpclient/ptpclient.c >>> @@ -606,10 +606,6 @@ lcore_main(void) >>>       unsigned nb_rx; >>>       struct rte_mbuf *m; >>> -    /* >>> -     * Check that the port is on the same NUMA node as the polling >>> thread >>> -     * for best performance. >>> -     */ >>>       printf("\nCore %u Waiting for SYNC packets. [Ctrl+C to quit]\n", >>>               rte_lcore_id()); >>> > > Acked-by: Ferruh Yigit > > The comment seems left over from the example this example cloned from.. > .