From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by dpdk.org (Postfix) with ESMTP id 8F0201B503 for ; Tue, 26 Jun 2018 13:47:41 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga105.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 26 Jun 2018 04:47:40 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.51,274,1526367600"; d="scan'208";a="67368663" Received: from aburakov-mobl.ger.corp.intel.com (HELO [10.237.220.28]) ([10.237.220.28]) by fmsmga001.fm.intel.com with ESMTP; 26 Jun 2018 04:47:34 -0700 To: Qi Zhang , thomas@monjalon.net Cc: konstantin.ananyev@intel.com, dev@dpdk.org, bruce.richardson@intel.com, ferruh.yigit@intel.com, benjamin.h.shelton@intel.com, narender.vangati@intel.com References: <20180607123849.14439-1-qi.z.zhang@intel.com> <20180626070832.3055-1-qi.z.zhang@intel.com> <20180626070832.3055-2-qi.z.zhang@intel.com> From: "Burakov, Anatoly" Message-ID: Date: Tue, 26 Jun 2018 12:47:34 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.8.0 MIME-Version: 1.0 In-Reply-To: <20180626070832.3055-2-qi.z.zhang@intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v4 01/24] eal: introduce one device scan X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 26 Jun 2018 11:47:42 -0000 On 26-Jun-18 8:08 AM, Qi Zhang wrote: > When hot plug a new device, it is not necessary to scan everything > on the bus since the devname and devargs are already there. So new > rte_bus ops "scan_one" is introduced, bus driver can implement this > function to simplify the hotplug process. > > Signed-off-by: Qi Zhang > --- > > + * NULL for unsuccessful scan > + */ > +typedef struct rte_device *(*rte_bus_scan_one_t)(struct rte_devargs *devargs); > + > +/** > * Implementation specific probe function which is responsible for linking > * devices on that bus with applicable drivers. > * > @@ -204,6 +219,7 @@ struct rte_bus { > TAILQ_ENTRY(rte_bus) next; /**< Next bus object in linked list */ > const char *name; /**< Name of the bus */ > rte_bus_scan_t scan; /**< Scan for devices attached to bus */ > + rte_bus_scan_one_t scan_one; /**< Scan one device using devargs */ > rte_bus_probe_t probe; /**< Probe devices on bus */ > rte_bus_find_device_t find_device; /**< Find a device on the bus */ > rte_bus_plug_t plug; /**< Probe single device for drivers */ > Does changing this structure break ABI for bus drivers? -- Thanks, Anatoly