From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 369D7A0558; Tue, 16 Feb 2021 14:14:08 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id ADF7D160746; Tue, 16 Feb 2021 14:14:07 +0100 (CET) Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by mails.dpdk.org (Postfix) with ESMTP id 8ACE040690 for <dev@dpdk.org>; Tue, 16 Feb 2021 14:14:05 +0100 (CET) IronPort-SDR: zNa8vDHWKKPK1uszcXL4V+cW1tSHsQlcRF3bndWPqty3nMjqooi2za34DzseaZBmsNh4sTQaQD RN6bxAl5badQ== X-IronPort-AV: E=McAfee;i="6000,8403,9896"; a="179377553" X-IronPort-AV: E=Sophos;i="5.81,183,1610438400"; d="scan'208";a="179377553" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Feb 2021 05:14:04 -0800 IronPort-SDR: oklf41iDV/hFUEKMLYw5cgCGJwi81dfN8x7ah1I9cgVKn11+rwubWhb+lAHEsNeUNb6iC+Gga1 fOiRh9jjJtyw== X-IronPort-AV: E=Sophos;i="5.81,183,1610438400"; d="scan'208";a="399497496" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.213.232.248]) ([10.213.232.248]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Feb 2021 05:14:03 -0800 To: Asaf Penso <asafp@nvidia.com>, dev@dpdk.org Cc: thomas@monjalon.net, Andrew Rybchenko <arybchenko@solarflare.com> References: <1612694777-31505-1-git-send-email-asafp@nvidia.com> <1612695128-31878-1-git-send-email-asafp@nvidia.com> From: Ferruh Yigit <ferruh.yigit@intel.com> X-User: ferruhy Message-ID: <c1bd47eb-94ed-7607-ed93-0f31ee95335d@intel.com> Date: Tue, 16 Feb 2021 13:13:59 +0000 MIME-Version: 1.0 In-Reply-To: <1612695128-31878-1-git-send-email-asafp@nvidia.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH v4] doc: add new tables for rte flow items and actions support X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> On 2/7/2021 10:52 AM, Asaf Penso wrote: > In http://doc.dpdk.org/guides/nics/overview.html, table 1.1 lists all > supported features. > It has a single line for "Flow API" that refers to rte_flow support. > rte_flow is composed of many items and actions that are not expressed in > this single line. > > The following new tables are suggested: > 1. rte_flow items > 2. rte_flow actions > Hi Asaf, I understand the intention, but I am not sure about this. The Flow API does not provide a capability or feature list in the API level, by design, because it is very hard to do it correct, but this patch tries to do it in the documentation level. This will be missing lots of details, the flow items and actions documented as supported may and may not be supported based on the details. It will be very hard to read this table (when it becomes full), also will be very hard to maintain. Let me start with a question, who do you think will be your consumer? Who will benefit from this table and how? > Also, since each table needs a new section in the pmd ini > file that might not be relevant for all pmds, the print > error message for missing section in conf.py is removed. > > Signed-off-by: Asaf Penso <asafp@nvidia.com> <...>