From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 5037BA05D3 for ; Tue, 21 May 2019 18:30:45 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 3BE5514EC; Tue, 21 May 2019 18:30:44 +0200 (CEST) Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id 4BEC4A3 for ; Tue, 21 May 2019 18:30:42 +0200 (CEST) Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id A7B3A5946F; Tue, 21 May 2019 16:30:31 +0000 (UTC) Received: from [10.36.118.41] (unknown [10.36.118.41]) by smtp.corp.redhat.com (Postfix) with ESMTP id 8DF3A59157; Tue, 21 May 2019 16:30:24 +0000 (UTC) To: Ferruh Yigit , Yong Wang , john.mcnamara@intel.com Cc: dev@dpdk.org, Thomas Monjalon , Luca Boccassi , Yongseok Koh References: <1558428409-29815-1-git-send-email-wang.yong19@zte.com.cn> From: Kevin Traynor Message-ID: Date: Tue, 21 May 2019 17:30:23 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.39]); Tue, 21 May 2019 16:30:38 +0000 (UTC) Subject: Re: [dpdk-dev] [PATCH] doc: fix typo in release note X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 21/05/2019 15:33, Ferruh Yigit wrote: > On 5/21/2019 9:46 AM, Yong Wang wrote: >> The patch fixes some typoes in 19.02 release note. >> >> Fixes: 6f04df497962 ("doc: add release notes for mlx5") >> Fixes: bf9a90e2b562 ("doc: update release notes for 19.02") >> >> Signed-off-by: Yong Wang > > I am not in favor of updating old release notes, I believe the release notes is > valid in the context of the release, so I am for keeping them as they released > (with all their faults). > Although we updated them in the past, and I don't have strong opinion on this, > but lets take this as -1 from my side. > > Btw, while thinking perhaps this make sense for stable trees, I don't know if > stable releases has the release notes? > @Kevin, @Luca, > As far as I can see LTS 16.11 & 17.11 updates the release notes with the fixed > commits, but this is not done by 18.11. > And update is only on commits it has, can any release notes update fix be merged > into stable tree? > It's a good question, chatted with Ferruh on IRC. I think mistakes in the release notes can be backported fine. The other case is if someone adds a note in 19.05 release notes as part of a fix that is backported to 18.11. Then it's more tricky because it won't apply to 18.11 release notes and it is not what was tested in Tested Platforms from the original release. One option is to add another additional section for for each stable release (in addition to the bugfix and validation list) for new notes. Of course it means manual editing, or dedicated backports, so I'm not really sure if it's worth the effort or not but it should be a rare event.