From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9860CA09F6; Fri, 18 Dec 2020 00:17:23 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 799E9CA44; Fri, 18 Dec 2020 00:17:22 +0100 (CET) Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id 4B373CA38 for <dev@dpdk.org>; Fri, 18 Dec 2020 00:17:21 +0100 (CET) IronPort-SDR: wVHDogjxTlHZ+Aza8OcOHJZCs/XsR5K2sCWHFTQex+S47ocLK73o1vsPDxX6PB64sxXvvjccf/ tS/aUxuS7zyg== X-IronPort-AV: E=McAfee;i="6000,8403,9838"; a="174578321" X-IronPort-AV: E=Sophos;i="5.78,428,1599548400"; d="scan'208";a="174578321" Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Dec 2020 15:17:19 -0800 IronPort-SDR: HDL4/woHJDBf1TGhmjIlHeTThe5GfW09sPpsGruWGvwG1r7tbJA2FrWvdItcgT627Bbwroersp az0VSQcidoUw== X-IronPort-AV: E=Sophos;i="5.78,428,1599548400"; d="scan'208";a="558290861" Received: from pkadam-mobl1.amr.corp.intel.com (HELO [10.212.207.37]) ([10.212.207.37]) by orsmga005-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Dec 2020 15:17:19 -0800 To: Thomas Monjalon <thomas@monjalon.net> Cc: dev@dpdk.org, ranjit.menon@intel.com, dmitry.kozliuk@gmail.com, Narcisa.Vasile@microsoft.com, talshn@nvidia.com, ferruh.yigit@intel.com, beilei.xing@intel.com, jia.guo@intel.com References: <20201205011020.6276-1-pallavi.kadam@intel.com> <1656459.hZBu3j2uRN@thomas> <3fdb608d-1fb2-a307-8bbb-3878f7a1f38b@intel.com> <9032110.0djWmH6T1b@thomas> From: "Kadam, Pallavi" <pallavi.kadam@intel.com> Message-ID: <c2109e4a-e9e9-855a-1137-b2ed4e55a21b@intel.com> Date: Thu, 17 Dec 2020 15:17:18 -0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.5.1 MIME-Version: 1.0 In-Reply-To: <9032110.0djWmH6T1b@thomas> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US Subject: Re: [dpdk-dev] [PATCH 2/3] net/i40e: add changes to support i40e PMD on windows X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> On 12/9/2020 12:59 AM, Thomas Monjalon wrote: > 09/12/2020 01:21, Kadam, Pallavi: >> On 12/6/2020 7:49 AM, Thomas Monjalon wrote: >>> 05/12/2020 02:10, Pallavi Kadam: >>>> --- a/lib/librte_eal/windows/include/rte_windows.h >>>> +++ b/lib/librte_eal/windows/include/rte_windows.h >>>> @@ -18,6 +18,11 @@ >>>> #define WIN32_LEAN_AND_MEAN >>>> #endif >>>> >>>> +#ifdef __clang__ >>>> +#undef _m_prefetchw >>>> +#define _m_prefetchw __m_prefetchw >>>> +#endif >>> These changes are not specific to i40e, please separate. >> Ok, will create a separate patch in v2. >> This change is required once we add rte_random.c file on windows. >> So, may be addition of rte_random.c file and this change should go together? >> Please suggest. Thanks, > Yes absolutely, addition of random feature should be atomic in a patch. Ok. Created a separate patch in v2. Thanks! > >