* [dpdk-dev] [PATCH] ethdev: fix removing jumbo offload flag
@ 2021-10-22 12:17 Ferruh Yigit
2021-10-22 12:23 ` Andrew Rybchenko
2021-10-22 12:57 ` [dpdk-dev] [PATCH v2 1/2] doc: remove jumbo offload feature Ferruh Yigit
0 siblings, 2 replies; 9+ messages in thread
From: Ferruh Yigit @ 2021-10-22 12:17 UTC (permalink / raw)
To: Shepard Siegel, Ed Czeck, John Miller, Igor Russkikh,
Steven Webster, Matt Peters, Chandubabu Namburu, Ajit Khaparde,
Somnath Kotur, Nithin Dabilpuram, Kiran Kumar K,
Sunil Kumar Kori, Satha Rao, Rahul Lakkireddy, Hemant Agrawal,
Sachin Saxena, Haiyue Wang, Marcin Wojtas, Michal Krawczyk,
Shai Brandes, Evgeny Schemeilin, Igor Chauskin, Gagandeep Singh,
John Daley, Hyong Youb Kim, Gaetan Rivet, Qi Zhang, Xiao Wang,
Ziyang Xuan, Xiaoyun Wang, Guoyang Zhou, Min Hu (Connor),
Yisen Zhuang, Lijun Ou, Beilei Xing, Jingjing Wu, Qiming Yang,
Andrew Boyer, Rosen Xu, Shijith Thotton,
Srisivasubramanian Srinivasan, Jakub Grajciar, Matan Azrad,
Viacheslav Ovsiienko, Zyta Szpak, Liron Himi, Heinrich Kuhn,
Harman Kalra, Jerin Jacob, Rasesh Mody, Devendra Singh Rawat,
Andrew Rybchenko, Maciej Czekaj, Jiawen Wu, Jian Wang, Yong Wang,
Konstantin Ananyev
Cc: Ferruh Yigit, dev
After DEV_RX_OFFLOAD_JUMBO_FRAME flag removed, jumbo frame decision is
given by MTU value checks, but some of the checks were wrong by mistake,
causing device initialization to fail, fixing them.
Also removing 'Jumbo frame' feature.
Fixes: b563c1421282 ("ethdev: remove jumbo offload flag")
Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
---
Some of the check mistakes are residue of local changes, I remember
fixing them, but it looks like something went wrong while sending
patches.
---
doc/guides/nics/features.rst | 12 ---------
doc/guides/nics/features/ark.ini | 1 -
doc/guides/nics/features/atlantic.ini | 1 -
doc/guides/nics/features/avp.ini | 1 -
doc/guides/nics/features/axgbe.ini | 1 -
doc/guides/nics/features/bnxt.ini | 1 -
doc/guides/nics/features/cnxk.ini | 1 -
doc/guides/nics/features/cnxk_vec.ini | 1 -
doc/guides/nics/features/cnxk_vf.ini | 1 -
doc/guides/nics/features/cxgbe.ini | 1 -
doc/guides/nics/features/cxgbevf.ini | 1 -
doc/guides/nics/features/default.ini | 1 -
doc/guides/nics/features/dpaa.ini | 1 -
doc/guides/nics/features/dpaa2.ini | 1 -
doc/guides/nics/features/e1000.ini | 1 -
doc/guides/nics/features/ena.ini | 1 -
doc/guides/nics/features/enetc.ini | 1 -
doc/guides/nics/features/enic.ini | 1 -
doc/guides/nics/features/failsafe.ini | 1 -
doc/guides/nics/features/fm10k.ini | 1 -
doc/guides/nics/features/fm10k_vf.ini | 1 -
doc/guides/nics/features/hinic.ini | 1 -
doc/guides/nics/features/hns3.ini | 1 -
doc/guides/nics/features/hns3_vf.ini | 1 -
doc/guides/nics/features/i40e.ini | 1 -
doc/guides/nics/features/iavf.ini | 1 -
doc/guides/nics/features/ice.ini | 1 -
doc/guides/nics/features/ice_dcf.ini | 1 -
doc/guides/nics/features/igb.ini | 1 -
doc/guides/nics/features/igc.ini | 1 -
doc/guides/nics/features/ionic.ini | 1 -
doc/guides/nics/features/ipn3ke.ini | 1 -
doc/guides/nics/features/ixgbe.ini | 1 -
doc/guides/nics/features/ixgbe_vf.ini | 1 -
doc/guides/nics/features/liquidio.ini | 1 -
doc/guides/nics/features/memif.ini | 1 -
doc/guides/nics/features/mlx4.ini | 1 -
doc/guides/nics/features/mlx5.ini | 1 -
doc/guides/nics/features/mvneta.ini | 1 -
doc/guides/nics/features/mvpp2.ini | 1 -
doc/guides/nics/features/nfp.ini | 1 -
doc/guides/nics/features/octeontx.ini | 1 -
doc/guides/nics/features/octeontx2.ini | 1 -
doc/guides/nics/features/octeontx2_vec.ini | 1 -
doc/guides/nics/features/octeontx2_vf.ini | 1 -
doc/guides/nics/features/pcap.ini | 1 -
doc/guides/nics/features/qede.ini | 1 -
doc/guides/nics/features/qede_vf.ini | 1 -
doc/guides/nics/features/sfc.ini | 1 -
doc/guides/nics/features/thunderx.ini | 1 -
doc/guides/nics/features/txgbe.ini | 1 -
doc/guides/nics/features/txgbe_vf.ini | 1 -
doc/guides/nics/features/vmxnet3.ini | 1 -
drivers/net/e1000/igb_rxtx.c | 2 +-
drivers/net/i40e/i40e_rxtx.c | 27 +++++--------------
drivers/net/iavf/iavf_ethdev.c | 31 ++++++----------------
drivers/net/ice/ice_dcf_ethdev.c | 31 ++++++----------------
drivers/net/ice/ice_rxtx.c | 27 +++++--------------
drivers/net/igc/igc_txrx.c | 2 +-
drivers/net/ixgbe/ixgbe_rxtx.c | 2 +-
60 files changed, 33 insertions(+), 153 deletions(-)
diff --git a/doc/guides/nics/features.rst b/doc/guides/nics/features.rst
index d35751d5b5a7..676df5a5e3c8 100644
--- a/doc/guides/nics/features.rst
+++ b/doc/guides/nics/features.rst
@@ -158,18 +158,6 @@ Supports updating port MTU.
* **[related] API**: ``rte_eth_dev_set_mtu()``, ``rte_eth_dev_get_mtu()``.
-.. _nic_features_jumbo_frame:
-
-Jumbo frame
------------
-
-Supports Rx jumbo frames.
-
-* **[uses] rte_eth_rxconf,rte_eth_rxmode**: ``dev_conf.rxmode.mtu``.
-* **[related] rte_eth_dev_info**: ``max_rx_pktlen``.
-* **[related] API**: ``rte_eth_dev_set_mtu()``.
-
-
.. _nic_features_scattered_rx:
Scattered Rx
diff --git a/doc/guides/nics/features/ark.ini b/doc/guides/nics/features/ark.ini
index 5519984e3926..87b4209165d7 100644
--- a/doc/guides/nics/features/ark.ini
+++ b/doc/guides/nics/features/ark.ini
@@ -6,7 +6,6 @@
[Features]
Speed capabilities = Y
Queue start/stop = Y
-Jumbo frame = Y
Scattered Rx = Y
Basic stats = Y
Stats per queue = Y
diff --git a/doc/guides/nics/features/atlantic.ini b/doc/guides/nics/features/atlantic.ini
index d2ec33b21742..ef4155027c72 100644
--- a/doc/guides/nics/features/atlantic.ini
+++ b/doc/guides/nics/features/atlantic.ini
@@ -9,7 +9,6 @@ Link status = Y
Link status event = Y
Queue start/stop = Y
MTU update = Y
-Jumbo frame = Y
Promiscuous mode = Y
Allmulticast mode = Y
Unicast MAC filter = Y
diff --git a/doc/guides/nics/features/avp.ini b/doc/guides/nics/features/avp.ini
index 9352c989feaa..f2f115ba61e8 100644
--- a/doc/guides/nics/features/avp.ini
+++ b/doc/guides/nics/features/avp.ini
@@ -5,7 +5,6 @@
;
[Features]
Link status = Y
-Jumbo frame = Y
Scattered Rx = Y
Promiscuous mode = Y
Unicast MAC filter = Y
diff --git a/doc/guides/nics/features/axgbe.ini b/doc/guides/nics/features/axgbe.ini
index e11f440d7350..821bb682d433 100644
--- a/doc/guides/nics/features/axgbe.ini
+++ b/doc/guides/nics/features/axgbe.ini
@@ -6,7 +6,6 @@
[Features]
Speed capabilities = Y
Link status = Y
-Jumbo frame = Y
Scattered Rx = Y
Promiscuous mode = Y
Allmulticast mode = Y
diff --git a/doc/guides/nics/features/bnxt.ini b/doc/guides/nics/features/bnxt.ini
index c0e8ecb82be5..93aa98aedef9 100644
--- a/doc/guides/nics/features/bnxt.ini
+++ b/doc/guides/nics/features/bnxt.ini
@@ -12,7 +12,6 @@ Fast mbuf free = Y
Queue start/stop = Y
Burst mode info = Y
MTU update = Y
-Jumbo frame = Y
Scattered Rx = Y
LRO = Y
TSO = Y
diff --git a/doc/guides/nics/features/cnxk.ini b/doc/guides/nics/features/cnxk.ini
index 03af0da30297..1623a1803e7c 100644
--- a/doc/guides/nics/features/cnxk.ini
+++ b/doc/guides/nics/features/cnxk.ini
@@ -29,7 +29,6 @@ RSS reta update = Y
Inner RSS = Y
Inline protocol = Y
Flow control = Y
-Jumbo frame = Y
Scattered Rx = Y
L3 checksum offload = Y
L4 checksum offload = Y
diff --git a/doc/guides/nics/features/cnxk_vec.ini b/doc/guides/nics/features/cnxk_vec.ini
index 12ca0a587ca7..4b7c2bce4dd6 100644
--- a/doc/guides/nics/features/cnxk_vec.ini
+++ b/doc/guides/nics/features/cnxk_vec.ini
@@ -28,7 +28,6 @@ RSS reta update = Y
Inner RSS = Y
Inline protocol = Y
Flow control = Y
-Jumbo frame = Y
L3 checksum offload = Y
L4 checksum offload = Y
Inner L3 checksum = Y
diff --git a/doc/guides/nics/features/cnxk_vf.ini b/doc/guides/nics/features/cnxk_vf.ini
index f3d9f23f1749..0523be434d2b 100644
--- a/doc/guides/nics/features/cnxk_vf.ini
+++ b/doc/guides/nics/features/cnxk_vf.ini
@@ -23,7 +23,6 @@ RSS key update = Y
RSS reta update = Y
Inner RSS = Y
Inline protocol = Y
-Jumbo frame = Y
Scattered Rx = Y
L3 checksum offload = Y
L4 checksum offload = Y
diff --git a/doc/guides/nics/features/cxgbe.ini b/doc/guides/nics/features/cxgbe.ini
index f41fc1482527..f674803ec47f 100644
--- a/doc/guides/nics/features/cxgbe.ini
+++ b/doc/guides/nics/features/cxgbe.ini
@@ -8,7 +8,6 @@ Speed capabilities = Y
Link status = Y
Queue start/stop = Y
MTU update = Y
-Jumbo frame = Y
Scattered Rx = Y
TSO = Y
Promiscuous mode = Y
diff --git a/doc/guides/nics/features/cxgbevf.ini b/doc/guides/nics/features/cxgbevf.ini
index a3174ef39955..a34fddd64e33 100644
--- a/doc/guides/nics/features/cxgbevf.ini
+++ b/doc/guides/nics/features/cxgbevf.ini
@@ -8,7 +8,6 @@ Speed capabilities = Y
Link status = Y
Queue start/stop = Y
MTU update = Y
-Jumbo frame = Y
Scattered Rx = Y
TSO = Y
Promiscuous mode = Y
diff --git a/doc/guides/nics/features/default.ini b/doc/guides/nics/features/default.ini
index 082c7e85db15..21178e163253 100644
--- a/doc/guides/nics/features/default.ini
+++ b/doc/guides/nics/features/default.ini
@@ -23,7 +23,6 @@ Shared Rx queue =
Burst mode info =
Power mgmt address monitor =
MTU update =
-Jumbo frame =
Scattered Rx =
LRO =
TSO =
diff --git a/doc/guides/nics/features/dpaa.ini b/doc/guides/nics/features/dpaa.ini
index e0ed3e86832b..a382c7160cbc 100644
--- a/doc/guides/nics/features/dpaa.ini
+++ b/doc/guides/nics/features/dpaa.ini
@@ -8,7 +8,6 @@ Speed capabilities = Y
Link status = Y
Link status event = Y
Burst mode info = Y
-Jumbo frame = Y
MTU update = Y
Scattered Rx = Y
Promiscuous mode = Y
diff --git a/doc/guides/nics/features/dpaa2.ini b/doc/guides/nics/features/dpaa2.ini
index 00af720cab47..4c06841a8798 100644
--- a/doc/guides/nics/features/dpaa2.ini
+++ b/doc/guides/nics/features/dpaa2.ini
@@ -9,7 +9,6 @@ Link status = Y
Link status event = Y
Burst mode info = Y
Queue start/stop = Y
-Jumbo frame = Y
Scattered Rx = Y
MTU update = Y
Promiscuous mode = Y
diff --git a/doc/guides/nics/features/e1000.ini b/doc/guides/nics/features/e1000.ini
index b33f5a86e2e9..e4bdef6da90e 100644
--- a/doc/guides/nics/features/e1000.ini
+++ b/doc/guides/nics/features/e1000.ini
@@ -10,7 +10,6 @@ Link status event = Y
Rx interrupt = Y
Free Tx mbuf on demand = Y
MTU update = Y
-Jumbo frame = Y
Scattered Rx = Y
Promiscuous mode = Y
Allmulticast mode = Y
diff --git a/doc/guides/nics/features/ena.ini b/doc/guides/nics/features/ena.ini
index b971243ff05a..4db1db11f486 100644
--- a/doc/guides/nics/features/ena.ini
+++ b/doc/guides/nics/features/ena.ini
@@ -8,7 +8,6 @@ Link status = Y
Link status event = Y
Rx interrupt = Y
MTU update = Y
-Jumbo frame = Y
Scattered Rx = Y
TSO = Y
RSS hash = Y
diff --git a/doc/guides/nics/features/enetc.ini b/doc/guides/nics/features/enetc.ini
index 2087bb973b8c..c197e280bf6c 100644
--- a/doc/guides/nics/features/enetc.ini
+++ b/doc/guides/nics/features/enetc.ini
@@ -10,7 +10,6 @@ Basic stats = Y
Promiscuous mode = Y
Allmulticast mode = Y
MTU update = Y
-Jumbo frame = Y
Queue start/stop = Y
CRC offload = Y
L3 checksum offload = P
diff --git a/doc/guides/nics/features/enic.ini b/doc/guides/nics/features/enic.ini
index ecff6c5f26f0..30643361625c 100644
--- a/doc/guides/nics/features/enic.ini
+++ b/doc/guides/nics/features/enic.ini
@@ -11,7 +11,6 @@ Rx interrupt = Y
Queue start/stop = Y
Burst mode info = Y
MTU update = Y
-Jumbo frame = Y
Scattered Rx = Y
TSO = Y
Promiscuous mode = Y
diff --git a/doc/guides/nics/features/failsafe.ini b/doc/guides/nics/features/failsafe.ini
index 8a2b92fc9cf3..00dcd0e03bc7 100644
--- a/doc/guides/nics/features/failsafe.ini
+++ b/doc/guides/nics/features/failsafe.ini
@@ -12,7 +12,6 @@ Queue start/stop = Y
Runtime Rx queue setup = Y
Runtime Tx queue setup = Y
MTU update = Y
-Jumbo frame = Y
Promiscuous mode = Y
Allmulticast mode = Y
Unicast MAC filter = Y
diff --git a/doc/guides/nics/features/fm10k.ini b/doc/guides/nics/features/fm10k.ini
index 1faa7ce59c2b..e2701d2d473f 100644
--- a/doc/guides/nics/features/fm10k.ini
+++ b/doc/guides/nics/features/fm10k.ini
@@ -9,7 +9,6 @@ Link status = Y
Link status event = Y
Rx interrupt = Y
Queue start/stop = Y
-Jumbo frame = Y
Scattered Rx = Y
TSO = Y
Promiscuous mode = Y
diff --git a/doc/guides/nics/features/fm10k_vf.ini b/doc/guides/nics/features/fm10k_vf.ini
index c5f3161a2e90..ba8bc861b1bf 100644
--- a/doc/guides/nics/features/fm10k_vf.ini
+++ b/doc/guides/nics/features/fm10k_vf.ini
@@ -9,7 +9,6 @@ Link status = Y
Link status event = Y
Rx interrupt = Y
Queue start/stop = Y
-Jumbo frame = Y
Scattered Rx = Y
TSO = Y
RSS hash = Y
diff --git a/doc/guides/nics/features/hinic.ini b/doc/guides/nics/features/hinic.ini
index 4ea736870465..9f6f0ebf3af3 100644
--- a/doc/guides/nics/features/hinic.ini
+++ b/doc/guides/nics/features/hinic.ini
@@ -9,7 +9,6 @@ Link status = Y
Link status event = Y
Queue start/stop = Y
MTU update = Y
-Jumbo frame = Y
Scattered Rx = Y
TSO = Y
LRO = Y
diff --git a/doc/guides/nics/features/hns3.ini b/doc/guides/nics/features/hns3.ini
index cf8d53d0d68f..c3464c839649 100644
--- a/doc/guides/nics/features/hns3.ini
+++ b/doc/guides/nics/features/hns3.ini
@@ -14,7 +14,6 @@ Runtime Tx queue setup = Y
Burst mode info = Y
Free Tx mbuf on demand = Y
MTU update = Y
-Jumbo frame = Y
Scattered Rx = Y
TSO = Y
LRO = Y
diff --git a/doc/guides/nics/features/hns3_vf.ini b/doc/guides/nics/features/hns3_vf.ini
index 7da994c2dc83..8ef771d04a9d 100644
--- a/doc/guides/nics/features/hns3_vf.ini
+++ b/doc/guides/nics/features/hns3_vf.ini
@@ -13,7 +13,6 @@ Runtime Tx queue setup = Y
Burst mode info = Y
Free Tx mbuf on demand = Y
MTU update = Y
-Jumbo frame = Y
Scattered Rx = Y
TSO = Y
LRO = Y
diff --git a/doc/guides/nics/features/i40e.ini b/doc/guides/nics/features/i40e.ini
index e3a575f89132..dd18fec21768 100644
--- a/doc/guides/nics/features/i40e.ini
+++ b/doc/guides/nics/features/i40e.ini
@@ -14,7 +14,6 @@ Runtime Rx queue setup = Y
Runtime Tx queue setup = Y
Burst mode info = Y
Power mgmt address monitor = Y
-Jumbo frame = Y
Scattered Rx = Y
TSO = Y
Promiscuous mode = Y
diff --git a/doc/guides/nics/features/iavf.ini b/doc/guides/nics/features/iavf.ini
index a916275b885d..dd3519e1e2ec 100644
--- a/doc/guides/nics/features/iavf.ini
+++ b/doc/guides/nics/features/iavf.ini
@@ -10,7 +10,6 @@ Rx interrupt = Y
Queue start/stop = Y
Power mgmt address monitor = Y
MTU update = Y
-Jumbo frame = Y
Scattered Rx = Y
TSO = Y
Promiscuous mode = Y
diff --git a/doc/guides/nics/features/ice.ini b/doc/guides/nics/features/ice.ini
index 8e43ade1aac9..9fd52fdd2200 100644
--- a/doc/guides/nics/features/ice.ini
+++ b/doc/guides/nics/features/ice.ini
@@ -13,7 +13,6 @@ Queue start/stop = Y
Burst mode info = Y
Power mgmt address monitor = Y
MTU update = Y
-Jumbo frame = Y
Scattered Rx = Y
TSO = Y
Promiscuous mode = Y
diff --git a/doc/guides/nics/features/ice_dcf.ini b/doc/guides/nics/features/ice_dcf.ini
index ae79b6a51529..4d6fb6d8491c 100644
--- a/doc/guides/nics/features/ice_dcf.ini
+++ b/doc/guides/nics/features/ice_dcf.ini
@@ -5,7 +5,6 @@
;
[Features]
Queue start/stop = Y
-Jumbo frame = Y
Scattered Rx = Y
RSS hash = P
CRC offload = Y
diff --git a/doc/guides/nics/features/igb.ini b/doc/guides/nics/features/igb.ini
index f4f6e9a4cb2f..7b4af6f86c21 100644
--- a/doc/guides/nics/features/igb.ini
+++ b/doc/guides/nics/features/igb.ini
@@ -9,7 +9,6 @@ Link status = Y
Link status event = Y
Rx interrupt = Y
MTU update = Y
-Jumbo frame = Y
Scattered Rx = Y
TSO = Y
Promiscuous mode = Y
diff --git a/doc/guides/nics/features/igc.ini b/doc/guides/nics/features/igc.ini
index f810c2df4e76..f2c6fa28ad8f 100644
--- a/doc/guides/nics/features/igc.ini
+++ b/doc/guides/nics/features/igc.ini
@@ -12,7 +12,6 @@ Packet type parsing = Y
Rx descriptor status = Y
Tx descriptor status = Y
MTU update = Y
-Jumbo frame = Y
Scattered Rx = Y
TSO = Y
Promiscuous mode = Y
diff --git a/doc/guides/nics/features/ionic.ini b/doc/guides/nics/features/ionic.ini
index 330c71dd208c..5bd18e39e95f 100644
--- a/doc/guides/nics/features/ionic.ini
+++ b/doc/guides/nics/features/ionic.ini
@@ -9,7 +9,6 @@ Link status = Y
Link status event = Y
Queue start/stop = Y
MTU update = Y
-Jumbo frame = Y
Scattered Rx = Y
LRO = Y
TSO = Y
diff --git a/doc/guides/nics/features/ipn3ke.ini b/doc/guides/nics/features/ipn3ke.ini
index 2bf92fd7a1e7..defc39f5250f 100644
--- a/doc/guides/nics/features/ipn3ke.ini
+++ b/doc/guides/nics/features/ipn3ke.ini
@@ -11,7 +11,6 @@ Rx interrupt = Y
Queue start/stop = Y
Runtime Rx queue setup = Y
Runtime Tx queue setup = Y
-Jumbo frame = Y
Scattered Rx = Y
TSO = Y
Promiscuous mode = Y
diff --git a/doc/guides/nics/features/ixgbe.ini b/doc/guides/nics/features/ixgbe.ini
index 73cf63866420..c5333d11426a 100644
--- a/doc/guides/nics/features/ixgbe.ini
+++ b/doc/guides/nics/features/ixgbe.ini
@@ -11,7 +11,6 @@ Rx interrupt = Y
Queue start/stop = Y
Power mgmt address monitor = Y
MTU update = Y
-Jumbo frame = Y
Scattered Rx = Y
LRO = Y
TSO = Y
diff --git a/doc/guides/nics/features/ixgbe_vf.ini b/doc/guides/nics/features/ixgbe_vf.ini
index 9241aebd2157..e14325045c7e 100644
--- a/doc/guides/nics/features/ixgbe_vf.ini
+++ b/doc/guides/nics/features/ixgbe_vf.ini
@@ -8,7 +8,6 @@ Link status = Y
Rx interrupt = Y
Power mgmt address monitor = Y
MTU update = Y
-Jumbo frame = Y
Scattered Rx = Y
LRO = Y
TSO = Y
diff --git a/doc/guides/nics/features/liquidio.ini b/doc/guides/nics/features/liquidio.ini
index 100c7213e0ec..a8bde282e03b 100644
--- a/doc/guides/nics/features/liquidio.ini
+++ b/doc/guides/nics/features/liquidio.ini
@@ -8,7 +8,6 @@ Speed capabilities = Y
Link status = Y
Link status event = Y
MTU update = Y
-Jumbo frame = Y
Scattered Rx = Y
Promiscuous mode = Y
Allmulticast mode = Y
diff --git a/doc/guides/nics/features/memif.ini b/doc/guides/nics/features/memif.ini
index 807d9ecdce08..0368b7a02c19 100644
--- a/doc/guides/nics/features/memif.ini
+++ b/doc/guides/nics/features/memif.ini
@@ -6,7 +6,6 @@
[Features]
Link status = Y
Basic stats = Y
-Jumbo frame = Y
ARMv8 = Y
Power8 = Y
x86-32 = Y
diff --git a/doc/guides/nics/features/mlx4.ini b/doc/guides/nics/features/mlx4.ini
index c394dfcefe85..82f6f0bc0bb3 100644
--- a/doc/guides/nics/features/mlx4.ini
+++ b/doc/guides/nics/features/mlx4.ini
@@ -11,7 +11,6 @@ Removal event = Y
Rx interrupt = Y
Queue start/stop = Y
MTU update = Y
-Jumbo frame = Y
Scattered Rx = Y
TSO = Y
Promiscuous mode = Y
diff --git a/doc/guides/nics/features/mlx5.ini b/doc/guides/nics/features/mlx5.ini
index 0e72021d4a06..403f58cd7e2c 100644
--- a/doc/guides/nics/features/mlx5.ini
+++ b/doc/guides/nics/features/mlx5.ini
@@ -14,7 +14,6 @@ Queue start/stop = Y
Burst mode info = Y
Power mgmt address monitor = Y
MTU update = Y
-Jumbo frame = Y
Scattered Rx = Y
LRO = Y
TSO = Y
diff --git a/doc/guides/nics/features/mvneta.ini b/doc/guides/nics/features/mvneta.ini
index 701eb03d8017..446987e1b54a 100644
--- a/doc/guides/nics/features/mvneta.ini
+++ b/doc/guides/nics/features/mvneta.ini
@@ -7,7 +7,6 @@
Speed capabilities = Y
Link status = Y
MTU update = Y
-Jumbo frame = Y
Promiscuous mode = Y
Unicast MAC filter = Y
CRC offload = Y
diff --git a/doc/guides/nics/features/mvpp2.ini b/doc/guides/nics/features/mvpp2.ini
index 2ce0ca817aea..1bcf74875e8d 100644
--- a/doc/guides/nics/features/mvpp2.ini
+++ b/doc/guides/nics/features/mvpp2.ini
@@ -7,7 +7,6 @@
Speed capabilities = Y
Link status = Y
MTU update = Y
-Jumbo frame = Y
Promiscuous mode = Y
Allmulticast mode = Y
Unicast MAC filter = Y
diff --git a/doc/guides/nics/features/nfp.ini b/doc/guides/nics/features/nfp.ini
index fee9dae87801..f7a0362eb279 100644
--- a/doc/guides/nics/features/nfp.ini
+++ b/doc/guides/nics/features/nfp.ini
@@ -10,7 +10,6 @@ Link status event = Y
Rx interrupt = Y
Queue start/stop = Y
MTU update = Y
-Jumbo frame = Y
Promiscuous mode = Y
TSO = Y
RSS hash = Y
diff --git a/doc/guides/nics/features/octeontx.ini b/doc/guides/nics/features/octeontx.ini
index d6fd61009064..78fa7c719a88 100644
--- a/doc/guides/nics/features/octeontx.ini
+++ b/doc/guides/nics/features/octeontx.ini
@@ -10,7 +10,6 @@ Link status event = Y
Lock-free Tx queue = Y
Queue start/stop = P
MTU update = Y
-Jumbo frame = Y
Scattered Rx = Y
Promiscuous mode = Y
Unicast MAC filter = Y
diff --git a/doc/guides/nics/features/octeontx2.ini b/doc/guides/nics/features/octeontx2.ini
index e0277988d4b4..bf0c2890f2e6 100644
--- a/doc/guides/nics/features/octeontx2.ini
+++ b/doc/guides/nics/features/octeontx2.ini
@@ -31,7 +31,6 @@ Inline protocol = Y
VLAN filter = Y
Flow control = Y
Rate limitation = Y
-Jumbo frame = Y
Scattered Rx = Y
VLAN offload = Y
QinQ offload = Y
diff --git a/doc/guides/nics/features/octeontx2_vec.ini b/doc/guides/nics/features/octeontx2_vec.ini
index 376a1d6cc1ad..c405db7cf91a 100644
--- a/doc/guides/nics/features/octeontx2_vec.ini
+++ b/doc/guides/nics/features/octeontx2_vec.ini
@@ -28,7 +28,6 @@ Inner RSS = Y
VLAN filter = Y
Flow control = Y
Rate limitation = Y
-Jumbo frame = Y
VLAN offload = Y
QinQ offload = Y
L3 checksum offload = Y
diff --git a/doc/guides/nics/features/octeontx2_vf.ini b/doc/guides/nics/features/octeontx2_vf.ini
index 8141aadf8509..5ac7a49a5c7e 100644
--- a/doc/guides/nics/features/octeontx2_vf.ini
+++ b/doc/guides/nics/features/octeontx2_vf.ini
@@ -24,7 +24,6 @@ Inner RSS = Y
Inline protocol = Y
VLAN filter = Y
Rate limitation = Y
-Jumbo frame = Y
Scattered Rx = Y
VLAN offload = Y
QinQ offload = Y
diff --git a/doc/guides/nics/features/pcap.ini b/doc/guides/nics/features/pcap.ini
index 28e648807413..7fd22b190e79 100644
--- a/doc/guides/nics/features/pcap.ini
+++ b/doc/guides/nics/features/pcap.ini
@@ -4,7 +4,6 @@
; Refer to default.ini for the full list of available PMD features.
;
[Features]
-Jumbo frame = Y
Basic stats = Y
Multiprocess aware = Y
ARMv7 = Y
diff --git a/doc/guides/nics/features/qede.ini b/doc/guides/nics/features/qede.ini
index e65d5d076ed9..e6fe2d4aeb83 100644
--- a/doc/guides/nics/features/qede.ini
+++ b/doc/guides/nics/features/qede.ini
@@ -7,7 +7,6 @@
Speed capabilities = Y
Link status = Y
MTU update = Y
-Jumbo frame = Y
Scattered Rx = Y
LRO = Y
TSO = Y
diff --git a/doc/guides/nics/features/qede_vf.ini b/doc/guides/nics/features/qede_vf.ini
index e71a3e5ac462..6cf146341ff6 100644
--- a/doc/guides/nics/features/qede_vf.ini
+++ b/doc/guides/nics/features/qede_vf.ini
@@ -7,7 +7,6 @@
Speed capabilities = Y
Link status = Y
MTU update = Y
-Jumbo frame = Y
Scattered Rx = Y
Promiscuous mode = Y
Allmulticast mode = Y
diff --git a/doc/guides/nics/features/sfc.ini b/doc/guides/nics/features/sfc.ini
index c5fadeceb123..7db868e59fa6 100644
--- a/doc/guides/nics/features/sfc.ini
+++ b/doc/guides/nics/features/sfc.ini
@@ -13,7 +13,6 @@ Queue start/stop = Y
Runtime Rx queue setup = Y
Runtime Tx queue setup = Y
MTU update = Y
-Jumbo frame = Y
Scattered Rx = Y
TSO = Y
Promiscuous mode = Y
diff --git a/doc/guides/nics/features/thunderx.ini b/doc/guides/nics/features/thunderx.ini
index add542817445..b33bb37c829b 100644
--- a/doc/guides/nics/features/thunderx.ini
+++ b/doc/guides/nics/features/thunderx.ini
@@ -9,7 +9,6 @@ Link status = Y
Link status event = Y
Queue start/stop = Y
MTU update = Y
-Jumbo frame = Y
Scattered Rx = Y
Promiscuous mode = Y
Allmulticast mode = Y
diff --git a/doc/guides/nics/features/txgbe.ini b/doc/guides/nics/features/txgbe.ini
index 61cb3f6d9fd1..6d0cc8afddb7 100644
--- a/doc/guides/nics/features/txgbe.ini
+++ b/doc/guides/nics/features/txgbe.ini
@@ -10,7 +10,6 @@ Link status event = Y
Rx interrupt = Y
Queue start/stop = Y
MTU update = Y
-Jumbo frame = Y
Scattered Rx = Y
LRO = Y
TSO = Y
diff --git a/doc/guides/nics/features/txgbe_vf.ini b/doc/guides/nics/features/txgbe_vf.ini
index 349990cb00be..d071717f094b 100644
--- a/doc/guides/nics/features/txgbe_vf.ini
+++ b/doc/guides/nics/features/txgbe_vf.ini
@@ -9,7 +9,6 @@ Unicast MAC filter = Y
Multicast MAC filter = Y
Rx interrupt = Y
MTU update = Y
-Jumbo frame = Y
Scattered Rx = Y
LRO = Y
TSO = Y
diff --git a/doc/guides/nics/features/vmxnet3.ini b/doc/guides/nics/features/vmxnet3.ini
index c74d7d59634b..971695fc4ad5 100644
--- a/doc/guides/nics/features/vmxnet3.ini
+++ b/doc/guides/nics/features/vmxnet3.ini
@@ -9,7 +9,6 @@ Link status = Y
Link status event = Y
Queue start/stop = Y
MTU update = Y
-Jumbo frame = Y
LRO = Y
TSO = Y
Promiscuous mode = Y
diff --git a/drivers/net/e1000/igb_rxtx.c b/drivers/net/e1000/igb_rxtx.c
index a1d5eecc14a1..5ee65a563dd6 100644
--- a/drivers/net/e1000/igb_rxtx.c
+++ b/drivers/net/e1000/igb_rxtx.c
@@ -2331,7 +2331,7 @@ eth_igb_rx_init(struct rte_eth_dev *dev)
* Configure support of jumbo frames, if any.
*/
max_len = dev->data->mtu + E1000_ETH_OVERHEAD;
- if ((dev->data->mtu & RTE_ETHER_MTU) != 0) {
+ if (dev->data->mtu > RTE_ETHER_MTU) {
rctl |= E1000_RCTL_LPE;
/*
diff --git a/drivers/net/i40e/i40e_rxtx.c b/drivers/net/i40e/i40e_rxtx.c
index 554b1142c136..fd066e8b236e 100644
--- a/drivers/net/i40e/i40e_rxtx.c
+++ b/drivers/net/i40e/i40e_rxtx.c
@@ -2901,26 +2901,13 @@ i40e_rx_queue_config(struct i40e_rx_queue *rxq)
rxq->max_pkt_len =
RTE_MIN(hw->func_caps.rx_buf_chain_len * rxq->rx_buf_len,
data->mtu + I40E_ETH_OVERHEAD);
- if (data->mtu > RTE_ETHER_MTU) {
- if (rxq->max_pkt_len <= I40E_ETH_MAX_LEN ||
- rxq->max_pkt_len > I40E_FRAME_SIZE_MAX) {
- PMD_DRV_LOG(ERR, "maximum packet length must "
- "be larger than %u and smaller than %u,"
- "as jumbo frame is enabled",
- (uint32_t)I40E_ETH_MAX_LEN,
- (uint32_t)I40E_FRAME_SIZE_MAX);
- return I40E_ERR_CONFIG;
- }
- } else {
- if (rxq->max_pkt_len < RTE_ETHER_MIN_LEN ||
- rxq->max_pkt_len > I40E_ETH_MAX_LEN) {
- PMD_DRV_LOG(ERR, "maximum packet length must be "
- "larger than %u and smaller than %u, "
- "as jumbo frame is disabled",
- (uint32_t)RTE_ETHER_MIN_LEN,
- (uint32_t)I40E_ETH_MAX_LEN);
- return I40E_ERR_CONFIG;
- }
+ if (rxq->max_pkt_len < RTE_ETHER_MIN_LEN ||
+ rxq->max_pkt_len > I40E_FRAME_SIZE_MAX) {
+ PMD_DRV_LOG(ERR, "maximum packet length must be "
+ "larger than %u and smaller than %u",
+ (uint32_t)RTE_ETHER_MIN_LEN,
+ (uint32_t)I40E_FRAME_SIZE_MAX);
+ return I40E_ERR_CONFIG;
}
return 0;
diff --git a/drivers/net/iavf/iavf_ethdev.c b/drivers/net/iavf/iavf_ethdev.c
index 611f1f7722b0..74fc3c647710 100644
--- a/drivers/net/iavf/iavf_ethdev.c
+++ b/drivers/net/iavf/iavf_ethdev.c
@@ -585,29 +585,14 @@ iavf_init_rxq(struct rte_eth_dev *dev, struct iavf_rx_queue *rxq)
rxq->rx_buf_len * IAVF_MAX_CHAINED_RX_BUFFERS,
frame_size);
- /* Check if the jumbo frame and maximum packet length are set
- * correctly.
- */
- if (dev->data->mtu & RTE_ETHER_MTU) {
- if (max_pkt_len <= IAVF_ETH_MAX_LEN ||
- max_pkt_len > IAVF_FRAME_SIZE_MAX) {
- PMD_DRV_LOG(ERR, "maximum packet length must be "
- "larger than %u and smaller than %u, "
- "as jumbo frame is enabled",
- (uint32_t)IAVF_ETH_MAX_LEN,
- (uint32_t)IAVF_FRAME_SIZE_MAX);
- return -EINVAL;
- }
- } else {
- if (max_pkt_len < RTE_ETHER_MIN_LEN ||
- max_pkt_len > IAVF_ETH_MAX_LEN) {
- PMD_DRV_LOG(ERR, "maximum packet length must be "
- "larger than %u and smaller than %u, "
- "as jumbo frame is disabled",
- (uint32_t)RTE_ETHER_MIN_LEN,
- (uint32_t)IAVF_ETH_MAX_LEN);
- return -EINVAL;
- }
+ /* Check if maximum packet length is set correctly. */
+ if (max_pkt_len <= RTE_ETHER_MIN_LEN ||
+ max_pkt_len > IAVF_FRAME_SIZE_MAX) {
+ PMD_DRV_LOG(ERR, "maximum packet length must be "
+ "larger than %u and smaller than %u",
+ (uint32_t)IAVF_ETH_MAX_LEN,
+ (uint32_t)IAVF_FRAME_SIZE_MAX);
+ return -EINVAL;
}
rxq->max_pkt_len = max_pkt_len;
diff --git a/drivers/net/ice/ice_dcf_ethdev.c b/drivers/net/ice/ice_dcf_ethdev.c
index ebd8ca57ef5f..a5904a7777ab 100644
--- a/drivers/net/ice/ice_dcf_ethdev.c
+++ b/drivers/net/ice/ice_dcf_ethdev.c
@@ -69,29 +69,14 @@ ice_dcf_init_rxq(struct rte_eth_dev *dev, struct ice_rx_queue *rxq)
max_pkt_len = RTE_MIN(ICE_SUPPORT_CHAIN_NUM * rxq->rx_buf_len,
dev->data->mtu + ICE_ETH_OVERHEAD);
- /* Check if the jumbo frame and maximum packet length are set
- * correctly.
- */
- if (dev_data->mtu > RTE_ETHER_MTU) {
- if (max_pkt_len <= ICE_ETH_MAX_LEN ||
- max_pkt_len > ICE_FRAME_SIZE_MAX) {
- PMD_DRV_LOG(ERR, "maximum packet length must be "
- "larger than %u and smaller than %u, "
- "as jumbo frame is enabled",
- (uint32_t)ICE_ETH_MAX_LEN,
- (uint32_t)ICE_FRAME_SIZE_MAX);
- return -EINVAL;
- }
- } else {
- if (max_pkt_len < RTE_ETHER_MIN_LEN ||
- max_pkt_len > ICE_ETH_MAX_LEN) {
- PMD_DRV_LOG(ERR, "maximum packet length must be "
- "larger than %u and smaller than %u, "
- "as jumbo frame is disabled",
- (uint32_t)RTE_ETHER_MIN_LEN,
- (uint32_t)ICE_ETH_MAX_LEN);
- return -EINVAL;
- }
+ /* Check maximum packet length is set correctly. */
+ if (max_pkt_len <= RTE_ETHER_MIN_LEN ||
+ max_pkt_len > ICE_FRAME_SIZE_MAX) {
+ PMD_DRV_LOG(ERR, "maximum packet length must be "
+ "larger than %u and smaller than %u",
+ (uint32_t)RTE_ETHER_MIN_LEN,
+ (uint32_t)ICE_FRAME_SIZE_MAX);
+ return -EINVAL;
}
rxq->max_pkt_len = max_pkt_len;
diff --git a/drivers/net/ice/ice_rxtx.c b/drivers/net/ice/ice_rxtx.c
index ff362c21d9f5..32f3a9342c20 100644
--- a/drivers/net/ice/ice_rxtx.c
+++ b/drivers/net/ice/ice_rxtx.c
@@ -281,26 +281,13 @@ ice_program_hw_rx_queue(struct ice_rx_queue *rxq)
RTE_MIN((uint32_t)ICE_SUPPORT_CHAIN_NUM * rxq->rx_buf_len,
frame_size);
- if (dev_data->mtu > RTE_ETHER_MTU) {
- if (rxq->max_pkt_len <= ICE_ETH_MAX_LEN ||
- rxq->max_pkt_len > ICE_FRAME_SIZE_MAX) {
- PMD_DRV_LOG(ERR, "maximum packet length must "
- "be larger than %u and smaller than %u,"
- "as jumbo frame is enabled",
- (uint32_t)ICE_ETH_MAX_LEN,
- (uint32_t)ICE_FRAME_SIZE_MAX);
- return -EINVAL;
- }
- } else {
- if (rxq->max_pkt_len < RTE_ETHER_MIN_LEN ||
- rxq->max_pkt_len > ICE_ETH_MAX_LEN) {
- PMD_DRV_LOG(ERR, "maximum packet length must be "
- "larger than %u and smaller than %u, "
- "as jumbo frame is disabled",
- (uint32_t)RTE_ETHER_MIN_LEN,
- (uint32_t)ICE_ETH_MAX_LEN);
- return -EINVAL;
- }
+ if (rxq->max_pkt_len <= RTE_ETHER_MIN_LEN ||
+ rxq->max_pkt_len > ICE_FRAME_SIZE_MAX) {
+ PMD_DRV_LOG(ERR, "maximum packet length must "
+ "be larger than %u and smaller than %u",
+ (uint32_t)RTE_ETHER_MIN_LEN,
+ (uint32_t)ICE_FRAME_SIZE_MAX);
+ return -EINVAL;
}
if (rxq->offloads & DEV_RX_OFFLOAD_TIMESTAMP) {
diff --git a/drivers/net/igc/igc_txrx.c b/drivers/net/igc/igc_txrx.c
index 56132e8c6cd6..4887e922e700 100644
--- a/drivers/net/igc/igc_txrx.c
+++ b/drivers/net/igc/igc_txrx.c
@@ -1080,7 +1080,7 @@ igc_rx_init(struct rte_eth_dev *dev)
IGC_WRITE_REG(hw, IGC_RCTL, rctl & ~IGC_RCTL_EN);
/* Configure support of jumbo frames, if any. */
- if (dev->data->mtu & RTE_ETHER_MTU)
+ if (dev->data->mtu > RTE_ETHER_MTU)
rctl |= IGC_RCTL_LPE;
else
rctl &= ~IGC_RCTL_LPE;
diff --git a/drivers/net/ixgbe/ixgbe_rxtx.c b/drivers/net/ixgbe/ixgbe_rxtx.c
index a51450fe5b82..ab4a261ca8f9 100644
--- a/drivers/net/ixgbe/ixgbe_rxtx.c
+++ b/drivers/net/ixgbe/ixgbe_rxtx.c
@@ -5078,7 +5078,7 @@ ixgbe_dev_rx_init(struct rte_eth_dev *dev)
/*
* Configure jumbo frame support, if any.
*/
- if ((dev->data->mtu & RTE_ETHER_MTU) != 0) {
+ if (dev->data->mtu > RTE_ETHER_MTU) {
hlreg0 |= IXGBE_HLREG0_JUMBOEN;
maxfrs = IXGBE_READ_REG(hw, IXGBE_MAXFRS);
maxfrs &= 0x0000FFFF;
--
2.31.1
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [dpdk-dev] [PATCH] ethdev: fix removing jumbo offload flag
2021-10-22 12:17 [dpdk-dev] [PATCH] ethdev: fix removing jumbo offload flag Ferruh Yigit
@ 2021-10-22 12:23 ` Andrew Rybchenko
2021-10-22 12:27 ` Ferruh Yigit
2021-10-22 12:57 ` [dpdk-dev] [PATCH v2 1/2] doc: remove jumbo offload feature Ferruh Yigit
1 sibling, 1 reply; 9+ messages in thread
From: Andrew Rybchenko @ 2021-10-22 12:23 UTC (permalink / raw)
To: Ferruh Yigit, Shepard Siegel, Ed Czeck, John Miller,
Igor Russkikh, Steven Webster, Matt Peters, Chandubabu Namburu,
Ajit Khaparde, Somnath Kotur, Nithin Dabilpuram, Kiran Kumar K,
Sunil Kumar Kori, Satha Rao, Rahul Lakkireddy, Hemant Agrawal,
Sachin Saxena, Haiyue Wang, Marcin Wojtas, Michal Krawczyk,
Shai Brandes, Evgeny Schemeilin, Igor Chauskin, Gagandeep Singh,
John Daley, Hyong Youb Kim, Gaetan Rivet, Qi Zhang, Xiao Wang,
Ziyang Xuan, Xiaoyun Wang, Guoyang Zhou, Min Hu (Connor),
Yisen Zhuang, Lijun Ou, Beilei Xing, Jingjing Wu, Qiming Yang,
Andrew Boyer, Rosen Xu, Shijith Thotton,
Srisivasubramanian Srinivasan, Jakub Grajciar, Matan Azrad,
Viacheslav Ovsiienko, Zyta Szpak, Liron Himi, Heinrich Kuhn,
Harman Kalra, Jerin Jacob, Rasesh Mody, Devendra Singh Rawat,
Maciej Czekaj, Jiawen Wu, Jian Wang, Yong Wang,
Konstantin Ananyev
Cc: dev
On 10/22/21 3:17 PM, Ferruh Yigit wrote:
> After DEV_RX_OFFLOAD_JUMBO_FRAME flag removed, jumbo frame decision is
> given by MTU value checks, but some of the checks were wrong by mistake,
> causing device initialization to fail, fixing them.
>
> Also removing 'Jumbo frame' feature.
Sorry, but I think is is better to split offload removal and
Intel driver fixes.
>
> Fixes: b563c1421282 ("ethdev: remove jumbo offload flag")
>
> Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
for offload removal
Acked-by: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
> ---
> Some of the check mistakes are residue of local changes, I remember
> fixing them, but it looks like something went wrong while sending
> patches.
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [dpdk-dev] [PATCH] ethdev: fix removing jumbo offload flag
2021-10-22 12:23 ` Andrew Rybchenko
@ 2021-10-22 12:27 ` Ferruh Yigit
0 siblings, 0 replies; 9+ messages in thread
From: Ferruh Yigit @ 2021-10-22 12:27 UTC (permalink / raw)
To: Andrew Rybchenko, Shepard Siegel, Ed Czeck, John Miller,
Igor Russkikh, Steven Webster, Matt Peters, Chandubabu Namburu,
Ajit Khaparde, Somnath Kotur, Nithin Dabilpuram, Kiran Kumar K,
Sunil Kumar Kori, Satha Rao, Rahul Lakkireddy, Hemant Agrawal,
Sachin Saxena, Haiyue Wang, Marcin Wojtas, Michal Krawczyk,
Shai Brandes, Evgeny Schemeilin, Igor Chauskin, Gagandeep Singh,
John Daley, Hyong Youb Kim, Gaetan Rivet, Qi Zhang, Xiao Wang,
Ziyang Xuan, Xiaoyun Wang, Guoyang Zhou, Min Hu (Connor),
Yisen Zhuang, Lijun Ou, Beilei Xing, Jingjing Wu, Qiming Yang,
Andrew Boyer, Rosen Xu, Shijith Thotton,
Srisivasubramanian Srinivasan, Jakub Grajciar, Matan Azrad,
Viacheslav Ovsiienko, Zyta Szpak, Liron Himi, Heinrich Kuhn,
Harman Kalra, Jerin Jacob, Rasesh Mody, Devendra Singh Rawat,
Maciej Czekaj, Jiawen Wu, Jian Wang, Yong Wang,
Konstantin Ananyev
Cc: dev
On 10/22/2021 1:23 PM, Andrew Rybchenko wrote:
> On 10/22/21 3:17 PM, Ferruh Yigit wrote:
>> After DEV_RX_OFFLOAD_JUMBO_FRAME flag removed, jumbo frame decision is
>> given by MTU value checks, but some of the checks were wrong by mistake,
>> causing device initialization to fail, fixing them.
>>
>> Also removing 'Jumbo frame' feature.
>
> Sorry, but I think is is better to split offload removal and
> Intel driver fixes.
>
Sure, I will send next version as separate patches.
>>
>> Fixes: b563c1421282 ("ethdev: remove jumbo offload flag")
>>
>> Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
>
> for offload removal
>
> Acked-by: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
>
>> ---
>> Some of the check mistakes are residue of local changes, I remember
>> fixing them, but it looks like something went wrong while sending
>> patches.
^ permalink raw reply [flat|nested] 9+ messages in thread
* [dpdk-dev] [PATCH v2 1/2] doc: remove jumbo offload feature
2021-10-22 12:17 [dpdk-dev] [PATCH] ethdev: fix removing jumbo offload flag Ferruh Yigit
2021-10-22 12:23 ` Andrew Rybchenko
@ 2021-10-22 12:57 ` Ferruh Yigit
2021-10-22 12:57 ` [dpdk-dev] [PATCH v2 2/2] drivers/net: fix removing jumbo offload flag Ferruh Yigit
2021-10-22 15:55 ` [dpdk-dev] [PATCH v2 1/2] doc: remove jumbo offload feature Ajit Khaparde
1 sibling, 2 replies; 9+ messages in thread
From: Ferruh Yigit @ 2021-10-22 12:57 UTC (permalink / raw)
To: Shepard Siegel, Ed Czeck, John Miller, Igor Russkikh,
Steven Webster, Matt Peters, Chandubabu Namburu, Ajit Khaparde,
Somnath Kotur, Nithin Dabilpuram, Kiran Kumar K,
Sunil Kumar Kori, Satha Rao, Rahul Lakkireddy, Hemant Agrawal,
Sachin Saxena, Haiyue Wang, Marcin Wojtas, Michal Krawczyk,
Shai Brandes, Evgeny Schemeilin, Igor Chauskin, Gagandeep Singh,
John Daley, Hyong Youb Kim, Gaetan Rivet, Qi Zhang, Xiao Wang,
Ziyang Xuan, Xiaoyun Wang, Guoyang Zhou, Min Hu (Connor),
Yisen Zhuang, Lijun Ou, Beilei Xing, Jingjing Wu, Qiming Yang,
Andrew Boyer, Rosen Xu, Shijith Thotton,
Srisivasubramanian Srinivasan, Jakub Grajciar, Matan Azrad,
Viacheslav Ovsiienko, Zyta Szpak, Liron Himi, Heinrich Kuhn,
Harman Kalra, Jerin Jacob, Rasesh Mody, Devendra Singh Rawat,
Andrew Rybchenko, Maciej Czekaj, Jiawen Wu, Jian Wang, Yong Wang
Cc: Ferruh Yigit, dev
Jumbo offload is no more announced as capability, and
'DEV_RX_OFFLOAD_JUMBO_FRAME' offload flag is removed.
This patch is also removing 'Jumbo frame' feature from documentation.
Fixes: b563c1421282 ("ethdev: remove jumbo offload flag")
Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
Acked-by: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
---
doc/guides/nics/features.rst | 12 ------------
doc/guides/nics/features/ark.ini | 1 -
doc/guides/nics/features/atlantic.ini | 1 -
doc/guides/nics/features/avp.ini | 1 -
doc/guides/nics/features/axgbe.ini | 1 -
doc/guides/nics/features/bnxt.ini | 1 -
doc/guides/nics/features/cnxk.ini | 1 -
doc/guides/nics/features/cnxk_vec.ini | 1 -
doc/guides/nics/features/cnxk_vf.ini | 1 -
doc/guides/nics/features/cxgbe.ini | 1 -
doc/guides/nics/features/cxgbevf.ini | 1 -
doc/guides/nics/features/default.ini | 1 -
doc/guides/nics/features/dpaa.ini | 1 -
doc/guides/nics/features/dpaa2.ini | 1 -
doc/guides/nics/features/e1000.ini | 1 -
doc/guides/nics/features/ena.ini | 1 -
doc/guides/nics/features/enetc.ini | 1 -
doc/guides/nics/features/enic.ini | 1 -
doc/guides/nics/features/failsafe.ini | 1 -
doc/guides/nics/features/fm10k.ini | 1 -
doc/guides/nics/features/fm10k_vf.ini | 1 -
doc/guides/nics/features/hinic.ini | 1 -
doc/guides/nics/features/hns3.ini | 1 -
doc/guides/nics/features/hns3_vf.ini | 1 -
doc/guides/nics/features/i40e.ini | 1 -
doc/guides/nics/features/iavf.ini | 1 -
doc/guides/nics/features/ice.ini | 1 -
doc/guides/nics/features/ice_dcf.ini | 1 -
doc/guides/nics/features/igb.ini | 1 -
doc/guides/nics/features/igc.ini | 1 -
doc/guides/nics/features/ionic.ini | 1 -
doc/guides/nics/features/ipn3ke.ini | 1 -
doc/guides/nics/features/ixgbe.ini | 1 -
doc/guides/nics/features/ixgbe_vf.ini | 1 -
doc/guides/nics/features/liquidio.ini | 1 -
doc/guides/nics/features/memif.ini | 1 -
doc/guides/nics/features/mlx4.ini | 1 -
doc/guides/nics/features/mlx5.ini | 1 -
doc/guides/nics/features/mvneta.ini | 1 -
doc/guides/nics/features/mvpp2.ini | 1 -
doc/guides/nics/features/nfp.ini | 1 -
doc/guides/nics/features/octeontx.ini | 1 -
doc/guides/nics/features/octeontx2.ini | 1 -
doc/guides/nics/features/octeontx2_vec.ini | 1 -
doc/guides/nics/features/octeontx2_vf.ini | 1 -
doc/guides/nics/features/pcap.ini | 1 -
doc/guides/nics/features/qede.ini | 1 -
doc/guides/nics/features/qede_vf.ini | 1 -
doc/guides/nics/features/sfc.ini | 1 -
doc/guides/nics/features/thunderx.ini | 1 -
doc/guides/nics/features/txgbe.ini | 1 -
doc/guides/nics/features/txgbe_vf.ini | 1 -
doc/guides/nics/features/vmxnet3.ini | 1 -
53 files changed, 64 deletions(-)
diff --git a/doc/guides/nics/features.rst b/doc/guides/nics/features.rst
index d35751d5b5a7..676df5a5e3c8 100644
--- a/doc/guides/nics/features.rst
+++ b/doc/guides/nics/features.rst
@@ -158,18 +158,6 @@ Supports updating port MTU.
* **[related] API**: ``rte_eth_dev_set_mtu()``, ``rte_eth_dev_get_mtu()``.
-.. _nic_features_jumbo_frame:
-
-Jumbo frame
------------
-
-Supports Rx jumbo frames.
-
-* **[uses] rte_eth_rxconf,rte_eth_rxmode**: ``dev_conf.rxmode.mtu``.
-* **[related] rte_eth_dev_info**: ``max_rx_pktlen``.
-* **[related] API**: ``rte_eth_dev_set_mtu()``.
-
-
.. _nic_features_scattered_rx:
Scattered Rx
diff --git a/doc/guides/nics/features/ark.ini b/doc/guides/nics/features/ark.ini
index 5519984e3926..87b4209165d7 100644
--- a/doc/guides/nics/features/ark.ini
+++ b/doc/guides/nics/features/ark.ini
@@ -6,7 +6,6 @@
[Features]
Speed capabilities = Y
Queue start/stop = Y
-Jumbo frame = Y
Scattered Rx = Y
Basic stats = Y
Stats per queue = Y
diff --git a/doc/guides/nics/features/atlantic.ini b/doc/guides/nics/features/atlantic.ini
index d2ec33b21742..ef4155027c72 100644
--- a/doc/guides/nics/features/atlantic.ini
+++ b/doc/guides/nics/features/atlantic.ini
@@ -9,7 +9,6 @@ Link status = Y
Link status event = Y
Queue start/stop = Y
MTU update = Y
-Jumbo frame = Y
Promiscuous mode = Y
Allmulticast mode = Y
Unicast MAC filter = Y
diff --git a/doc/guides/nics/features/avp.ini b/doc/guides/nics/features/avp.ini
index 9352c989feaa..f2f115ba61e8 100644
--- a/doc/guides/nics/features/avp.ini
+++ b/doc/guides/nics/features/avp.ini
@@ -5,7 +5,6 @@
;
[Features]
Link status = Y
-Jumbo frame = Y
Scattered Rx = Y
Promiscuous mode = Y
Unicast MAC filter = Y
diff --git a/doc/guides/nics/features/axgbe.ini b/doc/guides/nics/features/axgbe.ini
index e11f440d7350..821bb682d433 100644
--- a/doc/guides/nics/features/axgbe.ini
+++ b/doc/guides/nics/features/axgbe.ini
@@ -6,7 +6,6 @@
[Features]
Speed capabilities = Y
Link status = Y
-Jumbo frame = Y
Scattered Rx = Y
Promiscuous mode = Y
Allmulticast mode = Y
diff --git a/doc/guides/nics/features/bnxt.ini b/doc/guides/nics/features/bnxt.ini
index c0e8ecb82be5..93aa98aedef9 100644
--- a/doc/guides/nics/features/bnxt.ini
+++ b/doc/guides/nics/features/bnxt.ini
@@ -12,7 +12,6 @@ Fast mbuf free = Y
Queue start/stop = Y
Burst mode info = Y
MTU update = Y
-Jumbo frame = Y
Scattered Rx = Y
LRO = Y
TSO = Y
diff --git a/doc/guides/nics/features/cnxk.ini b/doc/guides/nics/features/cnxk.ini
index 03af0da30297..1623a1803e7c 100644
--- a/doc/guides/nics/features/cnxk.ini
+++ b/doc/guides/nics/features/cnxk.ini
@@ -29,7 +29,6 @@ RSS reta update = Y
Inner RSS = Y
Inline protocol = Y
Flow control = Y
-Jumbo frame = Y
Scattered Rx = Y
L3 checksum offload = Y
L4 checksum offload = Y
diff --git a/doc/guides/nics/features/cnxk_vec.ini b/doc/guides/nics/features/cnxk_vec.ini
index 12ca0a587ca7..4b7c2bce4dd6 100644
--- a/doc/guides/nics/features/cnxk_vec.ini
+++ b/doc/guides/nics/features/cnxk_vec.ini
@@ -28,7 +28,6 @@ RSS reta update = Y
Inner RSS = Y
Inline protocol = Y
Flow control = Y
-Jumbo frame = Y
L3 checksum offload = Y
L4 checksum offload = Y
Inner L3 checksum = Y
diff --git a/doc/guides/nics/features/cnxk_vf.ini b/doc/guides/nics/features/cnxk_vf.ini
index f3d9f23f1749..0523be434d2b 100644
--- a/doc/guides/nics/features/cnxk_vf.ini
+++ b/doc/guides/nics/features/cnxk_vf.ini
@@ -23,7 +23,6 @@ RSS key update = Y
RSS reta update = Y
Inner RSS = Y
Inline protocol = Y
-Jumbo frame = Y
Scattered Rx = Y
L3 checksum offload = Y
L4 checksum offload = Y
diff --git a/doc/guides/nics/features/cxgbe.ini b/doc/guides/nics/features/cxgbe.ini
index f41fc1482527..f674803ec47f 100644
--- a/doc/guides/nics/features/cxgbe.ini
+++ b/doc/guides/nics/features/cxgbe.ini
@@ -8,7 +8,6 @@ Speed capabilities = Y
Link status = Y
Queue start/stop = Y
MTU update = Y
-Jumbo frame = Y
Scattered Rx = Y
TSO = Y
Promiscuous mode = Y
diff --git a/doc/guides/nics/features/cxgbevf.ini b/doc/guides/nics/features/cxgbevf.ini
index a3174ef39955..a34fddd64e33 100644
--- a/doc/guides/nics/features/cxgbevf.ini
+++ b/doc/guides/nics/features/cxgbevf.ini
@@ -8,7 +8,6 @@ Speed capabilities = Y
Link status = Y
Queue start/stop = Y
MTU update = Y
-Jumbo frame = Y
Scattered Rx = Y
TSO = Y
Promiscuous mode = Y
diff --git a/doc/guides/nics/features/default.ini b/doc/guides/nics/features/default.ini
index 082c7e85db15..21178e163253 100644
--- a/doc/guides/nics/features/default.ini
+++ b/doc/guides/nics/features/default.ini
@@ -23,7 +23,6 @@ Shared Rx queue =
Burst mode info =
Power mgmt address monitor =
MTU update =
-Jumbo frame =
Scattered Rx =
LRO =
TSO =
diff --git a/doc/guides/nics/features/dpaa.ini b/doc/guides/nics/features/dpaa.ini
index e0ed3e86832b..a382c7160cbc 100644
--- a/doc/guides/nics/features/dpaa.ini
+++ b/doc/guides/nics/features/dpaa.ini
@@ -8,7 +8,6 @@ Speed capabilities = Y
Link status = Y
Link status event = Y
Burst mode info = Y
-Jumbo frame = Y
MTU update = Y
Scattered Rx = Y
Promiscuous mode = Y
diff --git a/doc/guides/nics/features/dpaa2.ini b/doc/guides/nics/features/dpaa2.ini
index 00af720cab47..4c06841a8798 100644
--- a/doc/guides/nics/features/dpaa2.ini
+++ b/doc/guides/nics/features/dpaa2.ini
@@ -9,7 +9,6 @@ Link status = Y
Link status event = Y
Burst mode info = Y
Queue start/stop = Y
-Jumbo frame = Y
Scattered Rx = Y
MTU update = Y
Promiscuous mode = Y
diff --git a/doc/guides/nics/features/e1000.ini b/doc/guides/nics/features/e1000.ini
index b33f5a86e2e9..e4bdef6da90e 100644
--- a/doc/guides/nics/features/e1000.ini
+++ b/doc/guides/nics/features/e1000.ini
@@ -10,7 +10,6 @@ Link status event = Y
Rx interrupt = Y
Free Tx mbuf on demand = Y
MTU update = Y
-Jumbo frame = Y
Scattered Rx = Y
Promiscuous mode = Y
Allmulticast mode = Y
diff --git a/doc/guides/nics/features/ena.ini b/doc/guides/nics/features/ena.ini
index b971243ff05a..4db1db11f486 100644
--- a/doc/guides/nics/features/ena.ini
+++ b/doc/guides/nics/features/ena.ini
@@ -8,7 +8,6 @@ Link status = Y
Link status event = Y
Rx interrupt = Y
MTU update = Y
-Jumbo frame = Y
Scattered Rx = Y
TSO = Y
RSS hash = Y
diff --git a/doc/guides/nics/features/enetc.ini b/doc/guides/nics/features/enetc.ini
index 2087bb973b8c..c197e280bf6c 100644
--- a/doc/guides/nics/features/enetc.ini
+++ b/doc/guides/nics/features/enetc.ini
@@ -10,7 +10,6 @@ Basic stats = Y
Promiscuous mode = Y
Allmulticast mode = Y
MTU update = Y
-Jumbo frame = Y
Queue start/stop = Y
CRC offload = Y
L3 checksum offload = P
diff --git a/doc/guides/nics/features/enic.ini b/doc/guides/nics/features/enic.ini
index ecff6c5f26f0..30643361625c 100644
--- a/doc/guides/nics/features/enic.ini
+++ b/doc/guides/nics/features/enic.ini
@@ -11,7 +11,6 @@ Rx interrupt = Y
Queue start/stop = Y
Burst mode info = Y
MTU update = Y
-Jumbo frame = Y
Scattered Rx = Y
TSO = Y
Promiscuous mode = Y
diff --git a/doc/guides/nics/features/failsafe.ini b/doc/guides/nics/features/failsafe.ini
index 8a2b92fc9cf3..00dcd0e03bc7 100644
--- a/doc/guides/nics/features/failsafe.ini
+++ b/doc/guides/nics/features/failsafe.ini
@@ -12,7 +12,6 @@ Queue start/stop = Y
Runtime Rx queue setup = Y
Runtime Tx queue setup = Y
MTU update = Y
-Jumbo frame = Y
Promiscuous mode = Y
Allmulticast mode = Y
Unicast MAC filter = Y
diff --git a/doc/guides/nics/features/fm10k.ini b/doc/guides/nics/features/fm10k.ini
index 1faa7ce59c2b..e2701d2d473f 100644
--- a/doc/guides/nics/features/fm10k.ini
+++ b/doc/guides/nics/features/fm10k.ini
@@ -9,7 +9,6 @@ Link status = Y
Link status event = Y
Rx interrupt = Y
Queue start/stop = Y
-Jumbo frame = Y
Scattered Rx = Y
TSO = Y
Promiscuous mode = Y
diff --git a/doc/guides/nics/features/fm10k_vf.ini b/doc/guides/nics/features/fm10k_vf.ini
index c5f3161a2e90..ba8bc861b1bf 100644
--- a/doc/guides/nics/features/fm10k_vf.ini
+++ b/doc/guides/nics/features/fm10k_vf.ini
@@ -9,7 +9,6 @@ Link status = Y
Link status event = Y
Rx interrupt = Y
Queue start/stop = Y
-Jumbo frame = Y
Scattered Rx = Y
TSO = Y
RSS hash = Y
diff --git a/doc/guides/nics/features/hinic.ini b/doc/guides/nics/features/hinic.ini
index 4ea736870465..9f6f0ebf3af3 100644
--- a/doc/guides/nics/features/hinic.ini
+++ b/doc/guides/nics/features/hinic.ini
@@ -9,7 +9,6 @@ Link status = Y
Link status event = Y
Queue start/stop = Y
MTU update = Y
-Jumbo frame = Y
Scattered Rx = Y
TSO = Y
LRO = Y
diff --git a/doc/guides/nics/features/hns3.ini b/doc/guides/nics/features/hns3.ini
index cf8d53d0d68f..c3464c839649 100644
--- a/doc/guides/nics/features/hns3.ini
+++ b/doc/guides/nics/features/hns3.ini
@@ -14,7 +14,6 @@ Runtime Tx queue setup = Y
Burst mode info = Y
Free Tx mbuf on demand = Y
MTU update = Y
-Jumbo frame = Y
Scattered Rx = Y
TSO = Y
LRO = Y
diff --git a/doc/guides/nics/features/hns3_vf.ini b/doc/guides/nics/features/hns3_vf.ini
index 7da994c2dc83..8ef771d04a9d 100644
--- a/doc/guides/nics/features/hns3_vf.ini
+++ b/doc/guides/nics/features/hns3_vf.ini
@@ -13,7 +13,6 @@ Runtime Tx queue setup = Y
Burst mode info = Y
Free Tx mbuf on demand = Y
MTU update = Y
-Jumbo frame = Y
Scattered Rx = Y
TSO = Y
LRO = Y
diff --git a/doc/guides/nics/features/i40e.ini b/doc/guides/nics/features/i40e.ini
index e3a575f89132..dd18fec21768 100644
--- a/doc/guides/nics/features/i40e.ini
+++ b/doc/guides/nics/features/i40e.ini
@@ -14,7 +14,6 @@ Runtime Rx queue setup = Y
Runtime Tx queue setup = Y
Burst mode info = Y
Power mgmt address monitor = Y
-Jumbo frame = Y
Scattered Rx = Y
TSO = Y
Promiscuous mode = Y
diff --git a/doc/guides/nics/features/iavf.ini b/doc/guides/nics/features/iavf.ini
index a916275b885d..dd3519e1e2ec 100644
--- a/doc/guides/nics/features/iavf.ini
+++ b/doc/guides/nics/features/iavf.ini
@@ -10,7 +10,6 @@ Rx interrupt = Y
Queue start/stop = Y
Power mgmt address monitor = Y
MTU update = Y
-Jumbo frame = Y
Scattered Rx = Y
TSO = Y
Promiscuous mode = Y
diff --git a/doc/guides/nics/features/ice.ini b/doc/guides/nics/features/ice.ini
index 8e43ade1aac9..9fd52fdd2200 100644
--- a/doc/guides/nics/features/ice.ini
+++ b/doc/guides/nics/features/ice.ini
@@ -13,7 +13,6 @@ Queue start/stop = Y
Burst mode info = Y
Power mgmt address monitor = Y
MTU update = Y
-Jumbo frame = Y
Scattered Rx = Y
TSO = Y
Promiscuous mode = Y
diff --git a/doc/guides/nics/features/ice_dcf.ini b/doc/guides/nics/features/ice_dcf.ini
index ae79b6a51529..4d6fb6d8491c 100644
--- a/doc/guides/nics/features/ice_dcf.ini
+++ b/doc/guides/nics/features/ice_dcf.ini
@@ -5,7 +5,6 @@
;
[Features]
Queue start/stop = Y
-Jumbo frame = Y
Scattered Rx = Y
RSS hash = P
CRC offload = Y
diff --git a/doc/guides/nics/features/igb.ini b/doc/guides/nics/features/igb.ini
index f4f6e9a4cb2f..7b4af6f86c21 100644
--- a/doc/guides/nics/features/igb.ini
+++ b/doc/guides/nics/features/igb.ini
@@ -9,7 +9,6 @@ Link status = Y
Link status event = Y
Rx interrupt = Y
MTU update = Y
-Jumbo frame = Y
Scattered Rx = Y
TSO = Y
Promiscuous mode = Y
diff --git a/doc/guides/nics/features/igc.ini b/doc/guides/nics/features/igc.ini
index f810c2df4e76..f2c6fa28ad8f 100644
--- a/doc/guides/nics/features/igc.ini
+++ b/doc/guides/nics/features/igc.ini
@@ -12,7 +12,6 @@ Packet type parsing = Y
Rx descriptor status = Y
Tx descriptor status = Y
MTU update = Y
-Jumbo frame = Y
Scattered Rx = Y
TSO = Y
Promiscuous mode = Y
diff --git a/doc/guides/nics/features/ionic.ini b/doc/guides/nics/features/ionic.ini
index 330c71dd208c..5bd18e39e95f 100644
--- a/doc/guides/nics/features/ionic.ini
+++ b/doc/guides/nics/features/ionic.ini
@@ -9,7 +9,6 @@ Link status = Y
Link status event = Y
Queue start/stop = Y
MTU update = Y
-Jumbo frame = Y
Scattered Rx = Y
LRO = Y
TSO = Y
diff --git a/doc/guides/nics/features/ipn3ke.ini b/doc/guides/nics/features/ipn3ke.ini
index 2bf92fd7a1e7..defc39f5250f 100644
--- a/doc/guides/nics/features/ipn3ke.ini
+++ b/doc/guides/nics/features/ipn3ke.ini
@@ -11,7 +11,6 @@ Rx interrupt = Y
Queue start/stop = Y
Runtime Rx queue setup = Y
Runtime Tx queue setup = Y
-Jumbo frame = Y
Scattered Rx = Y
TSO = Y
Promiscuous mode = Y
diff --git a/doc/guides/nics/features/ixgbe.ini b/doc/guides/nics/features/ixgbe.ini
index 73cf63866420..c5333d11426a 100644
--- a/doc/guides/nics/features/ixgbe.ini
+++ b/doc/guides/nics/features/ixgbe.ini
@@ -11,7 +11,6 @@ Rx interrupt = Y
Queue start/stop = Y
Power mgmt address monitor = Y
MTU update = Y
-Jumbo frame = Y
Scattered Rx = Y
LRO = Y
TSO = Y
diff --git a/doc/guides/nics/features/ixgbe_vf.ini b/doc/guides/nics/features/ixgbe_vf.ini
index 9241aebd2157..e14325045c7e 100644
--- a/doc/guides/nics/features/ixgbe_vf.ini
+++ b/doc/guides/nics/features/ixgbe_vf.ini
@@ -8,7 +8,6 @@ Link status = Y
Rx interrupt = Y
Power mgmt address monitor = Y
MTU update = Y
-Jumbo frame = Y
Scattered Rx = Y
LRO = Y
TSO = Y
diff --git a/doc/guides/nics/features/liquidio.ini b/doc/guides/nics/features/liquidio.ini
index 100c7213e0ec..a8bde282e03b 100644
--- a/doc/guides/nics/features/liquidio.ini
+++ b/doc/guides/nics/features/liquidio.ini
@@ -8,7 +8,6 @@ Speed capabilities = Y
Link status = Y
Link status event = Y
MTU update = Y
-Jumbo frame = Y
Scattered Rx = Y
Promiscuous mode = Y
Allmulticast mode = Y
diff --git a/doc/guides/nics/features/memif.ini b/doc/guides/nics/features/memif.ini
index 807d9ecdce08..0368b7a02c19 100644
--- a/doc/guides/nics/features/memif.ini
+++ b/doc/guides/nics/features/memif.ini
@@ -6,7 +6,6 @@
[Features]
Link status = Y
Basic stats = Y
-Jumbo frame = Y
ARMv8 = Y
Power8 = Y
x86-32 = Y
diff --git a/doc/guides/nics/features/mlx4.ini b/doc/guides/nics/features/mlx4.ini
index c394dfcefe85..82f6f0bc0bb3 100644
--- a/doc/guides/nics/features/mlx4.ini
+++ b/doc/guides/nics/features/mlx4.ini
@@ -11,7 +11,6 @@ Removal event = Y
Rx interrupt = Y
Queue start/stop = Y
MTU update = Y
-Jumbo frame = Y
Scattered Rx = Y
TSO = Y
Promiscuous mode = Y
diff --git a/doc/guides/nics/features/mlx5.ini b/doc/guides/nics/features/mlx5.ini
index 0e72021d4a06..403f58cd7e2c 100644
--- a/doc/guides/nics/features/mlx5.ini
+++ b/doc/guides/nics/features/mlx5.ini
@@ -14,7 +14,6 @@ Queue start/stop = Y
Burst mode info = Y
Power mgmt address monitor = Y
MTU update = Y
-Jumbo frame = Y
Scattered Rx = Y
LRO = Y
TSO = Y
diff --git a/doc/guides/nics/features/mvneta.ini b/doc/guides/nics/features/mvneta.ini
index 701eb03d8017..446987e1b54a 100644
--- a/doc/guides/nics/features/mvneta.ini
+++ b/doc/guides/nics/features/mvneta.ini
@@ -7,7 +7,6 @@
Speed capabilities = Y
Link status = Y
MTU update = Y
-Jumbo frame = Y
Promiscuous mode = Y
Unicast MAC filter = Y
CRC offload = Y
diff --git a/doc/guides/nics/features/mvpp2.ini b/doc/guides/nics/features/mvpp2.ini
index 2ce0ca817aea..1bcf74875e8d 100644
--- a/doc/guides/nics/features/mvpp2.ini
+++ b/doc/guides/nics/features/mvpp2.ini
@@ -7,7 +7,6 @@
Speed capabilities = Y
Link status = Y
MTU update = Y
-Jumbo frame = Y
Promiscuous mode = Y
Allmulticast mode = Y
Unicast MAC filter = Y
diff --git a/doc/guides/nics/features/nfp.ini b/doc/guides/nics/features/nfp.ini
index fee9dae87801..f7a0362eb279 100644
--- a/doc/guides/nics/features/nfp.ini
+++ b/doc/guides/nics/features/nfp.ini
@@ -10,7 +10,6 @@ Link status event = Y
Rx interrupt = Y
Queue start/stop = Y
MTU update = Y
-Jumbo frame = Y
Promiscuous mode = Y
TSO = Y
RSS hash = Y
diff --git a/doc/guides/nics/features/octeontx.ini b/doc/guides/nics/features/octeontx.ini
index d6fd61009064..78fa7c719a88 100644
--- a/doc/guides/nics/features/octeontx.ini
+++ b/doc/guides/nics/features/octeontx.ini
@@ -10,7 +10,6 @@ Link status event = Y
Lock-free Tx queue = Y
Queue start/stop = P
MTU update = Y
-Jumbo frame = Y
Scattered Rx = Y
Promiscuous mode = Y
Unicast MAC filter = Y
diff --git a/doc/guides/nics/features/octeontx2.ini b/doc/guides/nics/features/octeontx2.ini
index e0277988d4b4..bf0c2890f2e6 100644
--- a/doc/guides/nics/features/octeontx2.ini
+++ b/doc/guides/nics/features/octeontx2.ini
@@ -31,7 +31,6 @@ Inline protocol = Y
VLAN filter = Y
Flow control = Y
Rate limitation = Y
-Jumbo frame = Y
Scattered Rx = Y
VLAN offload = Y
QinQ offload = Y
diff --git a/doc/guides/nics/features/octeontx2_vec.ini b/doc/guides/nics/features/octeontx2_vec.ini
index 376a1d6cc1ad..c405db7cf91a 100644
--- a/doc/guides/nics/features/octeontx2_vec.ini
+++ b/doc/guides/nics/features/octeontx2_vec.ini
@@ -28,7 +28,6 @@ Inner RSS = Y
VLAN filter = Y
Flow control = Y
Rate limitation = Y
-Jumbo frame = Y
VLAN offload = Y
QinQ offload = Y
L3 checksum offload = Y
diff --git a/doc/guides/nics/features/octeontx2_vf.ini b/doc/guides/nics/features/octeontx2_vf.ini
index 8141aadf8509..5ac7a49a5c7e 100644
--- a/doc/guides/nics/features/octeontx2_vf.ini
+++ b/doc/guides/nics/features/octeontx2_vf.ini
@@ -24,7 +24,6 @@ Inner RSS = Y
Inline protocol = Y
VLAN filter = Y
Rate limitation = Y
-Jumbo frame = Y
Scattered Rx = Y
VLAN offload = Y
QinQ offload = Y
diff --git a/doc/guides/nics/features/pcap.ini b/doc/guides/nics/features/pcap.ini
index 28e648807413..7fd22b190e79 100644
--- a/doc/guides/nics/features/pcap.ini
+++ b/doc/guides/nics/features/pcap.ini
@@ -4,7 +4,6 @@
; Refer to default.ini for the full list of available PMD features.
;
[Features]
-Jumbo frame = Y
Basic stats = Y
Multiprocess aware = Y
ARMv7 = Y
diff --git a/doc/guides/nics/features/qede.ini b/doc/guides/nics/features/qede.ini
index e65d5d076ed9..e6fe2d4aeb83 100644
--- a/doc/guides/nics/features/qede.ini
+++ b/doc/guides/nics/features/qede.ini
@@ -7,7 +7,6 @@
Speed capabilities = Y
Link status = Y
MTU update = Y
-Jumbo frame = Y
Scattered Rx = Y
LRO = Y
TSO = Y
diff --git a/doc/guides/nics/features/qede_vf.ini b/doc/guides/nics/features/qede_vf.ini
index e71a3e5ac462..6cf146341ff6 100644
--- a/doc/guides/nics/features/qede_vf.ini
+++ b/doc/guides/nics/features/qede_vf.ini
@@ -7,7 +7,6 @@
Speed capabilities = Y
Link status = Y
MTU update = Y
-Jumbo frame = Y
Scattered Rx = Y
Promiscuous mode = Y
Allmulticast mode = Y
diff --git a/doc/guides/nics/features/sfc.ini b/doc/guides/nics/features/sfc.ini
index c5fadeceb123..7db868e59fa6 100644
--- a/doc/guides/nics/features/sfc.ini
+++ b/doc/guides/nics/features/sfc.ini
@@ -13,7 +13,6 @@ Queue start/stop = Y
Runtime Rx queue setup = Y
Runtime Tx queue setup = Y
MTU update = Y
-Jumbo frame = Y
Scattered Rx = Y
TSO = Y
Promiscuous mode = Y
diff --git a/doc/guides/nics/features/thunderx.ini b/doc/guides/nics/features/thunderx.ini
index add542817445..b33bb37c829b 100644
--- a/doc/guides/nics/features/thunderx.ini
+++ b/doc/guides/nics/features/thunderx.ini
@@ -9,7 +9,6 @@ Link status = Y
Link status event = Y
Queue start/stop = Y
MTU update = Y
-Jumbo frame = Y
Scattered Rx = Y
Promiscuous mode = Y
Allmulticast mode = Y
diff --git a/doc/guides/nics/features/txgbe.ini b/doc/guides/nics/features/txgbe.ini
index 61cb3f6d9fd1..6d0cc8afddb7 100644
--- a/doc/guides/nics/features/txgbe.ini
+++ b/doc/guides/nics/features/txgbe.ini
@@ -10,7 +10,6 @@ Link status event = Y
Rx interrupt = Y
Queue start/stop = Y
MTU update = Y
-Jumbo frame = Y
Scattered Rx = Y
LRO = Y
TSO = Y
diff --git a/doc/guides/nics/features/txgbe_vf.ini b/doc/guides/nics/features/txgbe_vf.ini
index 349990cb00be..d071717f094b 100644
--- a/doc/guides/nics/features/txgbe_vf.ini
+++ b/doc/guides/nics/features/txgbe_vf.ini
@@ -9,7 +9,6 @@ Unicast MAC filter = Y
Multicast MAC filter = Y
Rx interrupt = Y
MTU update = Y
-Jumbo frame = Y
Scattered Rx = Y
LRO = Y
TSO = Y
diff --git a/doc/guides/nics/features/vmxnet3.ini b/doc/guides/nics/features/vmxnet3.ini
index c74d7d59634b..971695fc4ad5 100644
--- a/doc/guides/nics/features/vmxnet3.ini
+++ b/doc/guides/nics/features/vmxnet3.ini
@@ -9,7 +9,6 @@ Link status = Y
Link status event = Y
Queue start/stop = Y
MTU update = Y
-Jumbo frame = Y
LRO = Y
TSO = Y
Promiscuous mode = Y
--
2.31.1
^ permalink raw reply [flat|nested] 9+ messages in thread
* [dpdk-dev] [PATCH v2 2/2] drivers/net: fix removing jumbo offload flag
2021-10-22 12:57 ` [dpdk-dev] [PATCH v2 1/2] doc: remove jumbo offload feature Ferruh Yigit
@ 2021-10-22 12:57 ` Ferruh Yigit
2021-10-22 14:10 ` Jiang, YuX
2021-10-22 15:55 ` [dpdk-dev] [PATCH v2 1/2] doc: remove jumbo offload feature Ajit Khaparde
1 sibling, 1 reply; 9+ messages in thread
From: Ferruh Yigit @ 2021-10-22 12:57 UTC (permalink / raw)
To: Haiyue Wang, Beilei Xing, Jingjing Wu, Qiming Yang, Qi Zhang,
Hyong Youb Kim, Michal Krawczyk, Andrew Rybchenko, Somnath Kotur
Cc: Ferruh Yigit, dev
After DEV_RX_OFFLOAD_JUMBO_FRAME flag removed, drivers give jumbo frame
decisions based on MTU value checks, but some of the checks were wrong
by mistake, causing device initialization to fail, fixing them.
Fixes: b563c1421282 ("ethdev: remove jumbo offload flag")
Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
---
Some of the check mistakes are residue of local changes, I remember
fixing them, but it looks like something went wrong while sending
patches.
v2:
* Split doc changes
---
drivers/net/e1000/igb_rxtx.c | 2 +-
drivers/net/i40e/i40e_rxtx.c | 27 +++++++--------------------
drivers/net/iavf/iavf_ethdev.c | 31 ++++++++-----------------------
drivers/net/ice/ice_dcf_ethdev.c | 31 ++++++++-----------------------
drivers/net/ice/ice_rxtx.c | 27 +++++++--------------------
drivers/net/igc/igc_txrx.c | 2 +-
drivers/net/ixgbe/ixgbe_rxtx.c | 2 +-
7 files changed, 33 insertions(+), 89 deletions(-)
diff --git a/drivers/net/e1000/igb_rxtx.c b/drivers/net/e1000/igb_rxtx.c
index a1d5eecc14a1..5ee65a563dd6 100644
--- a/drivers/net/e1000/igb_rxtx.c
+++ b/drivers/net/e1000/igb_rxtx.c
@@ -2331,7 +2331,7 @@ eth_igb_rx_init(struct rte_eth_dev *dev)
* Configure support of jumbo frames, if any.
*/
max_len = dev->data->mtu + E1000_ETH_OVERHEAD;
- if ((dev->data->mtu & RTE_ETHER_MTU) != 0) {
+ if (dev->data->mtu > RTE_ETHER_MTU) {
rctl |= E1000_RCTL_LPE;
/*
diff --git a/drivers/net/i40e/i40e_rxtx.c b/drivers/net/i40e/i40e_rxtx.c
index 554b1142c136..fd066e8b236e 100644
--- a/drivers/net/i40e/i40e_rxtx.c
+++ b/drivers/net/i40e/i40e_rxtx.c
@@ -2901,26 +2901,13 @@ i40e_rx_queue_config(struct i40e_rx_queue *rxq)
rxq->max_pkt_len =
RTE_MIN(hw->func_caps.rx_buf_chain_len * rxq->rx_buf_len,
data->mtu + I40E_ETH_OVERHEAD);
- if (data->mtu > RTE_ETHER_MTU) {
- if (rxq->max_pkt_len <= I40E_ETH_MAX_LEN ||
- rxq->max_pkt_len > I40E_FRAME_SIZE_MAX) {
- PMD_DRV_LOG(ERR, "maximum packet length must "
- "be larger than %u and smaller than %u,"
- "as jumbo frame is enabled",
- (uint32_t)I40E_ETH_MAX_LEN,
- (uint32_t)I40E_FRAME_SIZE_MAX);
- return I40E_ERR_CONFIG;
- }
- } else {
- if (rxq->max_pkt_len < RTE_ETHER_MIN_LEN ||
- rxq->max_pkt_len > I40E_ETH_MAX_LEN) {
- PMD_DRV_LOG(ERR, "maximum packet length must be "
- "larger than %u and smaller than %u, "
- "as jumbo frame is disabled",
- (uint32_t)RTE_ETHER_MIN_LEN,
- (uint32_t)I40E_ETH_MAX_LEN);
- return I40E_ERR_CONFIG;
- }
+ if (rxq->max_pkt_len < RTE_ETHER_MIN_LEN ||
+ rxq->max_pkt_len > I40E_FRAME_SIZE_MAX) {
+ PMD_DRV_LOG(ERR, "maximum packet length must be "
+ "larger than %u and smaller than %u",
+ (uint32_t)RTE_ETHER_MIN_LEN,
+ (uint32_t)I40E_FRAME_SIZE_MAX);
+ return I40E_ERR_CONFIG;
}
return 0;
diff --git a/drivers/net/iavf/iavf_ethdev.c b/drivers/net/iavf/iavf_ethdev.c
index 611f1f7722b0..74fc3c647710 100644
--- a/drivers/net/iavf/iavf_ethdev.c
+++ b/drivers/net/iavf/iavf_ethdev.c
@@ -585,29 +585,14 @@ iavf_init_rxq(struct rte_eth_dev *dev, struct iavf_rx_queue *rxq)
rxq->rx_buf_len * IAVF_MAX_CHAINED_RX_BUFFERS,
frame_size);
- /* Check if the jumbo frame and maximum packet length are set
- * correctly.
- */
- if (dev->data->mtu & RTE_ETHER_MTU) {
- if (max_pkt_len <= IAVF_ETH_MAX_LEN ||
- max_pkt_len > IAVF_FRAME_SIZE_MAX) {
- PMD_DRV_LOG(ERR, "maximum packet length must be "
- "larger than %u and smaller than %u, "
- "as jumbo frame is enabled",
- (uint32_t)IAVF_ETH_MAX_LEN,
- (uint32_t)IAVF_FRAME_SIZE_MAX);
- return -EINVAL;
- }
- } else {
- if (max_pkt_len < RTE_ETHER_MIN_LEN ||
- max_pkt_len > IAVF_ETH_MAX_LEN) {
- PMD_DRV_LOG(ERR, "maximum packet length must be "
- "larger than %u and smaller than %u, "
- "as jumbo frame is disabled",
- (uint32_t)RTE_ETHER_MIN_LEN,
- (uint32_t)IAVF_ETH_MAX_LEN);
- return -EINVAL;
- }
+ /* Check if maximum packet length is set correctly. */
+ if (max_pkt_len <= RTE_ETHER_MIN_LEN ||
+ max_pkt_len > IAVF_FRAME_SIZE_MAX) {
+ PMD_DRV_LOG(ERR, "maximum packet length must be "
+ "larger than %u and smaller than %u",
+ (uint32_t)IAVF_ETH_MAX_LEN,
+ (uint32_t)IAVF_FRAME_SIZE_MAX);
+ return -EINVAL;
}
rxq->max_pkt_len = max_pkt_len;
diff --git a/drivers/net/ice/ice_dcf_ethdev.c b/drivers/net/ice/ice_dcf_ethdev.c
index ebd8ca57ef5f..a5904a7777ab 100644
--- a/drivers/net/ice/ice_dcf_ethdev.c
+++ b/drivers/net/ice/ice_dcf_ethdev.c
@@ -69,29 +69,14 @@ ice_dcf_init_rxq(struct rte_eth_dev *dev, struct ice_rx_queue *rxq)
max_pkt_len = RTE_MIN(ICE_SUPPORT_CHAIN_NUM * rxq->rx_buf_len,
dev->data->mtu + ICE_ETH_OVERHEAD);
- /* Check if the jumbo frame and maximum packet length are set
- * correctly.
- */
- if (dev_data->mtu > RTE_ETHER_MTU) {
- if (max_pkt_len <= ICE_ETH_MAX_LEN ||
- max_pkt_len > ICE_FRAME_SIZE_MAX) {
- PMD_DRV_LOG(ERR, "maximum packet length must be "
- "larger than %u and smaller than %u, "
- "as jumbo frame is enabled",
- (uint32_t)ICE_ETH_MAX_LEN,
- (uint32_t)ICE_FRAME_SIZE_MAX);
- return -EINVAL;
- }
- } else {
- if (max_pkt_len < RTE_ETHER_MIN_LEN ||
- max_pkt_len > ICE_ETH_MAX_LEN) {
- PMD_DRV_LOG(ERR, "maximum packet length must be "
- "larger than %u and smaller than %u, "
- "as jumbo frame is disabled",
- (uint32_t)RTE_ETHER_MIN_LEN,
- (uint32_t)ICE_ETH_MAX_LEN);
- return -EINVAL;
- }
+ /* Check maximum packet length is set correctly. */
+ if (max_pkt_len <= RTE_ETHER_MIN_LEN ||
+ max_pkt_len > ICE_FRAME_SIZE_MAX) {
+ PMD_DRV_LOG(ERR, "maximum packet length must be "
+ "larger than %u and smaller than %u",
+ (uint32_t)RTE_ETHER_MIN_LEN,
+ (uint32_t)ICE_FRAME_SIZE_MAX);
+ return -EINVAL;
}
rxq->max_pkt_len = max_pkt_len;
diff --git a/drivers/net/ice/ice_rxtx.c b/drivers/net/ice/ice_rxtx.c
index ff362c21d9f5..32f3a9342c20 100644
--- a/drivers/net/ice/ice_rxtx.c
+++ b/drivers/net/ice/ice_rxtx.c
@@ -281,26 +281,13 @@ ice_program_hw_rx_queue(struct ice_rx_queue *rxq)
RTE_MIN((uint32_t)ICE_SUPPORT_CHAIN_NUM * rxq->rx_buf_len,
frame_size);
- if (dev_data->mtu > RTE_ETHER_MTU) {
- if (rxq->max_pkt_len <= ICE_ETH_MAX_LEN ||
- rxq->max_pkt_len > ICE_FRAME_SIZE_MAX) {
- PMD_DRV_LOG(ERR, "maximum packet length must "
- "be larger than %u and smaller than %u,"
- "as jumbo frame is enabled",
- (uint32_t)ICE_ETH_MAX_LEN,
- (uint32_t)ICE_FRAME_SIZE_MAX);
- return -EINVAL;
- }
- } else {
- if (rxq->max_pkt_len < RTE_ETHER_MIN_LEN ||
- rxq->max_pkt_len > ICE_ETH_MAX_LEN) {
- PMD_DRV_LOG(ERR, "maximum packet length must be "
- "larger than %u and smaller than %u, "
- "as jumbo frame is disabled",
- (uint32_t)RTE_ETHER_MIN_LEN,
- (uint32_t)ICE_ETH_MAX_LEN);
- return -EINVAL;
- }
+ if (rxq->max_pkt_len <= RTE_ETHER_MIN_LEN ||
+ rxq->max_pkt_len > ICE_FRAME_SIZE_MAX) {
+ PMD_DRV_LOG(ERR, "maximum packet length must "
+ "be larger than %u and smaller than %u",
+ (uint32_t)RTE_ETHER_MIN_LEN,
+ (uint32_t)ICE_FRAME_SIZE_MAX);
+ return -EINVAL;
}
if (rxq->offloads & DEV_RX_OFFLOAD_TIMESTAMP) {
diff --git a/drivers/net/igc/igc_txrx.c b/drivers/net/igc/igc_txrx.c
index 56132e8c6cd6..4887e922e700 100644
--- a/drivers/net/igc/igc_txrx.c
+++ b/drivers/net/igc/igc_txrx.c
@@ -1080,7 +1080,7 @@ igc_rx_init(struct rte_eth_dev *dev)
IGC_WRITE_REG(hw, IGC_RCTL, rctl & ~IGC_RCTL_EN);
/* Configure support of jumbo frames, if any. */
- if (dev->data->mtu & RTE_ETHER_MTU)
+ if (dev->data->mtu > RTE_ETHER_MTU)
rctl |= IGC_RCTL_LPE;
else
rctl &= ~IGC_RCTL_LPE;
diff --git a/drivers/net/ixgbe/ixgbe_rxtx.c b/drivers/net/ixgbe/ixgbe_rxtx.c
index a51450fe5b82..ab4a261ca8f9 100644
--- a/drivers/net/ixgbe/ixgbe_rxtx.c
+++ b/drivers/net/ixgbe/ixgbe_rxtx.c
@@ -5078,7 +5078,7 @@ ixgbe_dev_rx_init(struct rte_eth_dev *dev)
/*
* Configure jumbo frame support, if any.
*/
- if ((dev->data->mtu & RTE_ETHER_MTU) != 0) {
+ if (dev->data->mtu > RTE_ETHER_MTU) {
hlreg0 |= IXGBE_HLREG0_JUMBOEN;
maxfrs = IXGBE_READ_REG(hw, IXGBE_MAXFRS);
maxfrs &= 0x0000FFFF;
--
2.31.1
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [dpdk-dev] [PATCH v2 2/2] drivers/net: fix removing jumbo offload flag
2021-10-22 12:57 ` [dpdk-dev] [PATCH v2 2/2] drivers/net: fix removing jumbo offload flag Ferruh Yigit
@ 2021-10-22 14:10 ` Jiang, YuX
2021-10-22 15:20 ` Ferruh Yigit
0 siblings, 1 reply; 9+ messages in thread
From: Jiang, YuX @ 2021-10-22 14:10 UTC (permalink / raw)
To: Yigit, Ferruh, Wang, Haiyue, Xing, Beilei, Wu, Jingjing, Yang,
Qiming, Zhang, Qi Z, Hyong Youb Kim, Michal Krawczyk,
Andrew Rybchenko, Somnath Kotur
Cc: Yigit, Ferruh, dev
> -----Original Message-----
> From: dev <dev-bounces@dpdk.org> On Behalf Of Ferruh Yigit
> Sent: 2021年10月22日 20:57
> To: Wang, Haiyue <haiyue.wang@intel.com>; Xing, Beilei
> <beilei.xing@intel.com>; Wu, Jingjing <jingjing.wu@intel.com>; Yang, Qiming
> <qiming.yang@intel.com>; Zhang, Qi Z <qi.z.zhang@intel.com>; Hyong Youb
> Kim <hyonkim@cisco.com>; Michal Krawczyk <mk@semihalf.com>; Andrew
> Rybchenko <andrew.rybchenko@oktetlabs.ru>; Somnath Kotur
> <somnath.kotur@broadcom.com>
> Cc: Yigit, Ferruh <ferruh.yigit@intel.com>; dev@dpdk.org
> Subject: [dpdk-dev] [PATCH v2 2/2] drivers/net: fix removing jumbo offload
> flag
>
> After DEV_RX_OFFLOAD_JUMBO_FRAME flag removed, drivers give jumbo
> frame decisions based on MTU value checks, but some of the checks were
> wrong by mistake, causing device initialization to fail, fixing them.
>
> Fixes: b563c1421282 ("ethdev: remove jumbo offload flag")
>
> Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
Tested-by: Yu Jiang <YuX.Jiang@intel.com>
Verify patchset v2 https://patches.dpdk.org/project/dpdk/patch/20211022125716.2706937-2-ferruh.yigit@intel.com/ on dpdk main branch(f4acb429d0 (HEAD, origin/main) hash: promote some functions to stable)
Tested on i40e(iavf) and it looks good, will test more on others.
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [dpdk-dev] [PATCH v2 2/2] drivers/net: fix removing jumbo offload flag
2021-10-22 14:10 ` Jiang, YuX
@ 2021-10-22 15:20 ` Ferruh Yigit
2021-10-22 15:46 ` Ferruh Yigit
0 siblings, 1 reply; 9+ messages in thread
From: Ferruh Yigit @ 2021-10-22 15:20 UTC (permalink / raw)
To: Jiang, YuX, Wang, Haiyue, Xing, Beilei, Wu, Jingjing, Yang,
Qiming, Zhang, Qi Z, Hyong Youb Kim, Michal Krawczyk,
Andrew Rybchenko, Somnath Kotur
Cc: dev, Thomas Monjalon, David Marchand
On 10/22/2021 3:10 PM, Jiang, YuX wrote:
>> -----Original Message-----
>> From: dev <dev-bounces@dpdk.org> On Behalf Of Ferruh Yigit
>> Sent: 2021年10月22日 20:57
>> To: Wang, Haiyue <haiyue.wang@intel.com>; Xing, Beilei
>> <beilei.xing@intel.com>; Wu, Jingjing <jingjing.wu@intel.com>; Yang, Qiming
>> <qiming.yang@intel.com>; Zhang, Qi Z <qi.z.zhang@intel.com>; Hyong Youb
>> Kim <hyonkim@cisco.com>; Michal Krawczyk <mk@semihalf.com>; Andrew
>> Rybchenko <andrew.rybchenko@oktetlabs.ru>; Somnath Kotur
>> <somnath.kotur@broadcom.com>
>> Cc: Yigit, Ferruh <ferruh.yigit@intel.com>; dev@dpdk.org
>> Subject: [dpdk-dev] [PATCH v2 2/2] drivers/net: fix removing jumbo offload
>> flag
>>
>> After DEV_RX_OFFLOAD_JUMBO_FRAME flag removed, drivers give jumbo
>> frame decisions based on MTU value checks, but some of the checks were
>> wrong by mistake, causing device initialization to fail, fixing them.
>>
>> Fixes: b563c1421282 ("ethdev: remove jumbo offload flag")
>>
>> Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
>
> Tested-by: Yu Jiang <YuX.Jiang@intel.com>
> Verify patchset v2 https://patches.dpdk.org/project/dpdk/patch/20211022125716.2706937-2-ferruh.yigit@intel.com/ on dpdk main branch(f4acb429d0 (HEAD, origin/main) hash: promote some functions to stable)
> Tested on i40e(iavf) and it looks good, will test more on others.
>
Thanks Yu,
I can see it is not fully validated, and most likely it won't be
before -rc1, but it would be good to have this fix for -rc1 to not
block testing.
Since the previous code is clearly wrong, and fixes are similar
between drivers, if one is good I will take risk and merge
the fix for -rc1.
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [dpdk-dev] [PATCH v2 2/2] drivers/net: fix removing jumbo offload flag
2021-10-22 15:20 ` Ferruh Yigit
@ 2021-10-22 15:46 ` Ferruh Yigit
0 siblings, 0 replies; 9+ messages in thread
From: Ferruh Yigit @ 2021-10-22 15:46 UTC (permalink / raw)
To: Jiang, YuX, Wang, Haiyue, Xing, Beilei, Wu, Jingjing, Yang,
Qiming, Zhang, Qi Z, Hyong Youb Kim, Michal Krawczyk,
Andrew Rybchenko, Somnath Kotur
Cc: dev, Thomas Monjalon, David Marchand
On 10/22/2021 4:20 PM, Ferruh Yigit wrote:
> On 10/22/2021 3:10 PM, Jiang, YuX wrote:
>>> -----Original Message-----
>>> From: dev <dev-bounces@dpdk.org> On Behalf Of Ferruh Yigit
>>> Sent: 2021年10月22日 20:57
>>> To: Wang, Haiyue <haiyue.wang@intel.com>; Xing, Beilei
>>> <beilei.xing@intel.com>; Wu, Jingjing <jingjing.wu@intel.com>; Yang, Qiming
>>> <qiming.yang@intel.com>; Zhang, Qi Z <qi.z.zhang@intel.com>; Hyong Youb
>>> Kim <hyonkim@cisco.com>; Michal Krawczyk <mk@semihalf.com>; Andrew
>>> Rybchenko <andrew.rybchenko@oktetlabs.ru>; Somnath Kotur
>>> <somnath.kotur@broadcom.com>
>>> Cc: Yigit, Ferruh <ferruh.yigit@intel.com>; dev@dpdk.org
>>> Subject: [dpdk-dev] [PATCH v2 2/2] drivers/net: fix removing jumbo offload
>>> flag
>>>
>>> After DEV_RX_OFFLOAD_JUMBO_FRAME flag removed, drivers give jumbo
>>> frame decisions based on MTU value checks, but some of the checks were
>>> wrong by mistake, causing device initialization to fail, fixing them.
>>>
>>> Fixes: b563c1421282 ("ethdev: remove jumbo offload flag")
>>>
>>> Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
>>
>> Tested-by: Yu Jiang <YuX.Jiang@intel.com>
>> Verify patchset v2 https://patches.dpdk.org/project/dpdk/patch/20211022125716.2706937-2-ferruh.yigit@intel.com/ on dpdk main branch(f4acb429d0 (HEAD, origin/main) hash: promote some functions to stable)
>> Tested on i40e(iavf) and it looks good, will test more on others.
>>
>
> Thanks Yu,
>
> I can see it is not fully validated, and most likely it won't be
> before -rc1, but it would be good to have this fix for -rc1 to not
> block testing.
> Since the previous code is clearly wrong, and fixes are similar
> between drivers, if one is good I will take risk and merge
> the fix for -rc1.
Series applied to dpdk-next-net/main, thanks.
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [dpdk-dev] [PATCH v2 1/2] doc: remove jumbo offload feature
2021-10-22 12:57 ` [dpdk-dev] [PATCH v2 1/2] doc: remove jumbo offload feature Ferruh Yigit
2021-10-22 12:57 ` [dpdk-dev] [PATCH v2 2/2] drivers/net: fix removing jumbo offload flag Ferruh Yigit
@ 2021-10-22 15:55 ` Ajit Khaparde
1 sibling, 0 replies; 9+ messages in thread
From: Ajit Khaparde @ 2021-10-22 15:55 UTC (permalink / raw)
To: Ferruh Yigit
Cc: Shepard Siegel, Ed Czeck, John Miller, Igor Russkikh,
Steven Webster, Matt Peters, Chandubabu Namburu, Somnath Kotur,
Nithin Dabilpuram, Kiran Kumar K, Sunil Kumar Kori, Satha Rao,
Rahul Lakkireddy, Hemant Agrawal, Sachin Saxena, Haiyue Wang,
Marcin Wojtas, Michal Krawczyk, Shai Brandes, Evgeny Schemeilin,
Igor Chauskin, Gagandeep Singh, John Daley, Hyong Youb Kim,
Gaetan Rivet, Qi Zhang, Xiao Wang, Ziyang Xuan, Xiaoyun Wang,
Guoyang Zhou, Min Hu (Connor),
Yisen Zhuang, Lijun Ou, Beilei Xing, Jingjing Wu, Qiming Yang,
Andrew Boyer, Rosen Xu, Shijith Thotton,
Srisivasubramanian Srinivasan, Jakub Grajciar, Matan Azrad,
Viacheslav Ovsiienko, Zyta Szpak, Liron Himi, Heinrich Kuhn,
Harman Kalra, Jerin Jacob, Rasesh Mody, Devendra Singh Rawat,
Andrew Rybchenko, Maciej Czekaj, Jiawen Wu, Jian Wang, Yong Wang,
dpdk-dev
On Fri, Oct 22, 2021 at 5:57 AM Ferruh Yigit <ferruh.yigit@intel.com> wrote:
>
> Jumbo offload is no more announced as capability, and
> 'DEV_RX_OFFLOAD_JUMBO_FRAME' offload flag is removed.
>
> This patch is also removing 'Jumbo frame' feature from documentation.
>
> Fixes: b563c1421282 ("ethdev: remove jumbo offload flag")
>
> Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
> Acked-by: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
Acked-by: Ajit Khaparde <ajit.khaparde@broadcom.com>
> ---
> doc/guides/nics/features.rst | 12 ------------
> doc/guides/nics/features/ark.ini | 1 -
> doc/guides/nics/features/atlantic.ini | 1 -
> doc/guides/nics/features/avp.ini | 1 -
> doc/guides/nics/features/axgbe.ini | 1 -
> doc/guides/nics/features/bnxt.ini | 1 -
> doc/guides/nics/features/cnxk.ini | 1 -
> doc/guides/nics/features/cnxk_vec.ini | 1 -
> doc/guides/nics/features/cnxk_vf.ini | 1 -
> doc/guides/nics/features/cxgbe.ini | 1 -
> doc/guides/nics/features/cxgbevf.ini | 1 -
> doc/guides/nics/features/default.ini | 1 -
> doc/guides/nics/features/dpaa.ini | 1 -
> doc/guides/nics/features/dpaa2.ini | 1 -
> doc/guides/nics/features/e1000.ini | 1 -
> doc/guides/nics/features/ena.ini | 1 -
> doc/guides/nics/features/enetc.ini | 1 -
> doc/guides/nics/features/enic.ini | 1 -
> doc/guides/nics/features/failsafe.ini | 1 -
> doc/guides/nics/features/fm10k.ini | 1 -
> doc/guides/nics/features/fm10k_vf.ini | 1 -
> doc/guides/nics/features/hinic.ini | 1 -
> doc/guides/nics/features/hns3.ini | 1 -
> doc/guides/nics/features/hns3_vf.ini | 1 -
> doc/guides/nics/features/i40e.ini | 1 -
> doc/guides/nics/features/iavf.ini | 1 -
> doc/guides/nics/features/ice.ini | 1 -
> doc/guides/nics/features/ice_dcf.ini | 1 -
> doc/guides/nics/features/igb.ini | 1 -
> doc/guides/nics/features/igc.ini | 1 -
> doc/guides/nics/features/ionic.ini | 1 -
> doc/guides/nics/features/ipn3ke.ini | 1 -
> doc/guides/nics/features/ixgbe.ini | 1 -
> doc/guides/nics/features/ixgbe_vf.ini | 1 -
> doc/guides/nics/features/liquidio.ini | 1 -
> doc/guides/nics/features/memif.ini | 1 -
> doc/guides/nics/features/mlx4.ini | 1 -
> doc/guides/nics/features/mlx5.ini | 1 -
> doc/guides/nics/features/mvneta.ini | 1 -
> doc/guides/nics/features/mvpp2.ini | 1 -
> doc/guides/nics/features/nfp.ini | 1 -
> doc/guides/nics/features/octeontx.ini | 1 -
> doc/guides/nics/features/octeontx2.ini | 1 -
> doc/guides/nics/features/octeontx2_vec.ini | 1 -
> doc/guides/nics/features/octeontx2_vf.ini | 1 -
> doc/guides/nics/features/pcap.ini | 1 -
> doc/guides/nics/features/qede.ini | 1 -
> doc/guides/nics/features/qede_vf.ini | 1 -
> doc/guides/nics/features/sfc.ini | 1 -
> doc/guides/nics/features/thunderx.ini | 1 -
> doc/guides/nics/features/txgbe.ini | 1 -
> doc/guides/nics/features/txgbe_vf.ini | 1 -
> doc/guides/nics/features/vmxnet3.ini | 1 -
> 53 files changed, 64 deletions(-)
>
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2021-10-22 15:55 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-10-22 12:17 [dpdk-dev] [PATCH] ethdev: fix removing jumbo offload flag Ferruh Yigit
2021-10-22 12:23 ` Andrew Rybchenko
2021-10-22 12:27 ` Ferruh Yigit
2021-10-22 12:57 ` [dpdk-dev] [PATCH v2 1/2] doc: remove jumbo offload feature Ferruh Yigit
2021-10-22 12:57 ` [dpdk-dev] [PATCH v2 2/2] drivers/net: fix removing jumbo offload flag Ferruh Yigit
2021-10-22 14:10 ` Jiang, YuX
2021-10-22 15:20 ` Ferruh Yigit
2021-10-22 15:46 ` Ferruh Yigit
2021-10-22 15:55 ` [dpdk-dev] [PATCH v2 1/2] doc: remove jumbo offload feature Ajit Khaparde
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).