From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id A83FFA0C43; Fri, 22 Oct 2021 14:28:03 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 6AAF04114A; Fri, 22 Oct 2021 14:28:03 +0200 (CEST) Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by mails.dpdk.org (Postfix) with ESMTP id 8D1DE41149 for ; Fri, 22 Oct 2021 14:28:01 +0200 (CEST) X-IronPort-AV: E=McAfee;i="6200,9189,10144"; a="229562985" X-IronPort-AV: E=Sophos;i="5.87,172,1631602800"; d="scan'208";a="229562985" Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Oct 2021 05:28:00 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.87,172,1631602800"; d="scan'208";a="569039334" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by FMSMGA003.fm.intel.com with ESMTP; 22 Oct 2021 05:27:57 -0700 Received: from orsmsx609.amr.corp.intel.com (10.22.229.22) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Fri, 22 Oct 2021 05:27:57 -0700 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx609.amr.corp.intel.com (10.22.229.22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12 via Frontend Transport; Fri, 22 Oct 2021 05:27:57 -0700 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (104.47.55.169) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.12; Fri, 22 Oct 2021 05:27:57 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=QyfaEXNTECAUH9dGY/OWXrv1wGvaQCrnvRCa9iGDAiChVCQutmTEp5PZiPM1X0/nbmMYztmdP2dvAsuOK4QZtb20DKyKWwRc94WY5CGyHHD9UmRPM47Hr9sUyAFr2mYfxpEde+gVbLp6qS/yeCnHyITmsPCg2SuSoutTg/mPO70ri2z24pid0+LyZdgDBij51KXYNPrPGDeSOeIpQWDhE+KbnDlQpFMtCO0Y9HLxJOYDZeO+X0OrMYyU53mMJb+r5Xaz+sBkeokcIYz5xcUv4sJL7yAhvbBQGINbJxF9TvcJdLJtApnYyc7IwKif8+GsYI39lzJwRy20vOT9o7WY1A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=KyUUnps2etgfPr0o//ZC6ZaYe1U+oJdIE4wPVNVOwlM=; b=TrBr/wXHk/gFL7F0eAoYy/Cs33/YPGmsrYmFTOg1jaZdoe5X3xnZ5ellUyS5gkYsOjyxcFR/zOSXPSC1neucrBFTcxe2695cH1189KgkOY1mNXnnv1wFfSqon+PAL4Bcf8VA3W6EmuHictdgkyTE/5eUAL5C/Ee5SGgd0QZZ+K5HeGJSqNIu4c6i6KEV99aUOroUz2PUl58jfCzzzQ+wiNBUl9m3Eo+JxJenIjRMJrnEV7jOXxMGw/+xPyY9KKTOUfoI8Ak34cBWLdj4SsxTGbUSQEiiCevmjlhej8c5MipYPhISMwqhy03zv81qFYs2645FeieD/o3GHxC67bO6FA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=KyUUnps2etgfPr0o//ZC6ZaYe1U+oJdIE4wPVNVOwlM=; b=Kxgh01G7Q4AI6PYxZ0D2yc9VGeTmMTuFvz7HN0tp1No3+yD5tysUozaF0dHUIfX8rznfnq5wYr0NY1pqUu5rUpm49uUL/QUMakV349xPWXx8QqMSURxMTbvi9B5mAS7usSLEwOMDImQeBiSz7XAcTtLRgYJ/Hr4A3pEY48WoHpI= Authentication-Results: oktetlabs.ru; dkim=none (message not signed) header.d=none;oktetlabs.ru; dmarc=none action=none header.from=intel.com; Received: from PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) by PH0PR11MB5879.namprd11.prod.outlook.com (2603:10b6:510:142::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4628.16; Fri, 22 Oct 2021 12:27:48 +0000 Received: from PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::bd7d:29be:3342:632c]) by PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::bd7d:29be:3342:632c%6]) with mapi id 15.20.4628.018; Fri, 22 Oct 2021 12:27:48 +0000 Message-ID: Date: Fri, 22 Oct 2021 13:27:31 +0100 Content-Language: en-US To: Andrew Rybchenko , Shepard Siegel , Ed Czeck , "John Miller" , Igor Russkikh , Steven Webster , Matt Peters , Chandubabu Namburu , "Ajit Khaparde" , Somnath Kotur , Nithin Dabilpuram , Kiran Kumar K , Sunil Kumar Kori , Satha Rao , Rahul Lakkireddy , Hemant Agrawal , Sachin Saxena , Haiyue Wang , Marcin Wojtas , Michal Krawczyk , Shai Brandes , Evgeny Schemeilin , Igor Chauskin , Gagandeep Singh , John Daley , Hyong Youb Kim , Gaetan Rivet , Qi Zhang , Xiao Wang , Ziyang Xuan , Xiaoyun Wang , Guoyang Zhou , "Min Hu (Connor)" , Yisen Zhuang , Lijun Ou , Beilei Xing , Jingjing Wu , Qiming Yang , Andrew Boyer , Rosen Xu , Shijith Thotton , Srisivasubramanian Srinivasan , Jakub Grajciar , Matan Azrad , Viacheslav Ovsiienko , Zyta Szpak , Liron Himi , Heinrich Kuhn , Harman Kalra , Jerin Jacob , Rasesh Mody , Devendra Singh Rawat , Maciej Czekaj , Jiawen Wu , Jian Wang , Yong Wang , Konstantin Ananyev CC: References: <20211022121708.1591089-1-ferruh.yigit@intel.com> From: Ferruh Yigit X-User: ferruhy In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: DB3PR06CA0010.eurprd06.prod.outlook.com (2603:10a6:8:1::23) To PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) MIME-Version: 1.0 Received: from [192.168.0.206] (37.228.236.146) by DB3PR06CA0010.eurprd06.prod.outlook.com (2603:10a6:8:1::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4628.16 via Frontend Transport; Fri, 22 Oct 2021 12:27:36 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 24727e4a-4dee-42bc-066f-08d995575b58 X-MS-TrafficTypeDiagnostic: PH0PR11MB5879: X-LD-Processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:6790; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: XFFmPy2ExrsXPf/GK87l4U44YaeqbItRZayyZ4Lp4jnLk1pn7grFjCJmGAEaRfMye22SmrFxAPX5a8CmB/LbVIDHVjHrTvcH2Zi4oiUOKUYWUNcQm6zc6TSIYZcjUw529TbvdHapN++pIDIJyggD1cH6oE9q1rZUj/01mXBqcXoFQ7akFHf5UuUoruGkjrnug6pdo6przo3DE/Bhk2aab/rWOb7ziZiuor6/WCj4YxiIcpvsDkZkCx1WeimRnFGh/UoHsgl/tLbtq5WG7fPLqd1A4Pl2yIuGIqO+S2yh6oMvTJDT8pSasBQwRMEcV3j7O1lZsd+9OVJ8uSVpH6OYlzA/SM7K/cJ2GW5viuEUIWmy6sf2yDBecokMp+4HFLQAXCmsopAc5GrmlBdiM8+3YlEr3XHePXrzfDLYXOl0edFiOSL6cegR1fu1ctTxXfD0Pzu1mBYiAOlHr2FUUUf/KhtQOCcCi3nRdI7qe5JQaKBJeRY4FBCusmLjasWhNt9hnVfGjvyPsYzaHLonZ9BmKs0YOLj8u95jDFZM5OGmO47/vqXiLAT6kCiquSOSz1rc4e4j2o6uA/ZhcCh3t6SgMcNLDcVQSMHB10u0aXv3/pRiOnrRA9GbGoBlB8V5yZAvczF9QP+inVu/TAimL5uMRaNHtzYpgLvyEtHMk4OYXNSTuqr7/TI8eGjARmNClUBRWlcEhVH4g+zXhmjcbZvC7HJg6PQbbjqqgaiwLWyVSUs= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR11MB5000.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(366004)(110136005)(7366002)(53546011)(66476007)(66556008)(2906002)(31686004)(26005)(921005)(86362001)(316002)(7406005)(31696002)(7416002)(6636002)(956004)(38100700002)(66946007)(36756003)(186003)(8676002)(4744005)(8936002)(16576012)(5660300002)(44832011)(1191002)(508600001)(82960400001)(6486002)(4326008)(2616005)(6666004)(45980500001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?V0FVYzBqVjBadFBDdks2WDZzdHYxNUpJY1NSM3MwNGFwd3FCaDJKTW1hN2hL?= =?utf-8?B?bHZXdmhBU3QzNmpUQmNuRm9Kamo0QmVuTGRkQ2dqbUc3eFgxLzI4cHd0QmVU?= =?utf-8?B?UDRnazRQZ1JOYllrZm9CUWdidTJiSE51WmR5aTE4a1VNbTdMMlRPYWlKSkd0?= =?utf-8?B?U0owSVh5YnNlbDlTSFRTMVRkY2FuWUpKSWxlU0R4UXlEaXlUeG1Na09KRkdn?= =?utf-8?B?Q2tGbGxaQ2hlN3M1TEJPeVBSZTMxSFhuakhWZDRBTWZ4SVNtWjJaTTVGMXdu?= =?utf-8?B?blBrdmVXTnZRbkdsL1JSQTBpMzdXRTFlVGJJVGdBZ1ZxZGx4TWUzbEFneW9Q?= =?utf-8?B?M01WbFVGRVdzOVFUcksvaTZscElkM1p6cGtMMklqTEFHQ3Frd3Ivc1BITGM1?= =?utf-8?B?WjFkVVo3R0R6VXB1dG4xWXRZZXk2SnoybWxNNGhiQURTaTdlVVF1UnpYYjRi?= =?utf-8?B?VXQwZHFoNzFnbUtNUGFjTzdYamVXckw2T3hTT3luV3doUVVwb1dVSkN5WGpw?= =?utf-8?B?MStnVFlXQUJ4ZHBNUlpGK0lSQUU0eXM3Y3NtOTlLYlY5ZEw3UkRJL3RWN0xV?= =?utf-8?B?aUpOaXlKQnplKy9BZTJuMXFCaW1UUmNCZk1OLzNTYThNMnY1cURxRlh4bFJk?= =?utf-8?B?eElWbGE1Sjd4L1BJeTBGWjlyekVoZGJ5RXV6bm45WEE0Nkh2L0ZiRm9wU09X?= =?utf-8?B?NjVSUmVnOWFyQ2NndmthcEZBNzFFRkVBeU4vZFhJdmVONkFSWHJVL3k0Umc1?= =?utf-8?B?a0N3ZGk5b2lJdi9iQWNNUFZwZEJuTlg5ZEd0VHFiNUJXS3BReGNMQ1ZqeEYr?= =?utf-8?B?K1RTaks4dkFRU0hlVlliTjJ4OTE2dXljTTUxdDE0Q2lTMnB3L1pwUUxOakMz?= =?utf-8?B?L3BLN1lkRFk2c2ZoSStWLy9qblJLOGRjY2JmSWp5WTdwbXc5TjZYMXBKRkZR?= =?utf-8?B?bitVK1pFZS9mS2RlV29jdWVtOWZZdUs3cTlkN1RWMDlPRjU5K044ZUtsMkZV?= =?utf-8?B?QThBTlltWS9NdUlTMVVTeFZpcUp3Vk1yblpCUUp3aFl3a0pRU2JoUlVjNzNZ?= =?utf-8?B?N3RxRTlRKzdKaks5SEdtVXBqWW56SU9PeHgxblZKNWhKOEFFNk5iNkZDZHZu?= =?utf-8?B?dWY1c3duRzQrNDJEcWw3Qll1cHk0eU1LV3RLUzNDS0M5R3dScWF6cUxsU2dS?= =?utf-8?B?cUdFRFh3ZXVPa2hSZSt0NWtTYS9BZDNkS1NBb0ozQW56aHlpZFVWUE9PWDdJ?= =?utf-8?B?NHo3UXBaWVRhMy8zdElzN1MrUWNtcWFra3NNbnFxZmIzL2Y1RXNjb2FJUnQy?= =?utf-8?B?N1pkdTE4L3N4MHV3QkRrY25kSkRRVjdscHZ4NWJyQkdDek5YZ2lPNDR1MUFD?= =?utf-8?B?YXNUTS8ybXBQcHA2dlgwdzhFcWJGdkxKcmJMU2Y0NGRwWVFBNkw4U3R6QTNT?= =?utf-8?B?WVJieVROcEtwODZIVGlqL0hSWTN1SWh3a3F3MCtWYll1U1dURW0rUFcyVm9S?= =?utf-8?B?b0thTEliTjFoNi9aRTB1MDlldzZQRjlHZ1lpVk5KZ2hYUnBjWW9kaWw1bWZY?= =?utf-8?B?amh3VHAxbldSWnR3S0xJbkczcUpWSG90d0NGaktqZzZ2K0FWcmg5aEhUcE52?= =?utf-8?B?cUN2cFBDT3JVQ2E4cVhWOVpSb3piTStOWGw2ZmVjMjZ2ZTQ3L0FwUUR6bHVz?= =?utf-8?B?YllZQTN2NGh2ZnVURWFaK3NaVHlZQ1RyaDVnVkQyMVkxMWpWUitXY0tHbVhI?= =?utf-8?B?Sy92TWljTGZ4MUhOU0pMcnJFbElaRE5Fb1ZvN1Rvc0x6MEtwbmxyMm9ya1Fp?= =?utf-8?B?U3NvSGk1dTNmNDFwQTd0bTBqemx0VDlhVnJXZnBnZUcrSG1VdnFVQWFsWWhW?= =?utf-8?B?RStwL2tJZkdYRVNsRTJnNlo2T0ZpMk4zS1A3WDJnenEyaFlkbnpmd1piRDZD?= =?utf-8?Q?S2ox0wmASNpkZJWb0taocAtonvwWy+B7?= X-MS-Exchange-CrossTenant-Network-Message-Id: 24727e4a-4dee-42bc-066f-08d995575b58 X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5000.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Oct 2021 12:27:48.0976 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: ferruh.yigit@intel.com X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB5879 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH] ethdev: fix removing jumbo offload flag X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 10/22/2021 1:23 PM, Andrew Rybchenko wrote: > On 10/22/21 3:17 PM, Ferruh Yigit wrote: >> After DEV_RX_OFFLOAD_JUMBO_FRAME flag removed, jumbo frame decision is >> given by MTU value checks, but some of the checks were wrong by mistake, >> causing device initialization to fail, fixing them. >> >> Also removing 'Jumbo frame' feature. > > Sorry, but I think is is better to split offload removal and > Intel driver fixes. > Sure, I will send next version as separate patches. >> >> Fixes: b563c1421282 ("ethdev: remove jumbo offload flag") >> >> Signed-off-by: Ferruh Yigit > > for offload removal > > Acked-by: Andrew Rybchenko > >> --- >> Some of the check mistakes are residue of local changes, I remember >> fixing them, but it looks like something went wrong while sending >> patches.