Re: [dpdk-dev] [PATCH v3 09/14] eal: hide shared memory config

["Burakov, Anatoly" <anatoly.burakov@intel.com>]

On 04-Jul-19 8:43 AM, David Marchand wrote:
> On Thu, Jun 27, 2019 at 1:39 PM Anatoly Burakov <anatoly.burakov@intel.com>
> wrote:
> 
>> diff --git a/lib/librte_eal/common/include/rte_eal_memconfig.h
>> b/lib/librte_eal/common/include/rte_eal_memconfig.h
>> index 58dcbb96d..1b615c892 100644
>> --- a/lib/librte_eal/common/include/rte_eal_memconfig.h
>> +++ b/lib/librte_eal/common/include/rte_eal_memconfig.h
>> @@ -5,13 +5,12 @@
>>   #ifndef _RTE_EAL_MEMCONFIG_H_
>>   #define _RTE_EAL_MEMCONFIG_H_
>>
>> -#include <rte_config.h>
>> -#include <rte_tailq.h>
>> -#include <rte_memory.h>
>> -#include <rte_memzone.h>
>> -#include <rte_malloc_heap.h>
>> -#include <rte_rwlock.h>
>> -#include <rte_pause.h>
>> +/**
>> + * @file
>> + *
>> + * This API allows access to EAL shared memory configuration through an
>> API.
>> + */
>> +
>>   #include <rte_fbarray.h>
>>
>>   #ifdef __cplusplus
>> @@ -38,68 +37,6 @@ struct rte_memseg_list {
>>          struct rte_fbarray memseg_arr;
>>   };
>>
>>
> You left the rte_memseg_list definition here and the inclusion of
> rte_fbarray.h.
> Is this intentional?

Yes, it is intentional. I can move them to rte_memory, but they have to 
be externally visible.

-- 
Thanks,
Anatoly