From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id AED8E5A44 for ; Thu, 12 Jan 2017 16:43:29 +0100 (CET) Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga102.jf.intel.com with ESMTP; 12 Jan 2017 07:43:28 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.33,219,1477983600"; d="scan'208";a="921779262" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.237.220.38]) ([10.237.220.38]) by orsmga003.jf.intel.com with ESMTP; 12 Jan 2017 07:43:27 -0800 To: Wei Zhao , dev@dpdk.org References: <1484210439-61746-1-git-send-email-wei.zhao1@intel.com> <1484212665-1635-1-git-send-email-wei.zhao1@intel.com> From: Ferruh Yigit Message-ID: Date: Thu, 12 Jan 2017 15:43:26 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.6.0 MIME-Version: 1.0 In-Reply-To: <1484212665-1635-1-git-send-email-wei.zhao1@intel.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v5 00/18] net/ixgbe: Consistent filter API X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 12 Jan 2017 15:43:30 -0000 Hi Wei, On 1/12/2017 9:17 AM, Wei Zhao wrote: > The patches mainly finish following functions: > 1) Store and restore all kinds of filters. > 2) Parse all kinds of filters. > 3) Add flow validate function. > 4) Add flow create function. > 5) Add flow destroy function. > 6) Add flow flush function. Overall patchset looks good, only major comment is adding more comments on parse_filter functions for expected/valid rules. You can keep Beilei's Ack for next version of the patchset. Thanks, ferruh