From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2BE66A0C41; Wed, 15 Sep 2021 18:47:54 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 11AD04068F; Wed, 15 Sep 2021 18:47:54 +0200 (CEST) Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by mails.dpdk.org (Postfix) with ESMTP id DE5604014F for ; Wed, 15 Sep 2021 18:47:51 +0200 (CEST) X-IronPort-AV: E=McAfee;i="6200,9189,10108"; a="307925347" X-IronPort-AV: E=Sophos;i="5.85,295,1624345200"; d="scan'208";a="307925347" Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Sep 2021 09:47:51 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.85,295,1624345200"; d="scan'208";a="553374148" Received: from fmsmsx603.amr.corp.intel.com ([10.18.126.83]) by fmsmga002.fm.intel.com with ESMTP; 15 Sep 2021 09:47:50 -0700 Received: from fmsmsx607.amr.corp.intel.com (10.18.126.87) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Wed, 15 Sep 2021 09:47:50 -0700 Received: from fmsmsx612.amr.corp.intel.com (10.18.126.92) by fmsmsx607.amr.corp.intel.com (10.18.126.87) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Wed, 15 Sep 2021 09:47:50 -0700 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx612.amr.corp.intel.com (10.18.126.92) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12 via Frontend Transport; Wed, 15 Sep 2021 09:47:50 -0700 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (104.47.57.169) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.12; Wed, 15 Sep 2021 09:47:50 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=F1GD/FB4jXYKB2J9JIHHddRrrAmTXpXarEMTDM8cw8zZXk77ji6n6GyzpaFsSTARV0GKIqK8QsP2N+HVVci6zktVCdaNIn/P++LzQpreA4pQmVGYG+18ssTn4qqNB/RXfpMCkM9hob6gPhY/OEvxD+0Rxc52imKq8DHJh2JS8mylNVfw9hYfeY67b/hfYOatD8kTNezNWz43OdagYuTPDWJimDn4kKYmS6muHwSBo+Tq7wq6fzjtlADUjNXU8dQHbVrcyBSAXpxXUrErWCCWpeOyYm4LXtw/7XvcRz0BK8qFFJjABt0flDY7ECrV3Dn9dtcz9PXnLpVzeU40dYiBpQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=FocriXzzb81XBnhxqEdrVg+SRtgB0kCXI74533UCeu4=; b=Z/vXgyQBWnpRrs3XVOHIgujwnbotwkOvlh4yG72NqLCHeluF5kMn6wYtovvGGx1bkkVIyxamLaW/fcogC+flkAM0P82nojcIQahdTbesUos9lPtwspds5jhStLUYCfbGnFePPA9uMlNvsciaOkx5VfTql70G+mhILpYfEM+Z7cCmAnViYDq4RXT0jOJuymWFsAkKx+mTjIlfLiH94dujjDY24Rq1TDllYzZxfj3iqf8MVwIq/OUkO6RibApIsQflWQ5gUU8B+SYlo2qO4DntwcRNOyOF3q0oUc5iotBCTEzG2IuxPyY6UFJDGGDhblxWSThdNwAoiiq7u4UQT6S2SA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=FocriXzzb81XBnhxqEdrVg+SRtgB0kCXI74533UCeu4=; b=ckKbi8BrmAkcEIsZ2zjis4uNdhDC8VxRhhPsfs4MCuVWnLC5NgTuprtEPwq0xxqMpxEA3r8783WoIqXglqs/RVqQ6R/6kDiphVFX0I9j9byaO150bMv79dUNkqqsQfQjcgSiA8kJpy0/gXSQerMMJKpHc4yxXzg/ZC1wFxKxJLw= Authentication-Results: dpdk.org; dkim=none (message not signed) header.d=none;dpdk.org; dmarc=none action=none header.from=intel.com; Received: from PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) by PH0PR11MB5112.namprd11.prod.outlook.com (2603:10b6:510:3b::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4500.16; Wed, 15 Sep 2021 16:47:48 +0000 Received: from PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::747b:3a08:d1ec:31fc]) by PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::747b:3a08:d1ec:31fc%5]) with mapi id 15.20.4500.019; Wed, 15 Sep 2021 16:47:48 +0000 To: Jiawen Wu , References: <20210908083758.312055-1-jiawenwu@trustnetic.com> <20210908083758.312055-2-jiawenwu@trustnetic.com> From: Ferruh Yigit X-User: ferruhy Message-ID: Date: Wed, 15 Sep 2021 17:47:44 +0100 In-Reply-To: <20210908083758.312055-2-jiawenwu@trustnetic.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit X-ClientProxiedBy: DU2PR04CA0241.eurprd04.prod.outlook.com (2603:10a6:10:28e::6) To PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) MIME-Version: 1.0 Received: from [192.168.0.206] (37.228.236.146) by DU2PR04CA0241.eurprd04.prod.outlook.com (2603:10a6:10:28e::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4500.14 via Frontend Transport; Wed, 15 Sep 2021 16:47:48 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: f0ad61e8-b795-478d-782a-08d978688cf6 X-MS-TrafficTypeDiagnostic: PH0PR11MB5112: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:7691; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: sfgTu4zxvN55WIZ71ryQpkj5UAHczA15Y9EwBuQ2q6nYkyk8/WcVIrC48JXJC3bBZIxGpwTFgvnV/2Mjj4+iJqu9eLcCn/6/nMOj9Et8yn9p4Fpy6SQuI627VnY3ETnoWu2ootulkcz4X7pam5+nNwr+pruGUNvNMLgwiOeBDr4YotfLFoUEvkKo68RLcqe6nS53BJlnt5Ppk9o/GaueqpuqNvfRmiosmPXm7CDin2cmYJqGWgqdJkJl+u45u+6V2xaSr9NNrhlfX08216IgnmLXJaVipcE2SenRWKjUtAaHtWnE7J4tMfxPxMKfQv663JbpSG/9ZfYUsmePa6d1KtIllTCBKggAyDDSIMXlLoSAH3uLPAD16CpiYuksL3h/eEhhNfGroDsQm+Ny+boGbfRyIyOOSjLjnr8oMLYGjhXVT7nFWLlcZ1FoS/Rw0FJRE3frgGBiyC7klAb018o15kxFmZpWU5GHVfO4rsbc63fKvjK0B9qF4hvj2w9w0Qlffj/YzGQyFmK5ZeejH/gIkWViuhrJBqOR72I1Vzurov8h0Gyu1qASlpFmbjivkVyMOY5yHP9CoKMzpuZYNmrpjAWz2MpzEjmGRYaygrEysot77hTHCTk6iM6X9oAhYjrXiD8QB9/3Fvg6Re9JC1tZhZXxXG1fZVde2hjYO6lhO3SY8e4TPZsqsEDB6gqJEFb7DodweZqhKwLh+aYtek2/kw== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR11MB5000.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(396003)(376002)(346002)(39860400002)(136003)(366004)(478600001)(6486002)(5660300002)(8936002)(36756003)(6666004)(31696002)(86362001)(2616005)(956004)(44832011)(2906002)(38100700002)(66946007)(186003)(66556008)(66476007)(8676002)(83380400001)(316002)(26005)(53546011)(31686004)(16576012)(45980500001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?V0M0NkZCMnJweDN3Q1VnbzErVEIwZ3c3NWovdkppekNEWncyNTdiUkMzZEZI?= =?utf-8?B?bmw5emV4TThBUEZtc1lzOGhoTVZMTXJmYlZIR3VCRE5LdDNieVIyWng4dWYw?= =?utf-8?B?bXFzTW5udWI0VXlaVzBzQ0FSQzN5WFQ5VzlUeEFvQWRxdTFUb0xrVEdSRVR6?= =?utf-8?B?b0I4ZXZwN2NKSHVERzh6TG4vZUJ3SEJrZFQ0SDI1THVRM1duUEJRaDN5alJP?= =?utf-8?B?QnZ6TGtiM2hlM2ZzYVc4WVJXTzArWHc4aVFGYUw5dlVyUThLamVIcWJQeHU1?= =?utf-8?B?QWE2eWxBYUE0ZzZvYXJmcTlRcVhXVTRqUkdlN1g2NzNGblVqSXdaU2J4RGt5?= =?utf-8?B?ZUNycVNPQnlRTElZNFhBUHhJSW1CelV3aDAzdG1MWWhScnAwUWUxVWdGV2JZ?= =?utf-8?B?N25BWklIY0pwVnJPWUdqbFdrS3AwbVRWRCtudFEvcjRlV3FxR1VNWUpnaGZk?= =?utf-8?B?L0liMlljMkNvU3dzY3pZNzR2UWQyOU9oblJ5UWw0N2ZmbUc1UEVsby9SOTh6?= =?utf-8?B?V2E5d2JSM0tQVS9jU041eWFtRWUvb1JqQVdRMEFFTGJFNTkvR0tBS1lZdTNZ?= =?utf-8?B?aDN0Z3V2OG9nUTVuWk93d3JDMGlYMXBXT1AreTBBMFpnUEpXNmR3d1QveXFr?= =?utf-8?B?b0YvQjBIWXYraVJJSWM1eU8zalRaVG9renZhNk1oNHFlV3BndDB1ODBwTHBQ?= =?utf-8?B?VUUyYkF1cmRsd295Zm52VnBWaUozcDloVXBNUzJtbFNRQ2g3SWlqVC9ka2tv?= =?utf-8?B?RXN2QkcyZ0NSZzloNEhOMW02YUF0WG04MTgralRwSUR3NUN5blo0OXUzOE1y?= =?utf-8?B?a3IyTjdHWU5RLzRSakV5V2REeG5QTDAyWGFvQVdHSklCUkh0WnI2eGJhdUF5?= =?utf-8?B?T2dlejZjdml6OHFTVjFTUituMHpvbWV5Q25SZU42Sk1tMG1tNjA5LzRXNzZB?= =?utf-8?B?QURzekxZMUc3S0YwZk9wMEd2c3diOUJTQjR5RTduZFkwNkRuZ0RUZWFSdHF5?= =?utf-8?B?RVhtZFdscFpXMnlNVndXdFJYNWRSTHRsd0ZwaGhnMUpDd1hLZDUyTVV2YXhw?= =?utf-8?B?cEl0ck5oUUFHbzMwZCs2blNjUEkreFdpNlQ3dkVRQ3N0WVIzY3hyRWZuZmZ2?= =?utf-8?B?Uk1NRE1ORENIQ29GWVgrWWRlZDhnenhBeEwrRXNXbko1dEQ5bGFMTTYzSnA2?= =?utf-8?B?K1h6WjV5Tk9TV2VGbG00a2drQW5DUlNwVjNFUzVrejZWcFErM0RFL21WVlJt?= =?utf-8?B?djFNUWZnaW1IYU0wa0lOZ0d5RGd6Z0FjWHdhdWFGcHo2Undsa21Bc2J3TmI3?= =?utf-8?B?SmUxL2NjZzNGMERMRFA1cEFicWt4NVVNYms5N3hEbHBhWHNlbjdOeGo4SFZB?= =?utf-8?B?STJ5K2ZQZEx4YkdEejkyZEVHa3Z3US9Ubkdpdy9RdUlVdFViMnNhN0Y3Q0dF?= =?utf-8?B?aGFDVmludjBXOXVXWkdEbHN4RmtRZkNneEZhSFI2VUFQVkJsdjBmdWI3VERm?= =?utf-8?B?MUZQWnhBajFqcW1JaDlCUUZJUlI1a3dEWEdWazZWNFVQSkZpWkU4WUp2TUJq?= =?utf-8?B?YllHbUM1Vk54T2I4S2V4bVBXaFA4Q2dzQzFJbDk4aE5xVHNDWWVWNTF4SW54?= =?utf-8?B?ZHlRNTZpSkJZclYvUXQzWTRub2xBaXN4UDQrblMvOWJaSEwvQ0tMWFRBM0xU?= =?utf-8?B?UVFpcytiU3hBZ0NzNEYwMjNWa3ZIbzNhUnovYTBTQVNGM1ZnM0Vjbkd2TEZ1?= =?utf-8?Q?PJ1gcBeyptvdbmH3yvClgNqQBTHCeMsFcCvBmic?= X-MS-Exchange-CrossTenant-Network-Message-Id: f0ad61e8-b795-478d-782a-08d978688cf6 X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5000.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Sep 2021 16:47:48.8432 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: VAAdJgtzK7k7fNo1V62DRRxlluR6L3KcdYLx103yFDkYTjTrSXrVkI2bzZp1z115K9Bn9saQOzWmojwO4xQa3w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB5112 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH 01/32] net/ngbe: add packet type X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 9/8/2021 9:37 AM, Jiawen Wu wrote: > Add packet type marco definition and convert ptype to ptid. > > Signed-off-by: Jiawen Wu > --- > doc/guides/nics/features/ngbe.ini | 1 + > doc/guides/nics/ngbe.rst | 1 + > drivers/net/ngbe/meson.build | 1 + > drivers/net/ngbe/ngbe_ethdev.c | 9 + > drivers/net/ngbe/ngbe_ethdev.h | 4 + > drivers/net/ngbe/ngbe_ptypes.c | 300 ++++++++++++++++++++++++++++++ > drivers/net/ngbe/ngbe_ptypes.h | 240 ++++++++++++++++++++++++ > drivers/net/ngbe/ngbe_rxtx.c | 16 ++ > drivers/net/ngbe/ngbe_rxtx.h | 2 + > 9 files changed, 574 insertions(+) > create mode 100644 drivers/net/ngbe/ngbe_ptypes.c > create mode 100644 drivers/net/ngbe/ngbe_ptypes.h > > diff --git a/doc/guides/nics/features/ngbe.ini b/doc/guides/nics/features/ngbe.ini > index 08d5f1b0dc..8b7588184a 100644 > --- a/doc/guides/nics/features/ngbe.ini > +++ b/doc/guides/nics/features/ngbe.ini > @@ -8,6 +8,7 @@ Speed capabilities = Y > Link status = Y > Link status event = Y > Queue start/stop = Y > +Packet type parsing = Y "Packet type parsing" also requires to support 'rte_eth_dev_get_supported_ptypes()' & 'rte_eth_dev_set_ptypes()' APIs. Current implementation seems parses the packet type and updates mbuf field for it but doesn't support above APIs, can you please add them too? There is already 'ngbe_dev_supported_ptypes_get()' function but dev_ops seems not set. <...> > +++ b/drivers/net/ngbe/ngbe_ptypes.c > @@ -0,0 +1,300 @@ > +/* SPDX-License-Identifier: BSD-3-Clause > + * Copyright(c) 2018-2021 Beijing WangXun Technology Co., Ltd. > + */ > + > +#include > +#include > + > +#include "base/ngbe_type.h" > +#include "ngbe_ptypes.h" > + > +/* The ngbe_ptype_lookup is used to convert from the 8-bit ptid in the > + * hardware to a bit-field that can be used by SW to more easily determine the > + * packet type. > + * > + * Macros are used to shorten the table lines and make this table human > + * readable. > + * > + * We store the PTYPE in the top byte of the bit field - this is just so that > + * we can check that the table doesn't have a row missing, as the index into > + * the table should be the PTYPE. > + */ > +#define TPTE(ptid, l2, l3, l4, tun, el2, el3, el4) \ > + [ptid] = (RTE_PTYPE_L2_##l2 | \ > + RTE_PTYPE_L3_##l3 | \ > + RTE_PTYPE_L4_##l4 | \ > + RTE_PTYPE_TUNNEL_##tun | \ > + RTE_PTYPE_INNER_L2_##el2 | \ > + RTE_PTYPE_INNER_L3_##el3 | \ > + RTE_PTYPE_INNER_L4_##el4) > + > +#define RTE_PTYPE_L2_NONE 0 > +#define RTE_PTYPE_L3_NONE 0 > +#define RTE_PTYPE_L4_NONE 0 > +#define RTE_PTYPE_TUNNEL_NONE 0 > +#define RTE_PTYPE_INNER_L2_NONE 0 > +#define RTE_PTYPE_INNER_L3_NONE 0 > +#define RTE_PTYPE_INNER_L4_NONE 0 Why you are defining new PTYPEs? If these are for driver internal you can drop the 'RTE_' prefix. <...> > + > +#ifndef RTE_PTYPE_UNKNOWN > +#define RTE_PTYPE_UNKNOWN 0x00000000 > +#define RTE_PTYPE_L2_ETHER 0x00000001 > +#define RTE_PTYPE_L2_ETHER_TIMESYNC 0x00000002 > +#define RTE_PTYPE_L2_ETHER_ARP 0x00000003 > +#define RTE_PTYPE_L2_ETHER_LLDP 0x00000004 > +#define RTE_PTYPE_L2_ETHER_NSH 0x00000005 > +#define RTE_PTYPE_L2_ETHER_FCOE 0x00000009 > +#define RTE_PTYPE_L3_IPV4 0x00000010 > +#define RTE_PTYPE_L3_IPV4_EXT 0x00000030 > +#define RTE_PTYPE_L3_IPV6 0x00000040 > +#define RTE_PTYPE_L3_IPV4_EXT_UNKNOWN 0x00000090 > +#define RTE_PTYPE_L3_IPV6_EXT 0x000000c0 > +#define RTE_PTYPE_L3_IPV6_EXT_UNKNOWN 0x000000e0 > +#define RTE_PTYPE_L4_TCP 0x00000100 > +#define RTE_PTYPE_L4_UDP 0x00000200 > +#define RTE_PTYPE_L4_FRAG 0x00000300 > +#define RTE_PTYPE_L4_SCTP 0x00000400 > +#define RTE_PTYPE_L4_ICMP 0x00000500 > +#define RTE_PTYPE_L4_NONFRAG 0x00000600 > +#define RTE_PTYPE_TUNNEL_IP 0x00001000 > +#define RTE_PTYPE_TUNNEL_GRE 0x00002000 > +#define RTE_PTYPE_TUNNEL_VXLAN 0x00003000 > +#define RTE_PTYPE_TUNNEL_NVGRE 0x00004000 > +#define RTE_PTYPE_TUNNEL_GENEVE 0x00005000 > +#define RTE_PTYPE_TUNNEL_GRENAT 0x00006000 > +#define RTE_PTYPE_INNER_L2_ETHER 0x00010000 > +#define RTE_PTYPE_INNER_L2_ETHER_VLAN 0x00020000 > +#define RTE_PTYPE_INNER_L3_IPV4 0x00100000 > +#define RTE_PTYPE_INNER_L3_IPV4_EXT 0x00200000 > +#define RTE_PTYPE_INNER_L3_IPV6 0x00300000 > +#define RTE_PTYPE_INNER_L3_IPV4_EXT_UNKNOWN 0x00400000 > +#define RTE_PTYPE_INNER_L3_IPV6_EXT 0x00500000 > +#define RTE_PTYPE_INNER_L3_IPV6_EXT_UNKNOWN 0x00600000 > +#define RTE_PTYPE_INNER_L4_TCP 0x01000000 > +#define RTE_PTYPE_INNER_L4_UDP 0x02000000 > +#define RTE_PTYPE_INNER_L4_FRAG 0x03000000 > +#define RTE_PTYPE_INNER_L4_SCTP 0x04000000 > +#define RTE_PTYPE_INNER_L4_ICMP 0x05000000 > +#define RTE_PTYPE_INNER_L4_NONFRAG 0x06000000 > +#endif /* !RTE_PTYPE_UNKNOWN */ These are already defined in the mbuf public header, why there are defined again? <...> > @@ -378,6 +389,10 @@ ngbe_recv_pkts(void *rx_queue, struct rte_mbuf **rx_pkts, > rxm->data_len = pkt_len; > rxm->port = rxq->port_id; > > + pkt_info = rte_le_to_cpu_32(rxd.qw0.dw0); > + rxm->packet_type = ngbe_rxd_pkt_info_to_pkt_type(pkt_info, > + rxq->pkt_type_mask); > + > /* > * Store the mbuf address into the next entry of the array > * of returned packets. > @@ -799,6 +814,7 @@ ngbe_dev_rx_queue_setup(struct rte_eth_dev *dev, > rxq->port_id = dev->data->port_id; > rxq->drop_en = rx_conf->rx_drop_en; > rxq->rx_deferred_start = rx_conf->rx_deferred_start; > + rxq->pkt_type_mask = NGBE_PTID_MASK; What is the use of the 'pkt_type_mask', it seems it is a fixed value, why keeping it per queue?