From: Ferruh Yigit <ferruh.yigit@amd.com>
To: "Singh, Aman Deep" <aman.deep.singh@intel.com>,
Dengdui Huang <huangdengdui@huawei.com>,
dev@dpdk.org
Cc: yuying.zhang@intel.com, liuyonglong@huawei.com
Subject: Re: [PATCH] app/testpmd: handle IEEE1588 init fail
Date: Fri, 5 Jul 2024 12:27:28 +0100 [thread overview]
Message-ID: <c24c2ab6-7962-44ca-9980-3e202eabc639@amd.com> (raw)
In-Reply-To: <f87d78ba-6d0e-40fa-8c6e-c75f5e62d4dd@intel.com>
On 4/5/2024 4:36 PM, Singh, Aman Deep wrote:
> On 3/30/2024 1:14 PM, Dengdui Huang wrote:
>> When the port's timestamping function failed to initialize
>> (for example, the device does not support PTP), the packets
>> received by the hardware do not contain the timestamp.
>> In this case, IEEE1588 packet forwarding should not start.
>> This patch fix it.
>>
>> Plus, adding a failure message when failed to disable PTP.
>>
>> Fixes: a78040c990cb ("app/testpmd: update forward engine beginning")
>> Cc: stable@dpdk.org
>>
>> Signed-off-by: Dengdui Huang <huangdengdui@huawei.com>
>
> Acked-by: Aman Singh <aman.deep.singh@intel.com>
>
Applied to dpdk-next-net/main, thanks.
Will continue with 'printf', as most of the file already use it,
unifying logs can be done later.
next prev parent reply other threads:[~2024-07-05 11:27 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-30 7:44 Dengdui Huang
2024-04-05 15:36 ` Singh, Aman Deep
2024-07-05 11:27 ` Ferruh Yigit [this message]
2024-04-05 16:44 ` Stephen Hemminger
2024-04-08 5:52 ` huangdengdui
2024-04-08 8:45 ` Ferruh Yigit
2024-04-09 2:06 ` huangdengdui
2024-04-09 2:50 ` Stephen Hemminger
2024-04-17 9:26 ` huangdengdui
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c24c2ab6-7962-44ca-9980-3e202eabc639@amd.com \
--to=ferruh.yigit@amd.com \
--cc=aman.deep.singh@intel.com \
--cc=dev@dpdk.org \
--cc=huangdengdui@huawei.com \
--cc=liuyonglong@huawei.com \
--cc=yuying.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).