DPDK patches and discussions
 help / color / mirror / Atom feed
* [PATCH] app/testpmd: handle IEEE1588 init fail
@ 2024-03-30  7:44 Dengdui Huang
  2024-04-05 15:36 ` Singh, Aman Deep
  2024-04-05 16:44 ` Stephen Hemminger
  0 siblings, 2 replies; 9+ messages in thread
From: Dengdui Huang @ 2024-03-30  7:44 UTC (permalink / raw)
  To: dev; +Cc: ferruh.yigit, aman.deep.singh, yuying.zhang, liuyonglong

When the port's timestamping function failed to initialize
(for example, the device does not support PTP), the packets
received by the hardware do not contain the timestamp.
In this case, IEEE1588 packet forwarding should not start.
This patch fix it.

Plus, adding a failure message when failed to disable PTP.

Fixes: a78040c990cb ("app/testpmd: update forward engine beginning")
Cc: stable@dpdk.org

Signed-off-by: Dengdui Huang <huangdengdui@huawei.com>
---
 app/test-pmd/ieee1588fwd.c | 15 ++++++++++++---
 1 file changed, 12 insertions(+), 3 deletions(-)

diff --git a/app/test-pmd/ieee1588fwd.c b/app/test-pmd/ieee1588fwd.c
index 3371771751..afea7735c7 100644
--- a/app/test-pmd/ieee1588fwd.c
+++ b/app/test-pmd/ieee1588fwd.c
@@ -197,14 +197,23 @@ ieee1588_packet_fwd(struct fwd_stream *fs)
 static int
 port_ieee1588_fwd_begin(portid_t pi)
 {
-	rte_eth_timesync_enable(pi);
-	return 0;
+	int ret;
+
+	ret = rte_eth_timesync_enable(pi);
+	if (ret)
+		printf("Port %u enable PTP failed, ret = %d\n", pi, ret);
+
+	return ret;
 }
 
 static void
 port_ieee1588_fwd_end(portid_t pi)
 {
-	rte_eth_timesync_disable(pi);
+	int ret;
+
+	ret = rte_eth_timesync_disable(pi);
+	if (ret)
+		printf("Port %u disable PTP failed, ret = %d\n", pi, ret);
 }
 
 static void
-- 
2.33.0


^ permalink raw reply	[flat|nested] 9+ messages in thread

end of thread, other threads:[~2024-07-05 11:27 UTC | newest]

Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-03-30  7:44 [PATCH] app/testpmd: handle IEEE1588 init fail Dengdui Huang
2024-04-05 15:36 ` Singh, Aman Deep
2024-07-05 11:27   ` Ferruh Yigit
2024-04-05 16:44 ` Stephen Hemminger
2024-04-08  5:52   ` huangdengdui
2024-04-08  8:45     ` Ferruh Yigit
2024-04-09  2:06       ` huangdengdui
2024-04-09  2:50         ` Stephen Hemminger
2024-04-17  9:26           ` huangdengdui

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).