From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id E51992BB8 for ; Fri, 9 Jun 2017 14:23:21 +0200 (CEST) Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 09 Jun 2017 05:23:07 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.39,317,1493708400"; d="scan'208";a="96292334" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.237.220.91]) ([10.237.220.91]) by orsmga004.jf.intel.com with ESMTP; 09 Jun 2017 05:23:06 -0700 To: Wei Zhao , dev@dpdk.org Cc: wenzhuo.lu@intel.com References: <1496385391-12445-1-git-send-email-wei.zhao1@intel.com> <1496977908-2149-1-git-send-email-wei.zhao1@intel.com> <1496977908-2149-9-git-send-email-wei.zhao1@intel.com> From: Ferruh Yigit Message-ID: Date: Fri, 9 Jun 2017 13:23:05 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.1.1 MIME-Version: 1.0 In-Reply-To: <1496977908-2149-9-git-send-email-wei.zhao1@intel.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH v3 08/11] net/e1000: parse flex filter X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 09 Jun 2017 12:23:22 -0000 On 6/9/2017 4:11 AM, Wei Zhao wrote: > check if the rule is a flex byte rule, and get the flex info. > > Signed-off-by: Wei Zhao <...> > + const struct rte_flow_item_raw *raw_mask; <...> > + > + if (!raw_mask->length || > + !raw_mask->pattern || > + !raw_mask->relative) { This gives following clang build error: .../drivers/net/e1000/igb_flow.c:1094:17: error: address of array 'raw_mask->pattern' will always evaluate to 'true' [-Werror,-Wpointer-bool-conversion] !raw_mask->pattern || ~~~~~~~~~~~^~~~~~~ <...>