From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by dpdk.org (Postfix) with ESMTP id 0EF80A493 for ; Mon, 15 Jan 2018 11:52:44 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 15 Jan 2018 02:52:44 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.46,363,1511856000"; d="scan'208";a="10197912" Received: from jguo15x-mobl3.ccr.corp.intel.com (HELO [10.67.68.50]) ([10.67.68.50]) by fmsmga007.fm.intel.com with ESMTP; 15 Jan 2018 02:52:41 -0800 To: Thomas Monjalon References: <1515575544-2141-3-git-send-email-jia.guo@intel.com> <1515679534-22473-1-git-send-email-jia.guo@intel.com> <1515679534-22473-2-git-send-email-jia.guo@intel.com> <5621685.YHClJoWfgs@xps> Cc: dev@dpdk.org, stephen@networkplumber.org, bruce.richardson@intel.com, ferruh.yigit@intel.com, gaetan.rivet@6wind.com, konstantin.ananyev@intel.com, jblunck@infradead.org, shreyansh.jain@nxp.com, jingjing.wu@intel.com, helin.zhang@intel.com, motih@mellanox.com From: "Guo, Jia" Message-ID: Date: Mon, 15 Jan 2018 18:52:40 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <5621685.YHClJoWfgs@xps> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH V10 2/2] eal: add uevent pass and process function X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 15 Jan 2018 10:52:45 -0000 On 1/15/2018 7:24 AM, Thomas Monjalon wrote: > 11/01/2018 15:05, Jeff Guo: >> +enum rte_dev_state { >> + RTE_DEV_UNDEFINED, /**< unknown device state */ >> + RTE_DEV_FAULT, /**< device fault or error */ >> + RTE_DEV_PARSED, /**< device have been parsed on bus*/ >> + RTE_DEV_PROBED, /**< devcie have been probed driver */ >> +}; > Let's start with nitpicks: please be careful with spacing in comments. > + typo: devcie > + grammar: device has > > What means parsed on bus? Is it "scanned"? absolutely what i mean is scanned. >> +enum rte_dev_subsystem { >> + RTE_DEV_SUBSYSTEM_UIO, >> + RTE_DEV_SUBSYSTEM_VFIO, >> + RTE_DEV_SUBSYSTEM_PCI, >> + RTE_DEV_SUBSYSTEM_MAX >> +}; > I don't think PCI and UIO/VFIO should be described at the same level. > Can you re-use the enum rte_kernel_driver? rte_kernel_driver might be not qualify for that use, since that is the event sumsystem, it include pci/uio/vfio, such strings to identify each subsystem. i will modify it to be rte_dev_event_subsystem. >> +enum event_monitor_netlink_group { >> + RTE_DEV_EVENT_MONITOR_KERNEL, >> + RTE_DEV_EVENT_MONITOR_UDEV, >> +}; > This enum should be prefixed with rte_ sure. >> + enum event_monitor_netlink_group group; /**< device netlink group */ > netlink is specific to Linux. > I don't think it should be in a generic API struct. agree.