DPDK patches and discussions
 help / color / mirror / Atom feed
From: Ivan Dyukov <i.dyukov@samsung.com>
To: "Thomas Monjalon" <thomas@monjalon.net>,
	"Morten Brørup" <mb@smartsharesystems.com>,
	"Ferruh Yigit" <ferruh.yigit@intel.com>,
	"Andrew Rybchenko" <arybchenko@solarflare.com>
Cc: dev@dpdk.org, Matan Azrad <matan@mellanox.com>,
	"Benoit Ganne (bganne)" <bganne@cisco.com>,
	maxime.coquelin@redhat.com,
	'Vladimir Kuramshin' <v.kuramshin@samsung.com>,
	amorenoz@redhat.com, zhihong.wang@intel.com,
	xiaolong.ye@intel.com
Subject: Re: [dpdk-dev] [RFC] ethdev: use special speed for virtual Ethernetdevices
Date: Fri, 3 Apr 2020 11:05:31 +0300	[thread overview]
Message-ID: <c29ec4a4-cd75-0d47-cdc7-54acf8c928a2@samsung.com> (raw)
In-Reply-To: <2511295.FGBNh6B6GM@xps>

02.04.2020 23:58, Thomas Monjalon пишет:
> 02/04/2020 22:41, Ivan Dyukov:
>> 02.04.2020 16:50, Morten Brørup пишет:
>>>>>> Yes, if speed is unknown, it should be reported as 0.
>>> Could the DPDK vNIC PMDs be updated accordingly? At least the virtio driver...
>> Current version of dpdk code on master always returns 10G speed for
>> virtio device and many application rely on it. e.g. pktgen. If we'll
>> change it, we break the apps.
> I am OK with breaking such strange assumption.
> I can understand the need for specifying the underlying hardware speed
> through virtio driver. But hardcoded 10G... no!
>
>
>
OK. I'll redefine it to 0xffffffff, like in kernel virtio.


  reply	other threads:[~2020-04-03  8:05 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-01  9:33 [dpdk-dev] [RFC] ethdev: use special speed for virtual Ethernet devices Morten Brørup
2020-04-01  9:53 ` Thomas Monjalon
2020-04-01 10:03   ` Benoit Ganne (bganne)
2020-04-01 10:06   ` [dpdk-dev] [RFC] ethdev: use special speed for virtual Ethernetdevices Morten Brørup
2020-04-02 12:54     ` Ivan Dyukov
2020-04-02 13:50       ` Morten Brørup
2020-04-02 15:29         ` Stephen Hemminger
2020-04-02 20:41         ` Ivan Dyukov
2020-04-02 20:58           ` Thomas Monjalon
2020-04-03  8:05             ` Ivan Dyukov [this message]
2020-04-03  9:45               ` Morten Brørup
2020-04-03 11:01                 ` Thomas Monjalon
2020-04-07 22:26                 ` [dpdk-dev] [PATCH 0/2] ethdev link speed Thomas Monjalon
2020-04-07 22:26                   ` [dpdk-dev] [PATCH 1/2] ethdev: deduplicate functions to get link infos Thomas Monjalon
2020-04-08  5:21                     ` Asaf Penso
2020-04-08 12:49                       ` Thomas Monjalon
2020-04-13 14:14                     ` Andrew Rybchenko
2020-04-07 22:26                   ` [dpdk-dev] [PATCH 2/2] ethdev: allow unknown link speed Thomas Monjalon
2020-04-08  5:39                     ` Jerin Jacob
2020-04-10 10:53                     ` Morten Brørup
2020-04-13 14:26                     ` Andrew Rybchenko
2020-04-16 13:42                       ` Ferruh Yigit
2020-04-26 11:44                     ` Matan Azrad

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c29ec4a4-cd75-0d47-cdc7-54acf8c928a2@samsung.com \
    --to=i.dyukov@samsung.com \
    --cc=amorenoz@redhat.com \
    --cc=arybchenko@solarflare.com \
    --cc=bganne@cisco.com \
    --cc=dev@dpdk.org \
    --cc=ferruh.yigit@intel.com \
    --cc=matan@mellanox.com \
    --cc=maxime.coquelin@redhat.com \
    --cc=mb@smartsharesystems.com \
    --cc=thomas@monjalon.net \
    --cc=v.kuramshin@samsung.com \
    --cc=xiaolong.ye@intel.com \
    --cc=zhihong.wang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).