From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dispatch1-us1.ppe-hosted.com (dispatch1-us1.ppe-hosted.com [67.231.154.164]) by dpdk.org (Postfix) with ESMTP id 583F61C83A for ; Sat, 7 Apr 2018 10:28:06 +0200 (CEST) X-Virus-Scanned: Proofpoint Essentials engine Received: from webmail.solarflare.com (uk.solarflare.com [193.34.186.16]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1-us1.ppe-hosted.com (Proofpoint Essentials ESMTP Server) with ESMTPS id 98157B00055; Sat, 7 Apr 2018 08:28:01 +0000 (UTC) Received: from [192.168.38.17] (84.52.114.114) by ukex01.SolarFlarecom.com (10.17.10.4) with Microsoft SMTP Server (TLS) id 15.0.1044.25; Sat, 7 Apr 2018 09:27:53 +0100 To: Adrien Mazarguil , Thomas Monjalon , Ferruh Yigit , CC: Xueming Li , Wenzhuo Lu , Jingjing Wu , Beilei Xing , "Qi Zhang" , Konstantin Ananyev , Nelio Laranjeiro , Yongseok Koh , Pascal Mazon References: <20180404150312.12304-1-adrien.mazarguil@6wind.com> <20180406131736.19145-1-adrien.mazarguil@6wind.com> <20180406131736.19145-10-adrien.mazarguil@6wind.com> From: Andrew Rybchenko Message-ID: Date: Sat, 7 Apr 2018 11:27:49 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 MIME-Version: 1.0 In-Reply-To: <20180406131736.19145-10-adrien.mazarguil@6wind.com> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-GB X-Originating-IP: [84.52.114.114] X-ClientProxiedBy: ocex03.SolarFlarecom.com (10.20.40.36) To ukex01.SolarFlarecom.com (10.17.10.4) X-TM-AS-Product-Ver: SMEX-11.0.0.1191-8.100.1062-23768.003 X-TM-AS-Result: No--9.016200-0.000000-31 X-TM-AS-User-Approved-Sender: Yes X-TM-AS-User-Blocked-Sender: No X-MDID: 1523089685-TzLo+sYumi4T Subject: Re: [dpdk-dev] [PATCH v2 09/15] ethdev: add encap level to RSS flow API action X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 07 Apr 2018 08:28:06 -0000 On 04/06/2018 04:25 PM, Adrien Mazarguil wrote: > RSS hash types (ETH_RSS_* macros defined in rte_ethdev.h) describe the > protocol header fields of a packet that must be taken into account while > computing RSS. > > When facing encapsulated (e.g. tunneled) packets, there is an ambiguity as > to whether these should apply to inner or outer packets. Applications need > the ability to tell exactly "where" RSS must be performed. > > This is addressed by adding encapsulation level information to the RSS flow > action. Its default value is 0 and stands for the usual unspecified > behavior. Other values provide a specific encapsulation level. > > Contrary to the change announced by commit 676b605182a5 ("doc: announce > ethdev API change for RSS configuration"), this patch does not affect > struct rte_eth_rss_conf but struct rte_flow_action_rss as the former is not > used anymore by the RSS flow action. ABI impact is therefore limited to > rte_flow. > > This breaks ABI compatibility for the following public functions: > > - rte_flow_copy() > - rte_flow_create() > - rte_flow_query() > - rte_flow_validate() > > Signed-off-by: Adrien Mazarguil > Cc: Xueming Li > Cc: Ferruh Yigit > Cc: Thomas Monjalon > Cc: Wenzhuo Lu > Cc: Jingjing Wu > Cc: Beilei Xing > Cc: Qi Zhang > Cc: Konstantin Ananyev > Cc: Nelio Laranjeiro > Cc: Yongseok Koh > Cc: Andrew Rybchenko > Cc: Pascal Mazon > --- > app/test-pmd/cmdline_flow.c | 13 ++++++++++++ > app/test-pmd/config.c | 1 + > doc/guides/prog_guide/rte_flow.rst | 24 ++++++++++++++++++++++ > doc/guides/testpmd_app_ug/testpmd_funcs.rst | 2 ++ > drivers/net/e1000/igb_flow.c | 4 ++++ > drivers/net/e1000/igb_rxtx.c | 2 ++ > drivers/net/i40e/i40e_ethdev.c | 2 ++ > drivers/net/i40e/i40e_flow.c | 4 ++++ > drivers/net/ixgbe/ixgbe_flow.c | 4 ++++ > drivers/net/ixgbe/ixgbe_rxtx.c | 2 ++ > drivers/net/mlx4/mlx4_flow.c | 6 ++++++ > drivers/net/mlx5/mlx5_flow.c | 11 ++++++++++ > drivers/net/sfc/sfc_flow.c | 3 +++ > drivers/net/tap/tap_flow.c | 6 +++++- > lib/librte_ether/rte_flow.c | 1 + > lib/librte_ether/rte_flow.h | 26 ++++++++++++++++++++++++ > 16 files changed, 110 insertions(+), 1 deletion(-) Generic and sfc parts Acked-by: Andrew Rybchenko