From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
by inbox.dpdk.org (Postfix) with ESMTP id 2AE4AA04F6;
Wed, 11 Dec 2019 12:04:05 +0100 (CET)
Received: from [92.243.14.124] (localhost [127.0.0.1])
by dpdk.org (Postfix) with ESMTP id CFD182C6A;
Wed, 11 Dec 2019 12:04:04 +0100 (CET)
Received: from mail-wm1-f67.google.com (mail-wm1-f67.google.com
[209.85.128.67]) by dpdk.org (Postfix) with ESMTP id 841D11D9E
for <dev@dpdk.org>; Wed, 11 Dec 2019 12:04:03 +0100 (CET)
Received: by mail-wm1-f67.google.com with SMTP id f129so6509075wmf.2
for <dev@dpdk.org>; Wed, 11 Dec 2019 03:04:03 -0800 (PST)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20161025;
h=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to
:references:content-transfer-encoding:user-agent:mime-version;
bh=qTCoWDG2Wkpz0lwhHs94amyCId0uRk6Y4oWYgpccU10=;
b=NodY7H+9iOVopMHB45EYShWyM+xqiFiCRLH71wHNMSOzqGcg88EjO5nlpSW23LmLbM
6dmMNVHf44rwL2Cjmc8ElDnJAbKpcziJCkqQxRQhnLIHzHR4gF/vd4J/wasJ6KF0LsMg
E55g1esuPyr5/fsFNnFZqQC7/35JDx9F6bLECwNud/mK6wJo9STWyzJizszZRoJBXs0j
bkH6q2HsnktlhY6ZquBOz5njX3hyfenzhehwHNYEPEwQmfkezoqVKQOUK+uKNeBAO2e9
vtEoabPVl5+04zZyJeY6733MjL6MjimCCi5QuWg5vlCoryNxjIdMTDQAT2S3Cibv9xWl
s7jA==
X-Gm-Message-State: APjAAAUz41W/NmURAXRqxhwCacTw6TnxFPi9x9mv3wUrANQTAYehXjAw
lZPtcfkl5PFtwOOJMP7EeOdw1nxCngw=
X-Google-Smtp-Source: APXvYqwzdeSdApPTfZdoNgVisRwR+yFLTT5WpkV02UcDDfEiMzcVVxkMTVKPBWGcSLXPqqdo1S3qAw==
X-Received: by 2002:a7b:c936:: with SMTP id h22mr2805391wml.115.1576062243075;
Wed, 11 Dec 2019 03:04:03 -0800 (PST)
Received: from localhost ([88.98.246.218])
by smtp.gmail.com with ESMTPSA id i11sm1929799wrs.10.2019.12.11.03.04.01
(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
Wed, 11 Dec 2019 03:04:01 -0800 (PST)
Message-ID: <c2d7396452ab3b69da67893b45a0e45ce0237faf.camel@debian.org>
From: Luca Boccassi <bluca@debian.org>
To: Bruce Richardson <bruce.richardson@intel.com>, dev@dpdk.org
Cc: thomas@monjalon.net, ray.kinsella@intel.com, ferruh.yigit@intel.com
Date: Wed, 11 Dec 2019 11:04:01 +0000
In-Reply-To: <20191211102642.983579-1-bruce.richardson@intel.com>
References: <20191211102642.983579-1-bruce.richardson@intel.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.30.5-1.1
MIME-Version: 1.0
Subject: Re: [dpdk-dev] [PATCH] build: fix soname info for 19.11 compatiblity
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>
On Wed, 2019-12-11 at 10:26 +0000, Bruce Richardson wrote:
> The soname for each stable ABI version should be just the ABI version
> major
> number without the minor number. Unfortunately both major and minor
> were
> used causing version 20.1 to be incompatible with 20.0.
>=20
> This patch fixes the issue by switching from 2-part to 3-part ABI
> version
> numbers so that we can keep 20.0 as soname and using the final digits
> to
> identify the 20.x releases which are ABI compatible. This requires
> changes
> to both make and meson builds to handle the three-digit version and
> shrink
> it to 2-digit for soname.
>=20
> Fixes: cba806e07d6f ("build: change ABI versioning to global")
>=20
> Signed-off-by: Thomas Monjalon <
> thomas@monjalon.net
> >
> Signed-off-by: Bruce Richardson <
> bruce.richardson@intel.com
> >
> ---
>=20
> This patch contains an alternative fix to that implied by the
> previous patches:
> http://patches.dpdk.org/patch/63726/
>=20
> http://patches.dpdk.org/patch/63728/
>=20
>=20
> ---
> ABI_VERSION | 2 +-
> drivers/meson.build | 4 ++--
> lib/meson.build | 4 ++--
> mk/rte.lib.mk | 5 ++++-
> 4 files changed, 9 insertions(+), 6 deletions(-)
Acked-by: Luca Boccassi <bluca@debian.org>
Thank you! I've set a reminder in my calendar for September to revert
it :-)
--=20
Kind regards,
Luca Boccassi