From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.lysator.liu.se (mail.lysator.liu.se [130.236.254.3]) by dpdk.org (Postfix) with ESMTP id E7D471B295 for ; Wed, 3 Oct 2018 21:49:46 +0200 (CEST) Received: from mail.lysator.liu.se (localhost [127.0.0.1]) by mail.lysator.liu.se (Postfix) with ESMTP id 78D804007B for ; Wed, 3 Oct 2018 21:49:46 +0200 (CEST) Received: by mail.lysator.liu.se (Postfix, from userid 1004) id 61DCD4007A; Wed, 3 Oct 2018 21:49:46 +0200 (CEST) X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on bernadotte.lysator.liu.se X-Spam-Level: X-Spam-Status: No, score=-0.9 required=5.0 tests=ALL_TRUSTED,AWL autolearn=disabled version=3.4.1 X-Spam-Score: -0.9 Received: from [192.168.1.59] (host-90-232-60-155.mobileonline.telia.com [90.232.60.155]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.lysator.liu.se (Postfix) with ESMTPSA id 0CACD40072; Wed, 3 Oct 2018 21:49:44 +0200 (CEST) To: Thomas Monjalon , Kevin Laatz Cc: dev@dpdk.org, harry.van.haaren@intel.com, stephen@networkplumber.org, gaetan.rivet@6wind.com, shreyansh.jain@nxp.com, Ciara Power , Brian Archbold References: <1535026093-101872-1-git-send-email-ciara.power@intel.com> <20181003173612.67101-3-kevin.laatz@intel.com> <72e3e8d1-fa63-2531-a3c3-2d0c9ee5d151@ericsson.com> <4764579.GE1JWGAuKW@xps> From: =?UTF-8?Q?Mattias_R=c3=b6nnblom?= Message-ID: Date: Wed, 3 Oct 2018 21:49:43 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <4764579.GE1JWGAuKW@xps> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit X-Virus-Scanned: ClamAV using ClamSMTP Subject: Re: [dpdk-dev] [PATCH v2 02/10] telemetry: add initial connection socket X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 03 Oct 2018 19:49:47 -0000 On 2018-10-03 21:36, Thomas Monjalon wrote: > 03/10/2018 20:40, Mattias Rönnblom: >> On 2018-10-03 19:36, Kevin Laatz wrote: >>> +#define DEFAULT_DPDK_PATH "/var/run/.rte_telemetry" >>> + >> >> FHS 3.0 recommends "/run" over "/var/run". Maybe a more descriptive >> macro name would be in order, too. > > Kevin, you should use eal_get_runtime_dir(). > You may need to export this function as a public API. > You could also use the AF_UNIX abstract namespace. Convenient, as in you don't have to bother with directories and dangling files from crashed processes, but on the other hand it's Linux-specific and a little obscure.