From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7667AA0562; Tue, 4 May 2021 14:49:11 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id B475B40697; Tue, 4 May 2021 14:49:10 +0200 (CEST) Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by mails.dpdk.org (Postfix) with ESMTP id AD2DB40141; Tue, 4 May 2021 14:49:08 +0200 (CEST) IronPort-SDR: fdOKnxRfqwq1QuOzBxl0hI3FhmJGlEon9H8YI1V8twxXvCO5rQO7jcj2SGfKidJRFe3SGJ5jgv hFYiEbTZe31Q== X-IronPort-AV: E=McAfee;i="6200,9189,9973"; a="185104616" X-IronPort-AV: E=Sophos;i="5.82,272,1613462400"; d="scan'208";a="185104616" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 May 2021 05:49:07 -0700 IronPort-SDR: 13bvEPTk/ozjlbZexEuYqueahgXMYGPbm1AEfuSbuJQ0epdfPJu74oyfcDSFoon2b186nd1y8I OPknHTsy6d6A== X-IronPort-AV: E=Sophos;i="5.82,272,1613462400"; d="scan'208";a="433266848" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.213.243.109]) ([10.213.243.109]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 May 2021 05:49:05 -0700 To: hemant.agrawal@nxp.com, Thomas Monjalon Cc: dev@dpdk.org, stable@dpdk.org, stephen@networkplumber.org, longli@microsoft.com, Rosen Xu References: <20210429055548.12964-1-hemant.agrawal@nxp.com> <2996064.aO63oZZxRA@thomas> From: Ferruh Yigit X-User: ferruhy Message-ID: Date: Tue, 4 May 2021 13:49:02 +0100 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH] ethdev: add missing buses in dev iterator X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 4/29/2021 9:01 AM, Hemant Agrawal wrote: > > On 4/29/2021 1:26 PM, Thomas Monjalon wrote: >> 29/04/2021 07:55, Hemant Agrawal: >>> This patch fixes issue with OVS 2.15 not working on >>> DPAA/FSLMC based platform due to missing support for >>> these busses in dev_iterate. >>> This patch adds dpaa_bus and fslmc to dev iterator >>> for bus arguments. >> I think we should add VMBus as well. > They are 2 buses remaining vmbus and ifpga. However I don't know, if they use > args as vdev or as pci? cc Rosen for the 'ifpga' bus, 'vmbus' maintainer seems already cc'ed. This variable ('bus_param_key') is used to construct 'bus_str', and 'bus_str' seems used only for the '.dev_iterate' bus operation. Since 'ifpga' & 'vmbus' are not implementing the '.dev_iterate', so is it really required to add them?