From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7CC00A04DC; Mon, 26 Oct 2020 15:55:30 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 37D132BA2; Mon, 26 Oct 2020 15:55:03 +0100 (CET) Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by dpdk.org (Postfix) with ESMTP id 760362BA2 for ; Mon, 26 Oct 2020 15:55:01 +0100 (CET) IronPort-SDR: Pxj01HBvyejklhYjmW1cQI9+8Srbguwj65gFBUBoFSne1Xmu5xIaHatsi2eMT6F6MtwytgyUko 9Cepy+cXfIBw== X-IronPort-AV: E=McAfee;i="6000,8403,9785"; a="229566996" X-IronPort-AV: E=Sophos;i="5.77,420,1596524400"; d="scan'208";a="229566996" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Oct 2020 07:54:58 -0700 IronPort-SDR: dU+bv+5EmGYTv1xWxYfpvNchtbGpUhZiztT5NXjeSmGGo+X0Epzzxo3IyyJGvNikYyUCMtv7Zd eRxDAEe/BgSg== X-IronPort-AV: E=Sophos;i="5.77,420,1596524400"; d="scan'208";a="525523707" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.213.225.151]) ([10.213.225.151]) by fmsmga005-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Oct 2020 07:54:57 -0700 To: Jiawen Wu , dev@dpdk.org References: <20201019085415.82207-1-jiawenwu@trustnetic.com> <20201019085415.82207-57-jiawenwu@trustnetic.com> From: Ferruh Yigit Message-ID: Date: Mon, 26 Oct 2020 14:54:56 +0000 MIME-Version: 1.0 In-Reply-To: <20201019085415.82207-57-jiawenwu@trustnetic.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH v4 56/58] net/txgbe: add Rx and Tx descriptor status X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 10/19/2020 9:54 AM, Jiawen Wu wrote: > Supports check the status of Rx and Tx descriptors. > > Signed-off-by: Jiawen Wu <...> > @@ -480,6 +480,9 @@ eth_txgbe_dev_init(struct rte_eth_dev *eth_dev, void *init_params __rte_unused) > PMD_INIT_FUNC_TRACE(); > > eth_dev->dev_ops = &txgbe_eth_dev_ops; > + eth_dev->rx_queue_count = txgbe_dev_rx_queue_count; > + eth_dev->rx_descriptor_status = txgbe_dev_rx_descriptor_status; > + eth_dev->tx_descriptor_status = txgbe_dev_tx_descriptor_status; > eth_dev->rx_pkt_burst = &txgbe_recv_pkts; > eth_dev->tx_pkt_burst = &txgbe_xmit_pkts; > eth_dev->tx_pkt_prepare = &txgbe_prep_pkts; > @@ -4250,6 +4253,7 @@ static const struct eth_dev_ops txgbe_eth_dev_ops = { > .timesync_adjust_time = txgbe_timesync_adjust_time, > .timesync_read_time = txgbe_timesync_read_time, > .timesync_write_time = txgbe_timesync_write_time, > + .tx_done_cleanup = txgbe_dev_tx_done_cleanup, The '.tx_done_cleanup' is also added in this patch, can you please separate it to another patch? <...> > +int > +txgbe_dev_rx_descriptor_done(void *rx_queue, uint16_t offset) > +{ > + volatile struct txgbe_rx_desc *rxdp; > + struct txgbe_rx_queue *rxq = rx_queue; > + uint32_t desc; > + > + if (unlikely(offset >= rxq->nb_rx_desc)) > + return 0; > + desc = rxq->rx_tail + offset; > + if (desc >= rxq->nb_rx_desc) > + desc -= rxq->nb_rx_desc; > + > + rxdp = &rxq->rx_ring[desc]; > + return !!(rxdp->qw1.lo.status & > + rte_cpu_to_le_32(TXGBE_RXD_STAT_DD)); > +} 'descriptor_done' dev_ops is removed from this patch in this version, but the clutter seems remained, like above function and relevant function declerations etc.., can you please clean them all? dropping this patch form the patchset, because of the issues above. Can you please send new version as an icremental patch?