From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C634F41D30; Tue, 21 Feb 2023 16:58:26 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 6A4EE431EE; Tue, 21 Feb 2023 16:58:26 +0100 (CET) Received: from NAM10-MW2-obe.outbound.protection.outlook.com (mail-mw2nam10on2082.outbound.protection.outlook.com [40.107.94.82]) by mails.dpdk.org (Postfix) with ESMTP id CC78D40E0F for ; Tue, 21 Feb 2023 16:58:24 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Ji6J65wKIwDmYcHh0AjB1VZDssln4/nCxUqYVSjlBHFfdZxRR5tURCMlYkgRJ+J+PhgMynHKOBirmeUudgKMKZhJQPQauWdt1obm3R7K1nPjni1gM8VqyKlThg2T5xltUHNeaZjzkMAnvpmqJC6ujujO5BJif6m+OOLlRmrWdYbe8obOYRTLixaGNNddkqwHUbn3uOPWKDADNIhvRVOhh7dyMC/y3sZhEriqfgvG4sB5SwQNuhlaIMou3nOSde0DeDBIcUbK9aCdVG+IpPQM1L1sq1RI4Dgw9TkxsEK/OVPoZZD0jVy2bQwR0NoUha0fJ9/OBVRzTGBEOg7rQtMTAQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=sphLwVH1aunPfnkV1CEL46/rGHuokxnt+Y76/8OJxko=; b=nNNjgC4yDhyOSKsr1F0rE8knyI+lsbdcRxpKPt1fOSjAah40FI9Cwh+xTXnyQTl1N8h8tEkMrBCHAWBScs+ekxc6nd+OgGa18LcQbT5tIhJKmXkGdDhpWy9LDyi+fe1Wa3c1OvGXeGQNNKKutjGQUN2RUAbZinB9pQ3CAS3ioCeQL9hC+Uy6MUDzxnD5yXP+olXShPQWE9p9HUgdr9Fe4CCsRj0i+MXTpVoMgoKNa4DV+ndezUn7tkJMpd0xipaVoG9GZj8/BWAoOzJOJ1uKYtwbo107J6qv6rRoYX1nEiZQvN4Mrxmotgef+HjwPUiJuNO4eLZVjvYhQxN5k1Xyow== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=sphLwVH1aunPfnkV1CEL46/rGHuokxnt+Y76/8OJxko=; b=RwfKCkT6xSE51/y4HsvzxXjECpOFEq88ETSi91C6rAyl1Fapx2heApArWUaUQi9C8IovFdACR8HsFi2NB0sHzvV70uiyDcIfppmIeGj52fJDyND8MNod75yMAZZBq163LEtN6lNdsYAXjKisdJgDN+dSttOrhQglCtZ0r2rn5ws= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) by PH8PR12MB7301.namprd12.prod.outlook.com (2603:10b6:510:222::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6111.19; Tue, 21 Feb 2023 15:58:20 +0000 Received: from CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::3614:22ed:ed5:5b48]) by CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::3614:22ed:ed5:5b48%8]) with mapi id 15.20.6111.020; Tue, 21 Feb 2023 15:58:20 +0000 Message-ID: Date: Tue, 21 Feb 2023 15:58:14 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Content-Language: en-US To: Levend Sayar , junfeng.guo@intel.com Cc: dev@dpdk.org References: <20230221141350.12335-1-levendsayar@gmail.com> <20230221141814.13674-1-levendsayar@gmail.com> From: Ferruh Yigit Subject: Re: [PATCH v5] net/gve: add Rx/Tx queue stats as extended stats In-Reply-To: <20230221141814.13674-1-levendsayar@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO0P123CA0006.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:354::8) To CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB4294:EE_|PH8PR12MB7301:EE_ X-MS-Office365-Filtering-Correlation-Id: 97cf5e58-2797-4d72-6f99-08db14247405 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: cqevltdIbp+xQsy1nkLGn/BA6P5ILplP4Gq6Q8L3K/TH0LEBo3MKHrc7y0kPMhkEosdSwFMoOrgACz2Kp6hy/+dudiB3OAAciqJzktQA/NQ4IdFq9zOUX6iZRYPilVHz0i4xzZcvkh5gmfOKvyvR7UvBD3T5ghgYo5ZpfKWdQ7ikBmtv6z384Hyeu1mWZazgXf/DhoMMATn/x27sUAqZYQLqahyYV2jq7UwY8vj0ZUMfxckH4v8k4OYWHc25oGP8GdjX7hPbeMvsD+deqIXV3svWHcZhBnMa8m2SgSPqv7n8fY2wbiBcoAAnFnBxwLrJ5v7K1K+VBWEYdnP9RIfsB8F9biBYljptlfhZQYve/kYVnse/T93v5Dorl+ItpeJR8kcnLZ30HMsLzdT/5h06IfLa09aVIdUPu1sVBOQT6FRQaYYZc29xXW5qR6qhh6WskHntDB6vSRyO68hvjKMCxBqTNwcQq7mNm52GUCIsvyfW00WY9LP2wRC5WsIMX02EX1o8dL6Tbd+3ER1Bpn2Q3H2g6eKq9f8xGCyYN7UF66PuwLnVxoq8SNBHfqze+QFpg38q0XwqY2Fvy2Ujml+kPyaYhAnmO2lb+Vg1t5D0yjDx11eAr7dXFT6xAfJZYHS1f/zK8BC4hz8/oZtJYt7rZxV/VSc5bVQ3mSV4cSzuwYKCxf6/Uhz8Ud8jAJu4oVUmVDug+mLcT7U4JnzHsDL0fkidO+Qow+YK3wvedVpAr7s= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH2PR12MB4294.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230025)(4636009)(346002)(376002)(39860400002)(136003)(366004)(396003)(451199018)(478600001)(38100700002)(31696002)(86362001)(44832011)(2906002)(4744005)(316002)(41300700001)(5660300002)(6486002)(83380400001)(8676002)(66476007)(4326008)(66556008)(8936002)(66946007)(6506007)(6512007)(186003)(2616005)(53546011)(6666004)(36756003)(26005)(31686004)(43740500002)(45980500001); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ODA1Mk5GLzJiMHBxOWdTdVlkRDdLc3AwUmdOOXJJV3RNS05FTkNxcWpOUGda?= =?utf-8?B?MnFsaFlhcnBEVWdIVkFNWHJwUVZmYkx0K0lmS1g1TFUwUGN3dFBONXh3S055?= =?utf-8?B?a2ljWG9VOHhWVmp2b1B1WWVYN3QwcnJDRk00SCtjbzdUdnJWNDZRVUZsV1c3?= =?utf-8?B?dTBPL3kyRW9TWjFqeWFaUzdYS1F0UTVBU0hkWmhrUVRJSHVYMUJKeUJyMm9F?= =?utf-8?B?K2RtcGNXQXZOY0RtRUVOc1VubHFEaXp5aXgrQnBrOHJ3MGdaUkNxN01zbGxm?= =?utf-8?B?c05zM0lJbDV2YWlhTTlFUG5IWDZzVy9pRndweHdSY0ZPUjNBYXFKMlRjRzdt?= =?utf-8?B?YjBIdWJDaTFJa04wTjN0OE00SkQ4bjUvSnc4M0piUWg0TjZhL1ZqZ1lBcEFF?= =?utf-8?B?SjUrQThIb0h3SkJNRDViVzNObER6QTZKTVh5bEtrc2wyT04vaHU1WWlwcGVy?= =?utf-8?B?bTdHdHpsL3JMWGV0R1QrY3dXeWVOVDhXeGQ4R3FuUDF1bVViRW03Rm54cnJG?= =?utf-8?B?SEJVUUxqOVMycUM4VHhBcDgweiszQ1k2YkR5dVNqaHpxR0hQdjJOdmo5MHFZ?= =?utf-8?B?QzlLTUFDc0UwRE5UbkV4cm9ROVpPN0NraXMycGtUSHRpRUtEb3ZCRkZPNWJR?= =?utf-8?B?YU5CV2doTHFmdllxWms3NW1hcGtMUUxHMzhBUTluTXNoNCtWRGJEQlZhSks3?= =?utf-8?B?WDB4K1QxYWVrYlhqMmZhZVdGbVBWZERwRmFhOW1vUnNkajZHb0RKTXE2dWRt?= =?utf-8?B?TnY4dUYzRUl6V29IZ0hLMi9zeVpaa0FVWGMvcUxETUlKenI2L2pjZ2lvd1VW?= =?utf-8?B?RVVvbEJ5V2xnamY2RFhxaGd5SzVPL3dCMFgvU2hlaFZjQ3JQZU9pRjAxVTVB?= =?utf-8?B?K2lyM014ZlBBd1pYZTBSSlJYVU9nWnhZNlZiQXBYTDUzN2VLTFpJK1UxWHVi?= =?utf-8?B?M00vQ05uUnExbkFqZkcxdDMyVk5RWlNxRGlVakpZK2hhWXNvWmhJbHg2TC9T?= =?utf-8?B?SFc0Ujh5MURMaXpoMzRsNjZSWkJzSktiUC9sbFJNZkNBUHc5WW5RY0FhL0hq?= =?utf-8?B?YTgxMEZLMHZpTm5xUFdVU3hyRXh4OW1rSXoxaVB0SkhJVk5jTThKN0ZJVENs?= =?utf-8?B?U2dtUmcxYitzZ1ZtbnZucm5PV3Y3VDI5RWlBQ1NrTzVDSkxqZzJ1bkdSNnZu?= =?utf-8?B?MVRMbldSclhMTDJQN2JqNHlkaC80MHEyRUNlbEQ0ai9LdnZyYnNpVmhjdUNs?= =?utf-8?B?U3ZNcmhMOTBmK0k1djRxUmZHOGd4SGhIaVpWT0ZGL2lIODRsVnJwMHZhbmRW?= =?utf-8?B?eWhoSWJRNUtBOEVlSVFnaE1vSS9VeGZXcG5adjJZR2VZTE5LOC95UlpFbENv?= =?utf-8?B?RTh5S1FlZEtXNHF3TENRS0xJLzFsb0o0V1J0dGVsRmpBT3lQTFdxdXhUZWxz?= =?utf-8?B?bGxTejVvbEZQQks3RHM5OG1ZL1E0V2hkeFZFbkVLekFtRWkzazVLR1JLcXJT?= =?utf-8?B?ZTlDVnlqMXlLNkRSNjFZbm9Ga1R4N0hFbFd1TWVRSEVxR3FnTmU1T084ejYw?= =?utf-8?B?YVRPSWR6elFndlRxZTlVSUZGUVY3UG5Sd0VZN2JGSGJySit0bnUreDlVOGdB?= =?utf-8?B?eGU4THRQbm1aZUwzcjUvZjR3MlZmaENySThVc2d5b05IZGw1U3NVK3AvU21B?= =?utf-8?B?MGVKcTkxb2V0WmRRc1pleHJFQlpuRXJXZ3FVcWFXUndlWXNFMENER2JuKzR4?= =?utf-8?B?NTNSSFduNVN1MUZBMlNsMmdqcDRhRDhUdy9YVFlPa3phYmhMS0QrazlSTWkv?= =?utf-8?B?VXJyNkhNaGVLTDk3bTRWcHZDbVZzNmYxanp0bHdkK3Npdi9uRldydWhadjRC?= =?utf-8?B?VVQzeHpJWDBWZmo0Q0NSZG5jMUpSbWNmckNBMlB0MWh3c1p5amo0OVJMOE9Y?= =?utf-8?B?UXp3aXZRQi82b0xIdlJFeVo3WE1BalNJYnFTUHBVRndzamE2VjI1Yk90RzMw?= =?utf-8?B?U3F6NVVLMjQ5L3BjMHVwUDQyekdjOGp1LzJ2MDNORkVYbUZRSUd2bk1Uek11?= =?utf-8?B?dWtLVTVEd3IvSUNybjh2cTMyTUN4dUJyZWc0ZVd2R016TU1UTzVyb1lUSEg2?= =?utf-8?Q?L2QgCBbN7cErPg2/l2Fl3fiwI?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 97cf5e58-2797-4d72-6f99-08db14247405 X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB4294.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Feb 2023 15:58:20.4242 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: deXHBmmf3GDf2cwVf4/yci8EtDg4k5M1jO+srGLBZcxCJYN7leXh2oLzzqbxJZ57 X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH8PR12MB7301 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 2/21/2023 2:18 PM, Levend Sayar wrote: > Google Virtual NIC rx/tx queue stats are added as extended stats. > > Signed-off-by: Levend Sayar Reviewed-by: Ferruh Yigit <...> > @@ -20,6 +20,7 @@ gve_rx_refill(struct gve_rx_queue *rxq) > if (nb_alloc <= rxq->nb_avail) { > diag = rte_pktmbuf_alloc_bulk(rxq->mpool, &rxq->sw_ring[idx], nb_alloc); > if (diag < 0) { > + rxq->stats.no_mbufs_bulk++; It is not common to record bulk alloc failures, but as 'no_mbufs' already recorded conventionally, I guess it is OK to keep this extra stat if it is helpful.