From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9F3D2A034F; Tue, 23 Mar 2021 08:25:04 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 1836E4014D; Tue, 23 Mar 2021 08:25:04 +0100 (CET) Received: from shelob.oktetlabs.ru (shelob.oktetlabs.ru [91.220.146.113]) by mails.dpdk.org (Postfix) with ESMTP id B6AF240143 for ; Tue, 23 Mar 2021 08:25:02 +0100 (CET) Received: from [192.168.38.17] (aros.oktetlabs.ru [192.168.38.17]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by shelob.oktetlabs.ru (Postfix) with ESMTPSA id 408E57F4F8; Tue, 23 Mar 2021 10:25:02 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 shelob.oktetlabs.ru 408E57F4F8 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=oktetlabs.ru; s=default; t=1616484302; bh=+oMGwHPX4/6aVRI9Q/9B111r8a/HZzZbtS395ukOTnk=; h=Subject:To:Cc:References:From:Date:In-Reply-To; b=bFCf5wPU4S3UkXk3gSvfxcBQwIR9d/XvArJXNwF/8fcbgSp9JbmntDyzj7EVD69e0 NNCp4gUEHgH2PUH630IeKsxL3hv48bTJVj7BUV7Kht77c6q6uPmhHYCr4CbzSIfnaq ejDWZwaPr2y/K4S0XFfIqNcY2RtzQEo03wsI76rk= To: "Li, Xiaoyun" , Lijun Ou , "Yigit, Ferruh" , "Tu, Lijuan" Cc: "dev@dpdk.org" , "linuxarm@openeuler.org" References: <1614939741-63927-1-git-send-email-oulijun@huawei.com> <1614939741-63927-4-git-send-email-oulijun@huawei.com> From: Andrew Rybchenko Organization: OKTET Labs Message-ID: Date: Tue, 23 Mar 2021 10:25:02 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH 3/3] app/testpmd: use of Rx/Tx in testpmd X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 3/23/21 6:17 AM, Li, Xiaoyun wrote: > Hi > >> -----Original Message----- >> From: Lijun Ou >> Sent: Friday, March 5, 2021 18:22 >> To: Yigit, Ferruh >> Cc: Li, Xiaoyun ; dev@dpdk.org; >> linuxarm@openeuler.org >> Subject: [PATCH 3/3] app/testpmd: use of Rx/Tx in testpmd >> >> From: Hongbo Zheng >> >> In testpmd, when we input "show config rxtx", we can see like this: >> >> 1: testpmd> show config rxtx >> 2: io packet forwarding packets/burst=32 >> 3: nb forwarding cores=1 - nb forwarding ports=1 >> 4: port 0: RX queue number: 1 Tx queue number: 1 >> 5: Rx offloads=0x0 Tx offloads=0x10000 >> 6: RX queue: 0 >> 7: RX desc=1024 - RX free threshold=32 >> 8: RX threshold registers: pthresh=0 hthresh=0 wthresh=0 >> 9: RX Offloads=0x0 >> 10: TX queue: 0 >> 11: TX desc=1024 - TX free threshold=928 >> 12: TX threshold registers: pthresh=0 hthresh=0 wthresh=0 >> 13: TX offloads=0x10000 - TX RS bit threshold=32 >> >> We can see RX/Rx/TX/Tx is mixed used. Also in other places in testpmd, >> RX/Rx/TX/Tx is mixed used. >> >> This patch fix the mixed use of RX/Rx/TX/Tx in testpmd by change to >> unified use Rx/Tx. > > The commit log is too redundant. The following is enough to explain what this patch does: > RX/TX and Rx/Tx are mixed used in testpmd print and comments. This patch unifies them as Rx/Tx. > > Except this, the patch looks good to me. > > But one big concern, this patch will break all of the CI tests because the DTS scripts check if the results are the same as expected and this patch change a lot of the print. > So I think the DTS maintainer needs to be aware of this. I think test dpdk-testpmd output is a part of API. Of course, it is not an API, but such cosmetic changes in output will be much more painful than API changes. Output parsers will simply stop to work. I think such changes should go through the deprecation process. Of course, it would be useful to change comments and may be even error log messages right now, but not commands output. > > +Lijuan DTS maintainer > > And please separate this patch with the other twos. Don't mix them in one patchset. It's not for the same purpose. > >> >> Signed-off-by: Hongbo Zheng >> Signed-off-by: Lijun Ou >> --- >> V1->V2: >> - fix all RX/TX >> - rename patch title >> --- >> app/test-pmd/cmdline.c | 104 ++++++++++++++++++------------------ >> app/test-pmd/config.c | 128 ++++++++++++++++++++++----------------------- >> app/test-pmd/csumonly.c | 22 ++++---- >> app/test-pmd/icmpecho.c | 2 +- >> app/test-pmd/ieee1588fwd.c | 18 +++---- app/test-pmd/parameters.c >> | 50 +++++++++--------- >> app/test-pmd/testpmd.c | 120 +++++++++++++++++++++--------------------- >> app/test-pmd/testpmd.h | 28 +++++----- >> app/test-pmd/txonly.c | 2 +- >> 9 files changed, 237 insertions(+), 237 deletions(-) >> -- >> 2.7.4