From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-eopbgr60076.outbound.protection.outlook.com [40.107.6.76]) by dpdk.org (Postfix) with ESMTP id 6295C1B4E9 for ; Tue, 9 Oct 2018 14:52:09 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=wUoXHCofZiON2QWB55r7XjOjY7bstCni8xnrr2uGEdE=; b=fqC1X3vkmC1oKMp1M0jHJc0dqE52ciE2k4Es3mm2/grsa+uyU7BizL8amfoG/xKUNYXfgeIZLuYtqPpBiBc3mvGEAEVEMkyM1yaTFYtkmk21+hwWwbTrT5bS47alp4d6PKhQkBkWdmvlU9P3LxucsqjzK+uFwPhdoGYbMldN8zc= Received: from [10.232.134.144] (14.143.30.134) by VI1PR04MB4895.eurprd04.prod.outlook.com (2603:10a6:803:56::28) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1228.21; Tue, 9 Oct 2018 12:52:06 +0000 From: Akhil Goyal To: yoursunny Cc: Junxiao Shi , dev@dpdk.org References: <201810022008.w92K8B2r031185@lectura.cs.arizona.edu> <9e19271f-714f-514d-4d0f-096f553654f3@nxp.com> Message-ID: Date: Tue, 9 Oct 2018 18:21:50 +0530 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <9e19271f-714f-514d-4d0f-096f553654f3@nxp.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US X-Originating-IP: [14.143.30.134] X-ClientProxiedBy: BM1PR01CA0071.INDPRD01.PROD.OUTLOOK.COM (2603:1096:b00:1::11) To VI1PR04MB4895.eurprd04.prod.outlook.com (2603:10a6:803:56::28) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 4fa61dc0-6161-4a66-14ba-08d62de605b4 X-MS-Office365-Filtering-HT: Tenant X-Microsoft-Antispam: BCL:0; PCL:0; RULEID:(7020095)(4652040)(8989299)(4534185)(7168020)(4627221)(201703031133081)(201702281549075)(8990200)(5600074)(711020)(4618075)(2017052603328)(7153060)(7193020); SRVR:VI1PR04MB4895; X-Microsoft-Exchange-Diagnostics: 1; VI1PR04MB4895; 3:KsBMPkKBgaOF5Ef1on1Gh8+2lPZrKB1dfcrHaxRB/byc+xbsAKBom50kkj6z01aSSNJX5bLaCZoH4Xc5zXsXZpZM5EeNY2fpuQ0EjB45e9isL3DdSi4XZTuU3f91xIbfnQjVLCsX0T2Gqh4rjVIgdFN/0LiXfS0P/pyinil0eIj9XEG000uRztzQWpCw8uKnx7h7QiLzFcljkyReZU8P5GUMA7g5xDmHNebYC7CQa2XtWdlIdBf2K7syTLzPbD3K; 25:jePEPjVwn2XLj12QdIAV8JHVDSz6oFJ2q7sFa4Joi7i4feyPeVHuFoFsp8Xt2E31iDOobLM43lQhcmfvzy0VrJLDJnuqu/8Yy/2DrEJkxkVxL+upvKq4ThBio6r+Rjxss+B/+iM+kvd+lkrnhlrR4/OSwqy+MIzbUFWQoh7+6Dzf01eZP22hszye3dzskLKpUjAUex2gWJTK8HhRO3Li58gQUjGl3kLaLntupqnCJ2vvWRnTzYUcP6NUYUI2kXfpChGPL/MyvyBrXierAVz1u+4xisjYYCPnkO9xSTtGB9U8obiNgc59gb8kVev4oVnlJFk3/leK90b7YJSvid1byQ==; 31:fuQxtE+HxgplDeI8HHKEgNAyLCZ+9V7zcPiiLHDNvf2sDoGf83Jwy5nBR+FXjbKlakc5dnyB3ilGxFkDASaE77GB1eXeol8sI16aY6p96rbPp1JHuqwYQi/lFH7XGxjm1o7gf0JK0LnPpkTWrLMle8Ook5iw15xovb6K69U4S4R2O/9WkZB5W1UghSRKyaP41+4CY67Yap0vS8tDQxa3KvqaV+WlDtjb1NibOTJZi84= X-MS-TrafficTypeDiagnostic: VI1PR04MB4895: X-Microsoft-Exchange-Diagnostics: 1; VI1PR04MB4895; 20:V7T6VU5lMZ05rupkEUBSU3HAEDBMLJ2O549V/Ocryt9t+hGJXFQObXbMH78Wm3PPlcdoUSdqfFWCDJFgKMLQyFAOPrOohGhmqozjHUgJrhk0iqfdVw+EJsezBwjGVC+fOlcpn518rmzy1wHsdpFxEujgQxkJicdhI4ZEHjbgAZNgeGvmjx3Ws8LaPfUHP/8qUw3AqVKptN0uitbsCm2dhcylRe3xQxIvOhykBKTUxCp1jQfhYNlT16FErywFbbAwGjHvZ6qQFlL0WpItVSf21OJVCn6zNkkzln8mkV25HhH8cNyMEQEaxUrsEVexadJk5P2uAXIoRsTk1JxxcCQ+MlNGlDUgGOlgw0HDSlRuYN4PCqP1RrkRjFogfA92okUa4wgCmfAYkeDuAtBL+vbdlGcnhJoE54zWPhr20opnZE5qQA9HZTxvLTsFZAT6PXwV41oJASZ6eLpgcQPA4wf3bavUsFFLxfNhkaZC7gFNxH52dyPkChzCoyOSCKiI3ZeO; 4:EkAj141TFT/XONfjPfgwuDA1SVXDhds6Xu5GJ90leHyU0I1KEOQU4D/Htu/QUFb8435nm5bhaPlQhgTaS+EI491dzcLRLpS1/2mvOIVjdFgCmBn2fmSY+SOQ45U2X18kIq/oaTpP0iYOPxOYptZSpEzRIJrEFZ61lAoa8Jh6WDIdgU/+2B6BT5qiD05++EKKZ5EyCbUCI7e63yohIQlY/FPBOcLjNSmk+L8tlNi6EmalC5dc7am32QI50sGgE0anTAE8U7nGIAz7pS16kfGbkJIJXh3oiyUWFPo4Jzt3Rx7sfbCVNdGQb2BCt90DunQj X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(185117386973197); X-MS-Exchange-SenderADCheck: 1 X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(8121501046)(5005006)(3002001)(93006095)(93001095)(10201501046)(3231355)(944501410)(52105095)(6055026)(149066)(150057)(6041310)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123560045)(20161123564045)(20161123562045)(20161123558120)(201708071742011)(7699051)(76991055); SRVR:VI1PR04MB4895; BCL:0; PCL:0; RULEID:; SRVR:VI1PR04MB4895; X-Forefront-PRVS: 08200063E9 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(6049001)(39860400002)(376002)(366004)(346002)(396003)(136003)(189003)(199004)(65956001)(65806001)(105586002)(575784001)(66066001)(31696002)(97736004)(2906002)(53936002)(3846002)(6116002)(106356001)(86362001)(76176011)(305945005)(44832011)(478600001)(47776003)(1411001)(476003)(386003)(53546011)(486006)(316002)(52146003)(2486003)(23676004)(67846002)(36756003)(93886005)(52116002)(5009440100003)(55236004)(5660300001)(8676002)(81156014)(31686004)(81166006)(65826007)(4326008)(229853002)(39060400002)(6246003)(2870700001)(11346002)(8936002)(956004)(446003)(2616005)(16526019)(58126008)(50466002)(186003)(77096007)(16576012)(26005)(6346003)(7736002)(64126003)(68736007)(3260700006)(25786009)(6916009)(6666003)(6486002)(110426005); DIR:OUT; SFP:1101; SCL:1; SRVR:VI1PR04MB4895; H:[10.232.134.144]; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; Received-SPF: None (protection.outlook.com: nxp.com does not designate permitted sender hosts) Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=akhil.goyal@nxp.com; X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtWSTFQUjA0TUI0ODk1OzIzOjVKT0o4b1I4OWRrRXhLQndacUNqZFVxVEpr?= =?utf-8?B?bHF3RitTQnpjQTgvTDNWOTFKUFFhQXIwUDY3WWdPY29yYUNUTUY5cDdCUWlv?= =?utf-8?B?OGJIMjczYjlKYy9VaUhybmV1cWh0ZDhBNk9YN014NkVKakJUUmxwTWxwSTBt?= =?utf-8?B?SGp1TUhERklreUUzRjhmQ0JzVTQ4QkpRelNyOGJob3hockdQUkpqdHM4RU1k?= =?utf-8?B?MEExK3owN3lxWFpuRmlrcEpjeVBsOFJPTEUySHZEclV6enpRdG1leXpDZ256?= =?utf-8?B?R1hhV0x6eUtGeHFER2ZGdFRSRk5JMmwwRnhPNDBma2N4a3QrUGRja2R4SjZQ?= =?utf-8?B?YnZOQ2VKVHJkU3gyK3ZQdzJ5bW01b2xoNVorSGZURUY2RzBWeXhlaUUvUzNQ?= =?utf-8?B?RlYvZGFYcVJHckswV3FoRk5QK3Y2Q3VkbERLZ2YzL0pyVElSK2FQd3JRSEhD?= =?utf-8?B?RFFCNjdOSmtzVlpTdXJZMDJjV3g3TUVVWTd3TlVHVHNpWENhdWNYWDBBQnJ6?= =?utf-8?B?Y0htdThJcGZOUzNnaElBdUs0L29rUG80RDlIWUEyUVJiamFucG9tL2tGVTh0?= =?utf-8?B?Tys0WG5GZlJKL3hrbW5aUDlnOU9BejJ5YlBMZnF1NU02R0o5d0lrbENOQkp2?= =?utf-8?B?R2RpWVhQVmFZcnB5QVRScUE4VzlDTEZkOXZEa0J2dkczaUZEMmpPd2kvWjBs?= =?utf-8?B?enZRb3VsZk13R3hvaFpzZGNEZlZ5OTFJVzVnRlNoN3BIZy9nYnAxVWlNTWJl?= =?utf-8?B?b2FMNExteGM4QU1Ub2hlektuekNDU2ZBUzlhVWI0a0dNaHJLeEFSMUlLbnhN?= =?utf-8?B?Ym9uVlZycHRaM3Y0NURJNHp1YTM1UjFKQUthQmx1R0hYeTZneEVHcnhDMXpM?= =?utf-8?B?dHFCQ2ZjeWZvVU1nUkE2cmUxYUNNYmhRaWJEc2pvU2N1MExVeXlrRHh3Z0Ft?= =?utf-8?B?V0oyTnN6T0NwblFsRjB3K0dzdjFLcFZqMTFiV1NJUzRSTjNiMkFWYThwaFZk?= =?utf-8?B?RTViMW1yRVo3bC9ValdOWm9zcmUzcktITVFGYU5jQVlLeEhFak9SMDIwalFY?= =?utf-8?B?ZmpwRTZQNHN1S210cjFQU2p5bEFFdXZoSFo5UnhBUUlMVTRaa0dQRGpmNFNI?= =?utf-8?B?V0xzNXJOdC9Gc1ZuT1RGVDlnU0NHdXpkOE83UXR3SFluKytNL3BpRTU4UHJr?= =?utf-8?B?bUc3Y21PMEZoU3ZCQXQ0SEF5djBvSHpZRlg0UmJSbnN1MmMzaGFNZk82Syt5?= =?utf-8?B?VTFuY3ZiOXovSExML290YWhFVTJwMHdXMGxmUkNOemxNZ1JWUjFFVVIxQVBo?= =?utf-8?B?dkI0VXZzanR2THB1NWQ4RGJ3QUpqWnFoME1yWXRoTEVsQ2piWU5DUFR0Mk84?= =?utf-8?B?eUNVU1hjMnFGSW9ST2pCOU15c25BbDRGYUZSbzhoSmRNb2U5Yi8yZGpHRHZS?= =?utf-8?B?dk1KRHg2b2NkalpmRGdqb0J1TFFZZVh4MGVlTlpCNkZ5QjRUWGFEUUp2eVpl?= =?utf-8?B?cHJmUWlXejFaUzA1R3NFRTB6bFhZdGV0NEpTWVEzOU9IbUhvejUvaVNNUS8y?= =?utf-8?B?R1V3OURNREFyK3I3ZXJxZG54bVdtWFBiZXZpM09RckJmSWl6MVJWT1dnLyt3?= =?utf-8?B?eXAxNmVHaE1VWkYyemcwTDRvaEhqNGROT2ptQmZwd3F5SHZTVjFKaFBUZGtP?= =?utf-8?B?WmlicGtkMlpYMW9YdGdFMVRVeFdTdlNoL0R6TzVPNGMwOE5SakhTc0dFbllZ?= =?utf-8?B?MVdldzA0cWJCeFF3Smc0eW1WZEJCck0vWmtDVlNTSVlDMmtuMkNDV01wQlBn?= =?utf-8?B?NEtzR0hBYzB5RXBlT09oV0NCdVAzYm1pb3pPVnZJKzdxSnZhK0hhdnlIdXN1?= =?utf-8?B?emdPR3dLdlArYVJZRWpuK3lBNnNvQlB5d1RYbmFMLzFVbTM2cGlXc3VadS96?= =?utf-8?B?MDFPSlFUUmpQMGVWSko2RTJxSFhISEJlSkJYdTF0OFdVcTBBSm0vejczTEZr?= =?utf-8?B?amdKRGZ4bHAzSnR6T2EyaDJySzdyYzA4TEgwdVBsKzVnc2FpMlExRkZBSHhB?= =?utf-8?B?R2Q2TXRwZGgvSkJQOW5OK2lFSmRNMnkrVElSaWFGWnY0RGZGSU9LbFQ4dnl1?= =?utf-8?B?emIxaDV1Nk9UcnFHaGthUHliazJXU0pKWUdlenpHeFJHeGhnOUpGdjYveVVm?= =?utf-8?B?Y1M5ckI2UENCbGZaaFBpcXlMSFI5UkVSZjNUbmppK0lxWGY3R0VQWVBpN0JT?= =?utf-8?Q?tm506aaBsvkKkV+Qyk?= X-Microsoft-Antispam-Message-Info: XW2hf0k8wx23OksAi7+82DdOyEpYIXigQEyBb4pctIV98yrvVeNCpku4jaNE06T2Z9+8V7TeiPKcaJQInZzmm7zF3HnbiGb9mjPBq0lw8CCoh21DiwS6TBrB+xhDbpkoUnlT0FBtFNo2CDTo/Ui/6NWGdKraZxU9DPpk1Ngkfha17PFFP/uujQ3nhiFZTBi12n6I8fBcKA0J8523PP2UqrNcRDn2tUUyAiqaZKzsiVBCDALyHHb5xyP4B9Ty3P6MpBqT1y9ZoAyCGOjbkDvhyM1y//rK1qxJz203vx7GecGRNz9k+IjJrmgaCqHYlOmHrrlgEAHW0jjhw9GCksEvTs/F6h99vIDL5DJ7G0fnizg= X-Microsoft-Exchange-Diagnostics: 1; VI1PR04MB4895; 6:xFKFn34o1saIzKxfZjLMXjSHiGTmqaujS34R7Fs5/KwpAbXO6VcRdpgSw+Um18YSdYiDzC6jlBZNTXhQV1PjGedtdhynqssSfKVkGGs4PB44tF4dhNh9UpLzXQyFI5Dsb2RKFNWZr8las6pIyAs0fz2VGoTA2bFSBjUvI6o099ku5w49T7ODJ1p+RF086ejUMwjiYoVR12ef2UaduTbxghE6BkoEIlxHHzhnI/SBuT4RAyNzZ/NzkTTbIpVASaxtK/j07oM5CsRrPg28HCvfXOYa8KVdkihWzZ+jebOAVCuc8zu1gu+42pHLYTLD8pJelj0yqie4HEVxFdcF/KpxQ9cC5wBPjbO/9QeoHH1uxYNluwuWiPdq/fFzxFgS+j+vW8X6V9LiBKJ4MuBrWV1mVP8RZsJb7ziVxuahde86TV5MEeScLrzMzfK9e9WWKgtlWBo2wmAtfDkAFWfHBdaUNA==; 5:9P3pR5twIk1C3RFBIy9Xj0v050yIurC25f6usBgNYAb9iXu7Aj3AAVgMwxIIOwRKiDl2FOohCgYO7v56JULuGc6cRY/+SD4QLWxJaMgaqS6kK2J7Qwn/g0uAgxCApJnVpWhgxuJlYJWEN8ut+Wk8CF3fA/zs06K1widdouKFY7Y=; 7:SbQ2oe/P7RyPnw3nB6fsll1jD6oig4FDqvZEZlXprRwTfesoPCWB+Prm50sid0/z7SLvP59vUCRcW/rrbzup4F0zn3j4J9IO2W8kYUPVI4M3YGhyMVcA2N7r4dfLA0S6yS6sjmozsqrw8JFR7Ni+6Vssbwhw7eioX6kTTXAOBcp5RqcXODUzkdrY87LTkBYcLsrpaAGPAx8qHIyIL1pav2BUUYU5CAhxLj9nLOiBc2FwLRwn+7Rp2N9LKBg+Wodd SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Oct 2018 12:52:06.6579 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 4fa61dc0-6161-4a66-14ba-08d62de605b4 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB4895 Subject: Re: [dpdk-dev] [PATCH] crypto: recognize OP_TYPE_UNDEFINED in rte_crypto_op_pool_create X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 09 Oct 2018 12:52:09 -0000 Also change title to crypto: fix element size for undefined crypto op On 10/9/2018 4:41 PM, Akhil Goyal wrote: > > > On 10/9/2018 4:28 PM, yoursunny wrote: >> Hi Akhil >> >> The documentation of rte_crypto_op_pool_create indicates that _UNDEFINED >> creates a pool that supports both symmetric and assymetric crypto. This >> change makes the code consistent with documentation. >> >> Yours, Junxiao > Please add this information in the patch description and this should > be marked as a fix. > > Please also add > Fixes: c0f87eb5252b ("cryptodev: change burst API to be crypto op > oriented") > > and cc stable@dpdk.org >> On Tue, Oct 9, 2018 at 06:51 Akhil Goyal wrote: >> >>> Hi  Junxiao, >>> >>> On 10/3/2018 12:35 AM, Junxiao Shi wrote: >>>> Signed-off-by: Junxiao Shi >>>> --- >>>>    lib/librte_cryptodev/rte_cryptodev.c | 2 ++ >>>>    1 file changed, 2 insertions(+) >>>> >>>> diff --git a/lib/librte_cryptodev/rte_cryptodev.c >>> b/lib/librte_cryptodev/rte_cryptodev.c >>>> index 63ae23f..3d6f474 100644 >>>> --- a/lib/librte_cryptodev/rte_cryptodev.c >>>> +++ b/lib/librte_cryptodev/rte_cryptodev.c >>>> @@ -1477,6 +1477,8 @@ rte_crypto_op_pool_create(const char *name, enum >>> rte_crypto_op_type type, >>>>                elt_size += sizeof(struct rte_crypto_sym_op); >>>>        } else if (type == RTE_CRYPTO_OP_TYPE_ASYMMETRIC) { >>>>                elt_size += sizeof(struct rte_crypto_asym_op); >>>> +     } else if (type == RTE_CRYPTO_OP_TYPE_UNDEFINED) { >>>> +             elt_size += RTE_MAX(sizeof(struct rte_crypto_sym_op), >>> sizeof(struct rte_crypto_asym_op)); one more nit.. The line is beyond 80 characters. Before sending the patch you should run checkpatch script. >>>>        } else { >>>>                CDEV_LOG_ERR("Invalid op_type\n"); >>>>                return NULL; >>> Could you please explain the need for this change. If there is some >>> type >>> which is missing, we can add that. >>> defining the size of undefined op type does not make sense. >>> >>> -Akhil >>> >