From: Maxime Coquelin <maxime.coquelin@redhat.com>
To: Tom Rix <trix@redhat.com>,
dev@dpdk.org, akhil.goyal@nxp.com, nicolas.chautru@intel.com,
ferruh.yigit@intel.com
Subject: Re: [dpdk-dev] [PATCH 1/2] baseband/fpga_5gnr_fec: fix API naming
Date: Mon, 5 Oct 2020 09:28:06 +0200 [thread overview]
Message-ID: <c3ac79a1-9c56-91d0-c4d3-922b8672e091@redhat.com> (raw)
In-Reply-To: <4ba62928-0dd6-4d65-4882-d1eb6b21d4d4@redhat.com>
On 10/5/20 9:11 AM, Maxime Coquelin wrote:
>>> diff --git a/drivers/baseband/fpga_5gnr_fec/rte_pmd_fpga_5gnr_fec.h b/drivers/baseband/fpga_5gnr_fec/rte_pmd_fpga_5gnr_fec.h
>>> index 70a4acf0b7..c2752fbd52 100644
>>> --- a/drivers/baseband/fpga_5gnr_fec/rte_pmd_fpga_5gnr_fec.h
>>> +++ b/drivers/baseband/fpga_5gnr_fec/rte_pmd_fpga_5gnr_fec.h
>>> @@ -30,7 +30,7 @@ extern "C" {
>>> /**
>>> * Structure to pass FPGA 4G FEC configuration.
>> 4G ?
>>
>> There are a number of 4G references in this file's comments.
>>
>> Consider a future patch to clean this up.
> Agree, I noticed that.
> It has to be fixed in another series.
>
Another thing that we might consider fixing is the naming of the
drivers.
fpga_5gnr & fpga_lte are too generic, it should refer to an Intel
product/family.
Regards,
Maxime
next prev parent reply other threads:[~2020-10-05 7:28 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-02 8:59 [dpdk-dev] [PATCH 0/2] baseband: fix drivers API Maxime Coquelin
2020-10-02 8:59 ` [dpdk-dev] [PATCH 1/2] baseband/fpga_5gnr_fec: fix API naming Maxime Coquelin
2020-10-03 15:26 ` Tom Rix
2020-10-05 7:11 ` Maxime Coquelin
2020-10-05 7:28 ` Maxime Coquelin [this message]
2020-10-02 8:59 ` [dpdk-dev] [PATCH 2/2] baseband/fpga_lte_fec: " Maxime Coquelin
2020-10-03 15:31 ` Tom Rix
2020-10-06 19:42 ` [dpdk-dev] [PATCH 0/2] baseband: fix drivers API Akhil Goyal
2020-10-07 8:22 ` Maxime Coquelin
2020-10-07 10:09 ` Thomas Monjalon
2020-10-07 10:12 ` Maxime Coquelin
2020-10-07 10:29 ` Thomas Monjalon
2020-10-07 10:52 ` Maxime Coquelin
2020-10-07 11:06 ` Thomas Monjalon
2020-10-07 11:07 ` Thomas Monjalon
2020-10-07 12:05 ` Akhil Goyal
2020-10-07 12:19 ` Maxime Coquelin
2020-10-07 11:09 ` Maxime Coquelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c3ac79a1-9c56-91d0-c4d3-922b8672e091@redhat.com \
--to=maxime.coquelin@redhat.com \
--cc=akhil.goyal@nxp.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=nicolas.chautru@intel.com \
--cc=trix@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).