From: Akhil Goyal <akhil.goyal@nxp.com>
To: "Trahe, Fiona" <fiona.trahe@intel.com>, "dev@dpdk.org" <dev@dpdk.org>
Cc: "Jozwiak, TomaszX" <tomaszx.jozwiak@intel.com>
Subject: Re: [dpdk-dev] [PATCH v2] compress/qat: enable dynamic huffman encoding
Date: Fri, 12 Oct 2018 17:09:49 +0530 [thread overview]
Message-ID: <c3bc7031-7cd9-c020-3ace-0f6ab7e7debf@nxp.com> (raw)
In-Reply-To: <348A99DA5F5B7549AA880327E580B43589646AF8@IRSMSX101.ger.corp.intel.com>
On 10/9/2018 7:39 PM, Trahe, Fiona wrote:
> Hi Akhil,
>
>> -----Original Message-----
>> From: Akhil Goyal [mailto:akhil.goyal@nxp.com]
>> Sent: Tuesday, October 9, 2018 12:02 PM
>> To: Trahe, Fiona <fiona.trahe@intel.com>; dev@dpdk.org
>> Cc: Jozwiak, TomaszX <tomaszx.jozwiak@intel.com>
>> Subject: Re: [dpdk-dev] [PATCH v2] compress/qat: enable dynamic huffman encoding
>>
>>
>>
>> On 10/5/2018 9:48 PM, Fiona Trahe wrote:
>>> Enable dynamic huffman encoding in the QAT comp PMD.
>>>
>>> Signed-off-by: Tomasz Jozwiak <tomaszx.jozwiak@intel.com>
>>> Signed-off-by: Fiona Trahe <fiona.trahe@intel.com>
>>> ---
>>> v2 changes:
>>> - allocate 2 buffers per intermediate buffer sgl
>>> - Compile out trace for debugging intermediate buffers
>>>
>>> Depends on:
>>> https://patches.dpdk.org/patch/45794/
>>>
>> //snip
>>> +#if 1
>>> + QAT_LOG(DEBUG, " : phys addr of sgl[%i] in array_of_pointers"
>>> + "= %lx", i, array_of_pointers->pointer[i]);
>>> + QAT_LOG(DEBUG, " : virt address of sgl[%i] = %p", i, sgl);
>>> + QAT_LOG(DEBUG, " : sgl->buffers[0].addr = %lx, len=%d",
>>> + sgl->buffers[0].addr, sgl->buffers[0].len);
>>> + QAT_LOG(DEBUG, " : sgl->buffers[1].addr = %lx, len=%d",
>>> + sgl->buffers[1].addr, sgl->buffers[1].len);
>>> +#endif
>>> + }
>>> +#if 0
>>> + QAT_DP_HEXDUMP_LOG(DEBUG, "IM buffer memzone:", mz_start, 1504);
>>> +#endif
>> I believe #if 0 and #if 1 should be replaced with some debug macros, or
>> else dynamic logging shall take care of that.
> [Fiona] These are not on the data path, so I didn't think it appropriate to wrap with the DP log level compile option.
> And they generate a lot of trace, so make it impossible to see the other debug trace enabled with
> dynamic logging using level 8/DEBUG. Really a level 9 would be useful here, but I think this is overkill.
> I could have removed this code, but it's handy for debugging.
> How about if I add a local QAT define for it?
> #define QAT_IM_BUFFER_DEBUG 0
> #if QAT_IM_BUFFER_DEBUG
> ...
> #endif
I think local define would be better.
next prev parent reply other threads:[~2018-10-12 11:40 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-20 17:46 [dpdk-dev] [PATCH] " Fiona Trahe
2018-10-05 16:18 ` [dpdk-dev] [PATCH v2] " Fiona Trahe
2018-10-09 11:01 ` Akhil Goyal
2018-10-09 14:09 ` Trahe, Fiona
2018-10-12 11:39 ` Akhil Goyal [this message]
2018-10-11 17:03 ` [dpdk-dev] [PATCH v3] " Fiona Trahe
2018-10-15 23:16 ` [dpdk-dev] [PATCH v4] " Fiona Trahe
2018-10-17 10:29 ` Kusztal, ArkadiuszX
2018-10-17 20:48 ` [dpdk-dev] [PATCH v5] " Fiona Trahe
2018-10-24 14:15 ` Akhil Goyal
2018-10-24 21:30 ` Thomas Monjalon
2018-10-25 0:40 ` Trahe, Fiona
2018-10-25 6:45 ` Thomas Monjalon
2018-10-25 1:30 ` [dpdk-dev] [PATCH v6] " Fiona Trahe
2018-10-25 7:34 ` Akhil Goyal
2018-10-26 18:18 ` [dpdk-dev] [PATCH v7] " Fiona Trahe
2018-10-27 0:06 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c3bc7031-7cd9-c020-3ace-0f6ab7e7debf@nxp.com \
--to=akhil.goyal@nxp.com \
--cc=dev@dpdk.org \
--cc=fiona.trahe@intel.com \
--cc=tomaszx.jozwiak@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).