From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5739EA04DD; Thu, 22 Oct 2020 09:19:32 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 2D1FB678E; Thu, 22 Oct 2020 09:19:31 +0200 (CEST) Received: from dispatch1-us1.ppe-hosted.com (dispatch1-us1.ppe-hosted.com [148.163.129.52]) by dpdk.org (Postfix) with ESMTP id 7A511677E for <dev@dpdk.org>; Thu, 22 Oct 2020 09:19:28 +0200 (CEST) Received: from mx1-us1.ppe-hosted.com (unknown [10.7.65.61]) by dispatch1-us1.ppe-hosted.com (PPE Hosted ESMTP Server) with ESMTP id F1F6C60074; Thu, 22 Oct 2020 07:19:26 +0000 (UTC) Received: from us4-mdac16-68.ut7.mdlocal (unknown [10.7.64.187]) by mx1-us1.ppe-hosted.com (PPE Hosted ESMTP Server) with ESMTP id F093F8009E; Thu, 22 Oct 2020 07:19:26 +0000 (UTC) X-Virus-Scanned: Proofpoint Essentials engine Received: from mx1-us1.ppe-hosted.com (unknown [10.7.66.34]) by mx1-us1.ppe-hosted.com (PPE Hosted ESMTP Server) with ESMTPS id 5676480056; Thu, 22 Oct 2020 07:19:26 +0000 (UTC) Received: from webmail.solarflare.com (uk.solarflare.com [193.34.186.16]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by mx1-us1.ppe-hosted.com (PPE Hosted ESMTP Server) with ESMTPS id D82F4600067; Thu, 22 Oct 2020 07:19:25 +0000 (UTC) Received: from [192.168.38.17] (10.17.10.39) by ukex01.SolarFlarecom.com (10.17.10.4) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Thu, 22 Oct 2020 08:19:19 +0100 To: "Guo, Jia" <jia.guo@intel.com>, "Xing, Beilei" <beilei.xing@intel.com>, Thomas Monjalon <thomas@monjalon.net>, "Yigit, Ferruh" <ferruh.yigit@intel.com> CC: "dev@dpdk.org" <dev@dpdk.org> References: <1603030152-13451-1-git-send-email-arybchenko@solarflare.com> <1603030152-13451-3-git-send-email-arybchenko@solarflare.com> <c2fa31cca07f48a0a7340160ca151727@intel.com> <9f1b5be2-6e20-d130-8dff-c65d0563d51a@solarflare.com> <a31594921e01472798d0b536274f1995@intel.com> From: Andrew Rybchenko <arybchenko@solarflare.com> Message-ID: <c3e01c91-8329-8cca-9b2a-7e2291b69f0a@solarflare.com> Date: Thu, 22 Oct 2020 10:19:15 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.3.1 MIME-Version: 1.0 In-Reply-To: <a31594921e01472798d0b536274f1995@intel.com> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.17.10.39] X-ClientProxiedBy: ocex03.SolarFlarecom.com (10.20.40.36) To ukex01.SolarFlarecom.com (10.17.10.4) X-TM-AS-Product-Ver: SMEX-12.5.0.1300-8.6.1012-25740.003 X-TM-AS-Result: No-7.379900-8.000000-10 X-TMASE-MatchedRID: csPTYAMX1+HmLzc6AOD8DfHkpkyUphL9Ud7Bjfo+5jTVEYfep7SzppWi xnDxF7NQtqy4fGtVdQqTH1CW/TkdqkgMxOkBoMP0/ccgt/EtX/199ekRHlOQkTs61woVLQQE035 U7xRHgyHXX+bwWrzPa5nx1D8CeR1zaxas9gY03gP0VCHd+VQiHn5Lmbb/xUualzwjgd4NykvAEj NRW0WgIqwGbshKIlQIkZOl7WKIImrvXOvQVlExsFZ0V5tYhzdWxEHRux+uk8ifEzJ5hPndGfp3F GMEMlkpAlKBWdjWWEsTrrus1lgCazON1kx7zQ0TB8xlQrO4SbXsGDMfCwhnV1xLoAXGmQrREpJj z6ugs2p8i8DVdIW/2tQ17CngTb9OBKmZVgZCVnezGTWRXUlrxxtsJUxyzWNSVlxr1FJij9s= X-TM-AS-User-Approved-Sender: Yes X-TM-AS-User-Blocked-Sender: No X-TMASE-Result: 10--7.379900-8.000000 X-TMASE-Version: SMEX-12.5.0.1300-8.6.1012-25740.003 X-MDID: 1603351166-PUzSk_AWJ8G8 X-PPE-DISP: 1603351166;PUzSk_AWJ8G8 Subject: Re: [dpdk-dev] [PATCH 02/14] ethdev: move MAC filter type to i40e driver X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> On 10/22/20 5:58 AM, Guo, Jia wrote: > >> -----Original Message----- >> From: Andrew Rybchenko <arybchenko@solarflare.com> >> Sent: Thursday, October 22, 2020 12:09 AM >> To: Guo, Jia <jia.guo@intel.com>; Xing, Beilei <beilei.xing@intel.com>; >> Thomas Monjalon <thomas@monjalon.net>; Yigit, Ferruh >> <ferruh.yigit@intel.com>; Andrew Rybchenko >> <andrew.rybchenko@oktetlabs.ru> >> Cc: dev@dpdk.org >> Subject: Re: [PATCH 02/14] ethdev: move MAC filter type to i40e driver >> >> On 10/21/20 7:01 AM, Guo, Jia wrote: >>> >>>> -----Original Message----- >>>> From: Andrew Rybchenko <arybchenko@solarflare.com> >>>> Sent: Sunday, October 18, 2020 10:09 PM >>>> To: Xing, Beilei <beilei.xing@intel.com>; Guo, Jia >>>> <jia.guo@intel.com>; Thomas Monjalon <thomas@monjalon.net>; Yigit, >>>> Ferruh <ferruh.yigit@intel.com>; Andrew Rybchenko >>>> <andrew.rybchenko@oktetlabs.ru> >>>> Cc: dev@dpdk.org >>>> Subject: [PATCH 02/14] ethdev: move MAC filter type to i40e driver >>>> >>>> net/i40e driver is the only user of the enum rte_mac_filter_type. >>>> Move the define to the driver and use i40e_ prefix instead of rte_. >>>> >>>> Signed-off-by: Andrew Rybchenko <arybchenko@solarflare.com> >>>> --- >>>> drivers/net/i40e/i40e_ethdev.c | 58 ++++++++++++++++---------------- >>>> drivers/net/i40e/i40e_ethdev.h | 15 +++++++-- >>>> drivers/net/i40e/i40e_pf.c | 2 +- >>>> drivers/net/i40e/rte_pmd_i40e.c | 30 ++++++++--------- >>>> lib/librte_ethdev/rte_eth_ctrl.h | 11 ------ >>>> 5 files changed, 58 insertions(+), 58 deletions(-) >>>> >>> >>> Where is the related remove in testpmd about the rte_mac_filter_type? >> >> There is no rte_mac_filter_type in testpmd. >> Corresponding filter support is removed in the previous patch including >> testpmd. > > Oh, seems that there is some overlap between MACVLAN and MAC filter patch, I am not sure if this is a good suggestion that decouple this two testpmd usage or > just merge this two patch into one patch, basically flow that one patch involve the removing of the function and corresponding usage. > It is just inconsistency in terminology in legacy filter API. MAC filter type is flavor of MACVLAN.