[dpdk-dev] [PATCH v2 0/2] qede: 2020-02 minor fixes

[dpdk-dev] [PATCH v2 0/2] qede: 2020-02 minor fixes

[Igor Russkikh]

Two small fixes after customer feedback.

v2: improved abit log message

Igor Russkikh (2):
  qede: reduce trace verbosity level
  qede: make driver accept bigger rss tables

 drivers/net/qede/base/ecore_int.c | 2 +-
 drivers/net/qede/qede_ethdev.c    | 6 ++++--
 2 files changed, 5 insertions(+), 3 deletions(-)

-- 
2.25.1

[dpdk-dev] [PATCH v2 1/2] qede: reduce trace verbosity level

[Igor Russkikh]

On some hardware units it was found this trace is flooding the output,
making any dpdk interactive usage kind of problematic.

It is only informational, without any consequences handling, so reducing
it to verbose from explicit notice level.

CC: stable@dpdk.org
Acked-by: Devendra Singh Rawat <dsinghrawat@marvell.com>
Signed-off-by: Igor Russkikh <irusskikh@marvell.com>
---
 drivers/net/qede/base/ecore_int.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/qede/base/ecore_int.c b/drivers/net/qede/base/ecore_int.c
index 4207b1853..2c4aac941 100644
--- a/drivers/net/qede/base/ecore_int.c
+++ b/drivers/net/qede/base/ecore_int.c
@@ -928,7 +928,7 @@ static void ecore_int_attn_print(struct ecore_hwfn *p_hwfn,
 				 bool b_clear)
 {
 	/* @DPDK */
-	DP_NOTICE(p_hwfn->p_dev, false, "[block_id %d type %d]\n", id, type);
+	DP_VERBOSE(p_hwfn, ECORE_MSG_INTR, "[block_id %d type %d]\n", id, type);
 }
 
 /**
-- 
2.25.1

[dpdk-dev] [PATCH v2 2/2] qede: make driver accept bigger rss tables

[Igor Russkikh]

We found some dpdk applications blindly pass fixed side rss hash tables,
and do not check driver/device capabilities.

Moreover, many other drivers do not do such a strong check as well.

So here we fix it, making qede accept any size rss_key. For larger key
tables we just crop it with notice trace message.

CC: stable@dpdk.org
Signed-off-by: Igor Russkikh <irusskikh@marvell.com>
---
 drivers/net/qede/qede_ethdev.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/drivers/net/qede/qede_ethdev.c b/drivers/net/qede/qede_ethdev.c
index ab5f5b106..bfd38a977 100644
--- a/drivers/net/qede/qede_ethdev.c
+++ b/drivers/net/qede/qede_ethdev.c
@@ -2139,8 +2139,10 @@ int qede_rss_hash_update(struct rte_eth_dev *eth_dev,
 		/* RSS hash key */
 		if (key) {
 			if (len > (ECORE_RSS_KEY_SIZE * sizeof(uint32_t))) {
-				DP_ERR(edev, "RSS key length exceeds limit\n");
-				return -EINVAL;
+				len = ECORE_RSS_KEY_SIZE * sizeof(uint32_t);
+				DP_NOTICE(edev, false,
+					  "RSS key length too big, trimmed to %d\n",
+					  len);
 			}
 			DP_INFO(edev, "Applying user supplied hash key\n");
 			rss_params.update_rss_key = 1;
-- 
2.25.1

Re: [dpdk-dev] [PATCH v2 2/2] qede: make driver accept bigger rss tables

[Jerin Jacob]

On Fri, Mar 19, 2021 at 3:17 PM Igor Russkikh <irusskikh@marvell.com> wrote:
>
> We found some dpdk applications blindly pass fixed side rss hash tables,

Could you rewrite the git commit by removing "We".

> and do not check driver/device capabilities.
>
> Moreover, many other drivers do not do such a strong check as well.
>
> So here we fix it, making qede accept any size rss_key. For larger key

Could you rewrite the git commit by removing "we".

> tables we just crop it with notice trace message.
>
> CC: stable@dpdk.org
> Signed-off-by: Igor Russkikh <irusskikh@marvell.com>

Waiting for Ack to merge this.


> ---
>  drivers/net/qede/qede_ethdev.c | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/qede/qede_ethdev.c b/drivers/net/qede/qede_ethdev.c
> index ab5f5b106..bfd38a977 100644
> --- a/drivers/net/qede/qede_ethdev.c
> +++ b/drivers/net/qede/qede_ethdev.c
> @@ -2139,8 +2139,10 @@ int qede_rss_hash_update(struct rte_eth_dev *eth_dev,
>                 /* RSS hash key */
>                 if (key) {
>                         if (len > (ECORE_RSS_KEY_SIZE * sizeof(uint32_t))) {
> -                               DP_ERR(edev, "RSS key length exceeds limit\n");
> -                               return -EINVAL;
> +                               len = ECORE_RSS_KEY_SIZE * sizeof(uint32_t);
> +                               DP_NOTICE(edev, false,
> +                                         "RSS key length too big, trimmed to %d\n",
> +                                         len);
>                         }
>                         DP_INFO(edev, "Applying user supplied hash key\n");
>                         rss_params.update_rss_key = 1;
> --
> 2.25.1
>

Re: [dpdk-dev] [PATCH v2 0/2] qede: 2020-02 minor fixes

[Rasesh Mody]

> From: Igor Russkikh <irusskikh@marvell.com>
> Sent: Friday, March 19, 2021 3:17 PM
> 
> Two small fixes after customer feedback.
> 
> v2: improved abit log message
> 
> Igor Russkikh (2):
>   qede: reduce trace verbosity level
>   qede: make driver accept bigger rss tables
> 
>  drivers/net/qede/base/ecore_int.c | 2 +-
>  drivers/net/qede/qede_ethdev.c    | 6 ++++--
>  2 files changed, 5 insertions(+), 3 deletions(-)
> 
> --
> 2.25.1

For the series,

Acked-by: Rasesh Mody <rmody@marvell.com>
 
Thanks,
Rasesh

Re: [dpdk-dev] [PATCH v2 0/2] qede: 2020-02 minor fixes

[Devendra Singh Rawat]

> -----Original Message-----
> From: Igor Russkikh <irusskikh@marvell.com>
> Sent: Friday, March 19, 2021 3:17 PM
> To: dev@dpdk.org
> Cc: Rasesh Mody <rmody@marvell.com>; Devendra Singh Rawat
> <dsinghrawat@marvell.com>; Igor Russkikh <irusskikh@marvell.com>
> Subject: [PATCH v2 0/2] qede: 2020-02 minor fixes
> 
> Two small fixes after customer feedback.
> 
> v2: improved abit log message
> 
> Igor Russkikh (2):
>   qede: reduce trace verbosity level
>   qede: make driver accept bigger rss tables
> 
>  drivers/net/qede/base/ecore_int.c | 2 +-
>  drivers/net/qede/qede_ethdev.c    | 6 ++++--
>  2 files changed, 5 insertions(+), 3 deletions(-)
> 
> --
> 2.25.1

Patch Series ACKed,
Acked-by: Devendra Singh Rawat <dsinghrawat@marvell.com>

Thanks,
Devendra

Re: [dpdk-dev] [PATCH v2 0/2] qede: 2020-02 minor fixes

[Jerin Jacob]

On Mon, Mar 22, 2021 at 10:56 AM Devendra Singh Rawat
<dsinghrawat@marvell.com> wrote:
>
>
>
> > -----Original Message-----
> > From: Igor Russkikh <irusskikh@marvell.com>
> > Sent: Friday, March 19, 2021 3:17 PM
> > To: dev@dpdk.org
> > Cc: Rasesh Mody <rmody@marvell.com>; Devendra Singh Rawat
> > <dsinghrawat@marvell.com>; Igor Russkikh <irusskikh@marvell.com>
> > Subject: [PATCH v2 0/2] qede: 2020-02 minor fixes
> >
> > Two small fixes after customer feedback.
> >
> > v2: improved abit log message
> >
> > Igor Russkikh (2):
> >   qede: reduce trace verbosity level
> >   qede: make driver accept bigger rss tables
> >
> >  drivers/net/qede/base/ecore_int.c | 2 +-
> >  drivers/net/qede/qede_ethdev.c    | 6 ++++--
> >  2 files changed, 5 insertions(+), 3 deletions(-)
> >
> > --
> > 2.25.1
>
> Patch Series ACKed,
> Acked-by: Devendra Singh Rawat <dsinghrawat@marvell.com>

Fixed the check-git-log.sh issues and Applied to
dpdk-next-net-mrvl/for-main. Thanks


>
> Thanks,
> Devendra

Re: [dpdk-dev] [EXT] Re: [PATCH v2 0/2] qede: 2020-02 minor fixes

[Igor Russkikh]

>> Patch Series ACKed,
>> Acked-by: Devendra Singh Rawat <dsinghrawat@marvell.com>
> 
> Fixed the check-git-log.sh issues and Applied to
> dpdk-next-net-mrvl/for-main. Thanks

Thanks, Jerin, for taking care of that!

Igor