From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 54C29A04E7; Mon, 2 Nov 2020 18:22:08 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id C3E0D2BFE; Mon, 2 Nov 2020 18:22:06 +0100 (CET) Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by dpdk.org (Postfix) with ESMTP id D1F391E2B; Mon, 2 Nov 2020 18:22:03 +0100 (CET) IronPort-SDR: Yk9xJl/FF4gdWig31+8DxTQFrtpwX1/rbvKCkP4JwM8g5rIf/WGCU7IV2W7RqjKr3Q/xoT2Lca aeZxAzdGA0Fg== X-IronPort-AV: E=McAfee;i="6000,8403,9793"; a="156699111" X-IronPort-AV: E=Sophos;i="5.77,445,1596524400"; d="scan'208";a="156699111" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Nov 2020 09:22:01 -0800 IronPort-SDR: wmp2xUGWiHUdUaIfzICDa87T/0SbZhrloTyeqhS7EHeJST6nFha7WnpETUuOMF2UhQ3wMuis3i M9aWh7P0v2XA== X-IronPort-AV: E=Sophos;i="5.77,445,1596524400"; d="scan'208";a="470451663" Received: from vmedvedk-mobl.ger.corp.intel.com (HELO [10.252.22.151]) ([10.252.22.151]) by orsmga004-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Nov 2020 09:21:59 -0800 To: Dharmik Thakkar , Bruce Richardson Cc: Honnappa Nagarahalli , Ruifeng Wang , Gavin Hu , dev , nd , dpdk stable References: <20201029153634.10647-1-dharmik.thakkar@arm.com> <20201102151157.GD1454@bricha3-MOBL.ger.corp.intel.com> <6F792248-5555-4831-AFA3-9D839770B37D@arm.com> From: "Medvedkin, Vladimir" Message-ID: Date: Mon, 2 Nov 2020 17:21:57 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.3.3 MIME-Version: 1.0 In-Reply-To: <6F792248-5555-4831-AFA3-9D839770B37D@arm.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH 1/4] test/lpm: fix cycle calculation in rcu qsbr perf X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Dharmik, On 02/11/2020 16:58, Dharmik Thakkar wrote: > >> On Nov 2, 2020, at 9:11 AM, Bruce Richardson wrote: >> >> On Thu, Oct 29, 2020 at 10:36:31AM -0500, Dharmik Thakkar wrote: >>> Fix incorrect calculations for LPM adds, LPM deletes, >>> and average cycles in RCU QSBR perf tests >>> >> >> To help review this patch, could you provide some more details in the >> commit log as to what exactly was wrong with the calculation and how this >> patch fixes things? >> > > I will update the commit message in the next version. Adding it here as well: > > Since, rcu qsbr tests run for ‘RCU_ITERATIONS’ and not ‘ITERATIONS’, > replace ‘ITERATIONS’ with ‘RCU_ITERATIONS’ for calculating adds, deletes, and cycles. > > Also, for multi-writer perf test, each writer only writes half of NUM_LDEPTH_ROUTE_ENTRIES. > For 2 writers, total adds (or deletes) should be (RCU_ITERATIONS * NUM_LDEPTH_ROUTE_ENTRIES) instead of > (2 * RCU_ITERATIONS * NUM_LDEPTH_ROUTE_ENTRIES). > > Since, for both the single and multi writer tests, total adds/deletes is equal to (RCU_ITERATIONS * NUM_LDEPTH_ROUTE_ENTRIES), > this has been replaced with a macro ’TOTAL_WRITES’ and furthermore, ‘g_writes’ has been removed since it is always a fixed value > equal to TOTAL_WRITES. > Thanks for the clarification. I left a few comments regarding 4-th patch. First 3 patches LGTM, just put more details in the commit message. >>> Fixes: eff30b59cc2e ("test/lpm: add RCU performance tests") >>> Cc: honnappa.nagarahalli@arm.com >>> Cc: stable@dpdk.org >>> >>> Signed-off-by: Dharmik Thakkar >>> Reviewed-by: Ruifeng Wang > -- Regards, Vladimir