From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id DA312A0524; Tue, 20 Apr 2021 11:35:32 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A17B9412B0; Tue, 20 Apr 2021 11:35:32 +0200 (CEST) Received: from shelob.oktetlabs.ru (shelob.oktetlabs.ru [91.220.146.113]) by mails.dpdk.org (Postfix) with ESMTP id 872EB411A5 for ; Tue, 20 Apr 2021 11:35:31 +0200 (CEST) Received: from [192.168.38.17] (aros.oktetlabs.ru [192.168.38.17]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by shelob.oktetlabs.ru (Postfix) with ESMTPSA id 324F17F51B; Tue, 20 Apr 2021 12:35:31 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 shelob.oktetlabs.ru 324F17F51B DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=oktetlabs.ru; s=default; t=1618911331; bh=Q33UO6nC5QvrkCVpj+AjiYgC0blOYLxDxpuI9AunkSk=; h=Subject:To:Cc:References:From:Date:In-Reply-To; b=xr3mHidNpHBF64K/rF/wOBBul/fMDJcyDd3AqGdevicz/wgCyIymRkbVqjSK2LND+ rUX/8MWei4p8QfTGaOqPjOolHbuLV08Asw8wDPeb2tbjCyT2TrxxfvWQhipXNABaSc 6qdHGG1YVb60/3ETXXTdBC9QEJPZ6uemPdg9ihCI= To: "Min Hu (Connor)" , dev@dpdk.org Cc: ferruh.yigit@intel.com, cristian.dumitrescu@intel.com, jerinj@marvell.com, jianjay.zhou@huawei.com, jia.guo@intel.com, g.singh@nxp.com, hemant.agrawal@nxp.com, orika@nvidia.com References: <1618839289-33224-1-git-send-email-humin29@huawei.com> <1618839289-33224-4-git-send-email-humin29@huawei.com> From: Andrew Rybchenko Organization: OKTET Labs Message-ID: Date: Tue, 20 Apr 2021 12:35:31 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.9.0 MIME-Version: 1.0 In-Reply-To: <1618839289-33224-4-git-send-email-humin29@huawei.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH 03/10] bus/dpaa: fix management command init calling X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 4/19/21 4:34 PM, Min Hu (Connor) wrote: > 'bm_mc_init' only return 0, but the function whicl calls int > check the negative ret, and this is redundant. > > This patch fixed it by not checking the return value. > > Fixes: f38f61e982f8 ("bus/dpaa: add BMAN hardware interfaces") > Cc: stable@dpdk.org > > Signed-off-by: Min Hu (Connor) > --- > drivers/bus/dpaa/base/qbman/bman.c | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) > > diff --git a/drivers/bus/dpaa/base/qbman/bman.c b/drivers/bus/dpaa/base/qbman/bman.c > index 8a62907..e1ba2a8 100644 > --- a/drivers/bus/dpaa/base/qbman/bman.c > +++ b/drivers/bus/dpaa/base/qbman/bman.c > @@ -70,10 +70,8 @@ struct bman_portal *bman_create_portal(struct bman_portal *portal, > pr_err("Bman RCR initialisation failed\n"); > return NULL; > } > - if (bm_mc_init(p)) { > - pr_err("Bman MC initialisation failed\n"); > - goto fail_mc; > - } > + (void)bm_mc_init(p); > + As I understand compiler can do it for you and there is no point to break the code in the case of future changes if bm_mc_init() starts to return errors. > portal->pools = kmalloc(2 * sizeof(*pools), GFP_KERNEL); > if (!portal->pools) > goto fail_pools; >