From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id EE736A09E4; Thu, 28 Jan 2021 10:26:43 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id DB8F51889F8; Thu, 28 Jan 2021 10:26:43 +0100 (CET) Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by mails.dpdk.org (Postfix) with ESMTP id 1645F40395; Thu, 28 Jan 2021 10:26:41 +0100 (CET) IronPort-SDR: OJWtOyHQT+wVCvAznUAPS1HfakBA97tzmsLlPykH7GffljoEqJcd3dzMK7Q6g0OiZHDLZyGBEz Xi9ZW4T05TAA== X-IronPort-AV: E=McAfee;i="6000,8403,9877"; a="180349144" X-IronPort-AV: E=Sophos;i="5.79,382,1602572400"; d="scan'208";a="180349144" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Jan 2021 01:26:40 -0800 IronPort-SDR: 75AHu7flHnryVgGheD2NBXmtCjyx5+xyZwEuY7L40qm6JHVJZN5PEsK88va4DrS97n6dQiIAp0 koQVtKxYMyfQ== X-IronPort-AV: E=Sophos;i="5.79,382,1602572400"; d="scan'208";a="388731808" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.213.197.127]) ([10.213.197.127]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Jan 2021 01:26:37 -0800 To: Wisam Monther , Wenzhuo Lu , Xiaoyun Li , Bernard Iremonger , Steve Yang Cc: "dev@dpdk.org" , "stable@dpdk.org" , "lance.richardson@broadcom.com" , "oulijun@huawei.com" , "lihuisong@huawei.com" References: <20210125083202.38267-1-stevex.yang@intel.com> <20210125181548.2713326-1-ferruh.yigit@intel.com> From: Ferruh Yigit Message-ID: Date: Thu, 28 Jan 2021 09:26:33 +0000 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH v5] app/testpmd: fix setting maximum packet length X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 1/28/2021 9:18 AM, Wisam Monther wrote: > Hi Ferruh, > > >> -----Original Message----- >> From: Ferruh Yigit >> Sent: Monday, January 25, 2021 8:16 PM >> To: Wenzhuo Lu ; Xiaoyun Li >> ; Bernard Iremonger >> ; Steve Yang >> Cc: Ferruh Yigit ; dev@dpdk.org; stable@dpdk.org; >> lance.richardson@broadcom.com; oulijun@huawei.com; Wisam Monther >> ; lihuisong@huawei.com >> Subject: [PATCH v5] app/testpmd: fix setting maximum packet length >> >> From: Steve Yang >> >> "port config all max-pkt-len" command fails because it doesn't set the >> 'DEV_RX_OFFLOAD_JUMBO_FRAME' offload flag properly. >> >> Commit in the fixes line moved the 'DEV_RX_OFFLOAD_JUMBO_FRAME' >> offload flag update from 'cmd_config_max_pkt_len_parsed()' to >> 'init_config()'. >> 'init_config()' function is only called during testpmd startup, but the flag >> status needs to be calculated whenever 'max_rx_pkt_len' changes. >> >> The issue can be reproduce as [1], where the 'max-pkt-len' reduced and >> 'DEV_RX_OFFLOAD_JUMBO_FRAME' offload flag should be cleared but it >> didn't. >> >> Adding the 'update_jumbo_frame_offload()' helper function to update >> 'DEV_RX_OFFLOAD_JUMBO_FRAME' offload flag and 'max_rx_pkt_len'. This >> function is called both by 'init_config()' and >> 'cmd_config_max_pkt_len_parsed()'. >> >> Default 'max-pkt-len' value set to zero, 'update_jumbo_frame_offload()' >> updates it to "RTE_ETHER_MTU + PMD specific Ethernet overhead" when it is >> zero. >> If '--max-pkt-len=N' argument provided, it will be used instead. >> And with each "port config all max-pkt-len" command, the >> 'DEV_RX_OFFLOAD_JUMBO_FRAME' offload flag, 'max-pkt-len' and MTU is >> updated. >> >> [1] >> -------------------------------------------------------------------------- >> dpdk-testpmd -c 0xf -n 4 -- -i --max-pkt-len=9000 --tx-offloads=0x8000 >> --rxq=4 --txq=4 --disable-rss >> testpmd> set verbose 3 >> testpmd> port stop all >> testpmd> port config all max-pkt-len 1518 port start all >> >> // Got fail error info without this patch Configuring Port 0 (socket 1) Ethdev >> port_id=0 rx_queue_id=0, new added offloads 0x800 must be within per- >> queue offload capabilities 0x0 in rte_eth_rx_queue_setup() Fail to configure >> port 0 rx queues //<-- Fail error info; >> -------------------------------------------------------------------------- >> >> Fixes: 761c4d66900f ("app/testpmd: fix max Rx packet length for VLAN >> packets") >> Cc: stable@dpdk.org >> >> Signed-off-by: Steve Yang >> Signed-off-by: Ferruh Yigit >> --- >> >> v5: >> * 'update_jumbo_frame_offload()' helper updated >> * check zero 'max-pkt-len' value >> * Update how queue offload flags updated >> * Update MTU if JUMBO_FRAME flag is not set >> * Default testpmd 'max-pkt-len' value set to zero >> >> Cc: lance.richardson@broadcom.com >> Cc: oulijun@huawei.com >> Cc: wisamm@mellanox.com >> Cc: lihuisong@huawei.com >> --- > > I think we need to have https://bugs.dpdk.org/show_bug.cgi?id=625 ID in the commit log as fix, Sure, I will send a new version with suggested updates, most probably today, I can add the Bugzilla information too. > In order to allow the scripts to close related bugs directly from Bugzilla. > Scripts? Do we have scripts that close defects automatically, I wasn't aware of it, where does it run?