* [dpdk-dev] [PATCH] net/vmxnet3: remove useless copy when setting MAC address
@ 2018-01-03 13:32 Olivier Matz
2018-01-12 18:40 ` Ferruh Yigit
0 siblings, 1 reply; 3+ messages in thread
From: Olivier Matz @ 2018-01-03 13:32 UTC (permalink / raw)
To: dev, Shrikrishna Khare
This operation is already done by the ethdev layer, it should not
be done by the driver.
Signed-off-by: Olivier Matz <olivier.matz@6wind.com>
---
drivers/net/vmxnet3/vmxnet3_ethdev.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/net/vmxnet3/vmxnet3_ethdev.c b/drivers/net/vmxnet3/vmxnet3_ethdev.c
index 82d59ca8c..c69ec5664 100644
--- a/drivers/net/vmxnet3/vmxnet3_ethdev.c
+++ b/drivers/net/vmxnet3/vmxnet3_ethdev.c
@@ -1149,7 +1149,6 @@ vmxnet3_mac_addr_set(struct rte_eth_dev *dev, struct ether_addr *mac_addr)
struct vmxnet3_hw *hw = dev->data->dev_private;
ether_addr_copy(mac_addr, (struct ether_addr *)(hw->perm_addr));
- ether_addr_copy(mac_addr, &dev->data->mac_addrs[0]);
vmxnet3_write_mac(hw, mac_addr->addr_bytes);
}
--
2.11.0
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [dpdk-dev] [PATCH] net/vmxnet3: remove useless copy when setting MAC address
2018-01-03 13:32 [dpdk-dev] [PATCH] net/vmxnet3: remove useless copy when setting MAC address Olivier Matz
@ 2018-01-12 18:40 ` Ferruh Yigit
2018-01-12 18:42 ` Ferruh Yigit
0 siblings, 1 reply; 3+ messages in thread
From: Ferruh Yigit @ 2018-01-12 18:40 UTC (permalink / raw)
To: Olivier Matz, dev, Shrikrishna Khare
On 1/3/2018 1:32 PM, Olivier Matz wrote:
> This operation is already done by the ethdev layer, it should not
> be done by the driver.
>
> Signed-off-by: Olivier Matz <olivier.matz@6wind.com>
Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [dpdk-dev] [PATCH] net/vmxnet3: remove useless copy when setting MAC address
2018-01-12 18:40 ` Ferruh Yigit
@ 2018-01-12 18:42 ` Ferruh Yigit
0 siblings, 0 replies; 3+ messages in thread
From: Ferruh Yigit @ 2018-01-12 18:42 UTC (permalink / raw)
To: Olivier Matz, dev, Shrikrishna Khare
On 1/12/2018 6:40 PM, Ferruh Yigit wrote:
> On 1/3/2018 1:32 PM, Olivier Matz wrote:
>> This operation is already done by the ethdev layer, it should not
>> be done by the driver.
>>
>> Signed-off-by: Olivier Matz <olivier.matz@6wind.com>
>
> Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com>
Applied to dpdk-next-net/master, thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-01-12 18:42 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-01-03 13:32 [dpdk-dev] [PATCH] net/vmxnet3: remove useless copy when setting MAC address Olivier Matz
2018-01-12 18:40 ` Ferruh Yigit
2018-01-12 18:42 ` Ferruh Yigit
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).