From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C062DA00C5; Thu, 15 Sep 2022 12:22:49 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id B235E427F4; Thu, 15 Sep 2022 12:22:49 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id CA9AA4021D for ; Thu, 15 Sep 2022 12:22:47 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1663237367; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ku7tNCW+kY89knrXeNEcRByXvkldl4CBp/OEQAJhZJc=; b=QGYxBwPYUccpWgAB66gUeCIQsFFSaKrf7JkzruVIs1wWAibUi6iym4q6LNWj7C3RaA4ZgF UUhn7lDFDgwf+R8W3IFZfcLHBNb7wAs1OMwpBzOiLAxUkj/S+6RPB9YrZL4PtPxZ9Tbrb3 etpl1ELiWZMlqVPEplgwOv+nzTQgMnc= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-561-roA16gM0PMWaIuXIVMtw8A-1; Thu, 15 Sep 2022 06:22:44 -0400 X-MC-Unique: roA16gM0PMWaIuXIVMtw8A-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id B5ACF858F17; Thu, 15 Sep 2022 10:22:43 +0000 (UTC) Received: from [10.39.208.12] (unknown [10.39.208.12]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 6922C2087440; Thu, 15 Sep 2022 10:22:42 +0000 (UTC) Message-ID: Date: Thu, 15 Sep 2022 12:22:41 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.12.0 Subject: Re: [PATCH v2 31/37] baseband/acc100: fix clearing PF IR outside handler To: Hernan Vargas , dev@dpdk.org, gakhil@marvell.com, trix@redhat.com Cc: nicolas.chautru@intel.com, qi.z.zhang@intel.com, stable@dpdk.org References: <20220820023157.189047-1-hernan.vargas@intel.com> <20220820023157.189047-32-hernan.vargas@intel.com> From: Maxime Coquelin In-Reply-To: <20220820023157.189047-32-hernan.vargas@intel.com> X-Scanned-By: MIMEDefang 3.1 on 10.11.54.4 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 8/20/22 04:31, Hernan Vargas wrote: > Clearing of PF info ring outside of handler may cause interrupt to be > missed. > A condition in the ACC100 PMD implementation may cause an interrupt > functional handler call to be missed due to related bit being cleared > when checking PF info ring status. > > Fixes: 06531464151 ("baseband/acc100: support interrupt") > Cc: stable@dpdk.org > > Signed-off-by: Hernan Vargas > --- > drivers/baseband/acc100/rte_acc100_pmd.c | 7 ++++--- > 1 file changed, 4 insertions(+), 3 deletions(-) > > diff --git a/drivers/baseband/acc100/rte_acc100_pmd.c b/drivers/baseband/acc100/rte_acc100_pmd.c > index 72e46953ee..4596f5df42 100644 > --- a/drivers/baseband/acc100/rte_acc100_pmd.c > +++ b/drivers/baseband/acc100/rte_acc100_pmd.c > @@ -437,11 +437,12 @@ acc100_check_ir(struct acc100_device *acc100_dev) > while (ring_data->valid) { > if ((ring_data->int_nb < ACC100_PF_INT_DMA_DL_DESC_IRQ) || ( > ring_data->int_nb > > - ACC100_PF_INT_DMA_DL5G_DESC_IRQ)) > + ACC100_PF_INT_DMA_DL5G_DESC_IRQ)) { > rte_bbdev_log(WARNING, "InfoRing: ITR:%d Info:0x%x", > ring_data->int_nb, ring_data->detailed_info); > - /* Initialize Info Ring entry and move forward */ > - ring_data->val = 0; > + /* Initialize Info Ring entry and move forward */ > + ring_data->val = 0; > + } > info_ring_head++; > ring_data = acc100_dev->info_ring + > (info_ring_head & ACC100_INFO_RING_MASK); Please moved it at the beginning of the series. Reviewed-by: Maxime Coquelin Thanks, Maxime