From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id C9A78A04B5; Wed, 30 Sep 2020 10:29:05 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 305B31DAD5; Wed, 30 Sep 2020 10:29:04 +0200 (CEST) Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id 59B741D68A for ; Wed, 30 Sep 2020 10:29:03 +0200 (CEST) IronPort-SDR: njRo6wsXYBZSmu4AKLwotRvvsUmCvYLmRNpeY2rXC6xfPH7aMoVkiICMQ/TK5LEKImpulb4cVC dmhe3YvKlylQ== X-IronPort-AV: E=McAfee;i="6000,8403,9759"; a="161616172" X-IronPort-AV: E=Sophos;i="5.77,321,1596524400"; d="scan'208";a="161616172" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Sep 2020 01:28:47 -0700 IronPort-SDR: /xVRovLD0K/AsPOIeYvg61H2LeUNzyoaIWS7vhJe8ET/cp1uYxuDfM06jUDlWnRZRkK1m5ywc/ 3OA12apDQfPA== X-IronPort-AV: E=Sophos;i="5.77,321,1596524400"; d="scan'208";a="496355760" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.213.251.186]) ([10.213.251.186]) by orsmga005-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Sep 2020 01:28:45 -0700 To: Jerin Jacob , Rasesh Mody , Akhil Goyal , Anoob Joseph Cc: Thomas Monjalon , dpdk-dev , Igor Russkikh , Devendra Singh Rawat References: <20200927223629.11156-1-rmody@marvell.com> From: Ferruh Yigit Message-ID: Date: Wed, 30 Sep 2020 09:28:42 +0100 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH] net/bnx2x: release port upon close X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 9/29/2020 7:20 PM, Jerin Jacob wrote: > On Mon, Sep 28, 2020 at 4:07 AM Rasesh Mody wrote: >> >> Set RTE_ETH_DEV_CLOSE_REMOVE upon probe so all the private resources >> for the port can be freed by rte_eth_dev_close(). With this change the >> private port resources are released in the .dev_close callback. >> >> Signed-off-by: Rasesh Mody > > > It looks like it has ICC compiler errors in this patch[1]. I don't > think, it is introduced by this patch. It is from CPT crypto driver. > > [1] > http://mails.dpdk.org/archives/test-report/2020-September/155058.html > These patches seems pulled to the Thomas' "cleanup ethdev close operation" patchset: [v3,17/29] net/qede: release port upon close (https://patches.dpdk.org/patch/79083/) [v3,06/29] net/bnx2x: release port upon close (https://patches.dpdk.org/patch/79072/) Can you please review the patches in that patchset? And they can be merged with the whole patchset. I will mark this set as superseded. Btw, agree that compile error looks unrelated.