From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 45831A09E4; Fri, 29 Jan 2021 15:04:32 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 280BD240228; Fri, 29 Jan 2021 15:04:32 +0100 (CET) Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by mails.dpdk.org (Postfix) with ESMTP id 00794240223 for ; Fri, 29 Jan 2021 15:04:29 +0100 (CET) IronPort-SDR: z6y+hV9W9BN9lHbHZucMIUJNfwT7yoLkIh+kLgXkQYFat7TO6VUjLCr+J+n1CPF2l2APOvvpqm QQ2XY2dn5KiQ== X-IronPort-AV: E=McAfee;i="6000,8403,9878"; a="244512680" X-IronPort-AV: E=Sophos;i="5.79,385,1602572400"; d="scan'208";a="244512680" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 Jan 2021 06:04:28 -0800 IronPort-SDR: LkcDSCItl0HDu2Wh4ujkRU5rhXekPvVSjPIqzk2roZsdaYYiaL+sqgbr0yiohLtXwJ92/7f7jN E44oKJDVbgiw== X-IronPort-AV: E=Sophos;i="5.79,385,1602572400"; d="scan'208";a="389313948" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.213.197.204]) ([10.213.197.204]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 Jan 2021 06:04:27 -0800 To: Nalla Pradeep , Radha Mohan Chintakuntla , Veerasenareddy Burru Cc: jerinj@marvell.com, sburla@marvell.com, dev@dpdk.org References: <20210129001640.1251-1-pnalla@marvell.com> <20210129124510.12158-9-pnalla@marvell.com> From: Ferruh Yigit Message-ID: Date: Fri, 29 Jan 2021 14:04:25 +0000 MIME-Version: 1.0 In-Reply-To: <20210129124510.12158-9-pnalla@marvell.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH v7 08/12] net/octeontx_ep: added tx queue setup and release X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 1/29/2021 12:45 PM, Nalla Pradeep wrote: > Transmit queue setup involves allocating memory for the command queue > considering tx descriptor count and initializing data structure > representing the queue. Transmit queue release function frees the > command queue. > > Signed-off-by: Nalla Pradeep <...> > + > + otx_ep_info("IQ[%d]: base: %p basedma: %lx count: %d\n", > + iq_no, iq->base_addr, (unsigned long)iq->base_addr_dma, 'base_addr_dma' type is 'uint64_t', but isn't "unsigned long" 4 btyes in 32 bit? Better to use PRIx64 for 'uint64_t' instead of '%lx', and using it removes the need to cast.