From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Shahaf Shuler <shahafs@mellanox.com>,
Thomas Monjalon <thomas.monjalon@6wind.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
"Adrien Mazarguil" <adrien.mazarguil@6wind.com>,
"Nélio Laranjeiro" <nelio.laranjeiro@6wind.com>
Subject: Re: [dpdk-dev] [PATCH 1/2] eal_interrupts: support external rxq interrupt handlers
Date: Tue, 14 Mar 2017 12:32:20 +0000 [thread overview]
Message-ID: <c48f5d79-6be6-fe3a-4558-d585e2a679fb@intel.com> (raw)
In-Reply-To: <AM4PR05MB1505A7778956590024B3D2B2C3220@AM4PR05MB1505.eurprd05.prod.outlook.com>
On 3/12/2017 8:30 AM, Shahaf Shuler wrote:
> Thursday, March 9, 2017 8:10 PM, Thomas Monjalon:
>> 2017-02-08 15:57, Shahaf Shuler:
>>> /**
>>> + * It deletes registered eventfds.
>>> + *
>>> + * @param intr_handle
>>> + * Pointer to the interrupt handle.
>>> + */
>>> +void
>>> +rte_intr_free_epoll_fd(struct rte_intr_handle *intr_handle);
>>
>> This patch looks OK except a miss in the EAL map files for this new function.
>> The title should be "eal/linux: support external Rx interrupt"
>>
>> I think this patch should target next-net.
>> Please Ferruh, take care of this patchset. Thanks
>
> Ferruh, any more comments before submitting a v2?
Hi Shahaf,
No extra comments, only second patch does not cleanly apply to next-net,
please rebase it to before sending.
Thanks,
ferruh
next prev parent reply other threads:[~2017-03-14 12:32 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-08 13:57 [dpdk-dev] [PATCH 0/2] net/mlx5 add rxq interrupt support Shahaf Shuler
2017-02-08 13:57 ` [dpdk-dev] [PATCH 1/2] eal_interrupts: support external rxq interrupt handlers Shahaf Shuler
2017-03-09 18:10 ` Thomas Monjalon
2017-03-12 8:30 ` Shahaf Shuler
2017-03-14 12:32 ` Ferruh Yigit [this message]
2017-02-08 13:57 ` [dpdk-dev] [PATCH 2/2] net/mlx5: support user space rxq interrupt event Shahaf Shuler
2017-02-09 14:48 ` [dpdk-dev] [PATCH 0/2] net/mlx5 add rxq interrupt support Ferruh Yigit
2017-02-12 7:08 ` Shahaf Shuler
2017-02-21 11:40 ` Shahaf Shuler
2017-02-28 7:29 ` Shahaf Shuler
2017-03-14 13:03 ` [dpdk-dev] [PATCH v2 " Shahaf Shuler
2017-03-14 13:03 ` [dpdk-dev] [PATCH v2 1/2] eal/linux: support external Rx interrupt Shahaf Shuler
2017-03-14 16:38 ` Yongseok Koh
2017-03-14 18:06 ` Ferruh Yigit
2017-03-14 13:03 ` [dpdk-dev] [PATCH v2 2/2] net/mlx5: support user space rxq interrupt event Shahaf Shuler
2017-03-14 16:39 ` Yongseok Koh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c48f5d79-6be6-fe3a-4558-d585e2a679fb@intel.com \
--to=ferruh.yigit@intel.com \
--cc=adrien.mazarguil@6wind.com \
--cc=dev@dpdk.org \
--cc=nelio.laranjeiro@6wind.com \
--cc=shahafs@mellanox.com \
--cc=thomas.monjalon@6wind.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).