From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <ferruh.yigit@intel.com>
Received: from mga05.intel.com (mga05.intel.com [192.55.52.43])
 by dpdk.org (Postfix) with ESMTP id 70F4D69D8
 for <dev@dpdk.org>; Tue, 14 Mar 2017 13:32:23 +0100 (CET)
Received: from fmsmga006.fm.intel.com ([10.253.24.20])
 by fmsmga105.fm.intel.com with ESMTP; 14 Mar 2017 05:32:22 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.36,163,1486454400"; d="scan'208";a="76457509"
Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.237.220.122])
 ([10.237.220.122])
 by fmsmga006.fm.intel.com with ESMTP; 14 Mar 2017 05:32:21 -0700
To: Shahaf Shuler <shahafs@mellanox.com>,
 Thomas Monjalon <thomas.monjalon@6wind.com>
References: <1486562252-15307-1-git-send-email-shahafs@mellanox.com>
 <1486562252-15307-2-git-send-email-shahafs@mellanox.com>
 <3002919.bpld94t7Wf@xps13>
 <AM4PR05MB1505A7778956590024B3D2B2C3220@AM4PR05MB1505.eurprd05.prod.outlook.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
 Adrien Mazarguil <adrien.mazarguil@6wind.com>,
 =?UTF-8?Q?N=c3=a9lio_Laranjeiro?= <nelio.laranjeiro@6wind.com>
From: Ferruh Yigit <ferruh.yigit@intel.com>
Message-ID: <c48f5d79-6be6-fe3a-4558-d585e2a679fb@intel.com>
Date: Tue, 14 Mar 2017 12:32:20 +0000
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101
 Thunderbird/45.8.0
MIME-Version: 1.0
In-Reply-To: <AM4PR05MB1505A7778956590024B3D2B2C3220@AM4PR05MB1505.eurprd05.prod.outlook.com>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Subject: Re: [dpdk-dev] [PATCH 1/2] eal_interrupts: support external rxq
 interrupt handlers
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Tue, 14 Mar 2017 12:32:23 -0000

On 3/12/2017 8:30 AM, Shahaf Shuler wrote:
> Thursday, March 9, 2017 8:10 PM, Thomas Monjalon:
>> 2017-02-08 15:57, Shahaf Shuler:
>>>  /**
>>> + * It deletes registered eventfds.
>>> + *
>>> + * @param intr_handle
>>> + *   Pointer to the interrupt handle.
>>> + */
>>> +void
>>> +rte_intr_free_epoll_fd(struct rte_intr_handle *intr_handle);
>>
>> This patch looks OK except a miss in the EAL map files for this new function.
>> The title should be "eal/linux: support external Rx interrupt"
>>
>> I think this patch should target next-net.
>> Please Ferruh, take care of this patchset. Thanks
> 
> Ferruh, any more comments before submitting a v2? 

Hi Shahaf,

No extra comments, only second patch does not cleanly apply to next-net,
please rebase it to before sending.

Thanks,
ferruh