From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D9C60A0093; Thu, 10 Feb 2022 14:26:57 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 74188411AE; Thu, 10 Feb 2022 14:26:57 +0100 (CET) Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by mails.dpdk.org (Postfix) with ESMTP id 89B044013F for ; Thu, 10 Feb 2022 14:26:55 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1644499615; x=1676035615; h=message-id:date:subject:to:cc:references:from: in-reply-to:mime-version; bh=L6jv7CvqKK7ShBGdcvneKdlapQVTex+17iTvSYf77WE=; b=AlEFBqba1HldMibsG3hJNWpxbUIVVlh0Fev/CnCLBpS56OWCdTM1OF8k QDwAl88q98NgUPIYD1UzG6+U3IlnkdT6Lcw0TWnHVqRbT3bnxwWz7pu6f iJ7hjGY+38ilX1jKmLftICXLAHT91m2m7RwLw9dwmWcIRyqCY54xnRYrd zioyLHK32j3TPz1mD6ebHUnlRtl6nFGdW0wMbkvzChAZvz1PmjH6qZGlk Mj8sIydG1UeGZj6ecpbFcUZdblqnz1zEn7YsYCK7pSC5MGxqVcs80rat/ 11AHjO6bn9PBovJ7ujxU+Y0X5qfJGDlaGY9EGmEZ3NzDjY63p+vpgDXW2 g==; X-IronPort-AV: E=McAfee;i="6200,9189,10253"; a="247073153" X-IronPort-AV: E=Sophos;i="5.88,358,1635231600"; d="scan'208,217";a="247073153" Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Feb 2022 05:26:54 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.88,358,1635231600"; d="scan'208,217";a="701690420" Received: from fmsmsx604.amr.corp.intel.com ([10.18.126.84]) by orsmga005.jf.intel.com with ESMTP; 10 Feb 2022 05:26:54 -0800 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx604.amr.corp.intel.com (10.18.126.84) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Thu, 10 Feb 2022 05:26:53 -0800 Received: from fmsmsx612.amr.corp.intel.com (10.18.126.92) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Thu, 10 Feb 2022 05:26:53 -0800 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx612.amr.corp.intel.com (10.18.126.92) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20 via Frontend Transport; Thu, 10 Feb 2022 05:26:53 -0800 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (104.47.66.40) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.20; Thu, 10 Feb 2022 05:26:53 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=PzKntQQUrv7TC9qAcTnpTYwb8IcI8I2RQgFuTKO0bzBHQk6OWm5uUG3I6KwuGSS/3UtHRPnMAqpXPsMFxQXl0vCk3D2FxvMHrLOhF4ZmG4avfBUdJYdU3UQhsF5GCwsYyQFl+/+a/hPryrTtODF3xt41QsngWy18jtoCqxa5qfwqASFe5pNZ+GoR7q0+AXec10h9Lt8Iaos0qU62CVWDKTXSc0V8StZpy2ZTnm+lAK9QjjOBkqD1wYAW+eZqQwLRKUmj+LoryJcwHUZ6JSIpJzw4pBKR0yq+R0HhWKh2+OI/SgefqmOQjoIvIavlFDjt28XArMCOndDwMaZ6BwVrSg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=tnglfSlLsJfnc+IlOhijGXFN6odnY8HNajnueA8RZPQ=; b=iS8JzuVLW3uAwcCFP7hTajfR8sjjuNnuTtNkS2pgcgDqHoQltNzOZ9tmWTXK3nKbhVwmu+LQjuzZwn0PTkdZNxSJAxJgJtjl/sBRfKwUWKAok9v3SWrYtUAIpMvkaeop0OECWL5y4aEDgY+B6HVj2au+35cDtGhotTLVjP6BRynAP3qPcwUGiy3BzL+999WOwMrOiNjaYpB3gvYLlGyzkm3XzsfQ9RfNEClpUKLdF2xCZGAWALCUm+oZLsaIUWeZxRnppjZu0YevPMhkC8s9L/zYOSYyjMr5qbmh5Rf5R5CALczFdQzHKU7SVL6SMI0UvmVLLq9iG1QTGeUvdszstw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from MWHPR11MB0062.namprd11.prod.outlook.com (2603:10b6:301:67::34) by BYAPR11MB3797.namprd11.prod.outlook.com (2603:10b6:a03:fe::27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4975.11; Thu, 10 Feb 2022 13:26:51 +0000 Received: from MWHPR11MB0062.namprd11.prod.outlook.com ([fe80::417b:7df4:d3fb:2b0a]) by MWHPR11MB0062.namprd11.prod.outlook.com ([fe80::417b:7df4:d3fb:2b0a%3]) with mapi id 15.20.4975.014; Thu, 10 Feb 2022 13:26:51 +0000 Content-Type: multipart/alternative; boundary="------------tt4uBsox2EA27gdPwCs20aoo" Message-ID: Date: Thu, 10 Feb 2022 18:56:43 +0530 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.5.1 Subject: Re: [PATCH v2] devtools/cocci: update cocci for ethdev namespace Content-Language: en-US To: Thomas Monjalon CC: , References: <20220123172046.1296964-1-aman.deep.singh@intel.com> <14548884.JCcGWNJJiE@thomas> <2f156089-44ad-776a-c483-9ff62c8c716a@intel.com> <1842607.g5d078U9FE@thomas> From: "Singh, Aman Deep" In-Reply-To: <1842607.g5d078U9FE@thomas> X-ClientProxiedBy: BM1PR0101CA0029.INDPRD01.PROD.OUTLOOK.COM (2603:1096:b00:1a::15) To MWHPR11MB0062.namprd11.prod.outlook.com (2603:10b6:301:67::34) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 03dc79b2-1e97-4fe2-e74e-08d9ec98ff6a X-MS-TrafficTypeDiagnostic: BYAPR11MB3797:EE_ X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:7691; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: mfJQ3EMVMjh81uSQgr6URWxNdgAccALlFZSG2Il0lLUfjJm2Uqe1ZC3o/OkqNCIsmAsIpMZIhK5YsbNCeyz1znappmKSf95ZE0dg4cq9B2UI1BzWgvwuVDoZm8tw61ej6USJv1LWRRYYFfk/VLWhGAPVpZujvJRm/0x1+l5uhDqSSqK1EYL/aWv6HJZmNfRd7LMtWTrZstmpLV+ksWYjZb9xMmCiItIBDrgU4xVnDmNNePaOo5LvVSZxgISW3RsVpkba2qgBfcl3L2b1V4EnC/ry62FxIBnCPneoFFV2PQRnU5GTZ4f/Ka19GNGxNmdq6u8QCKo8W5ypRa3CKl19O6ez9XCq+IJc8gTFFsi575vyTfVoOkIFPsi5SokmRA13YkOSmG+/YYDpBxtJqNesMAorkt26H6IYbrm9TtJJ8nLzfcRsI1/5KsNve19Hnh46WHNHd3KgdktJ5K9efaguD4yFLdp9gYOdJ90DoTAqbIbp+rWIyLEzkKyX3B7dEttCEFZEZWXUbMRZtTawHV1Uxena/Ptc5m3tGOERkiGE5EcK4hpsRQZx0zpmfbw04n9Rf6zaz5SYGz9leLwdSVBmbX5Z4SRo3F5Z7UvIZVoOQCt4+3pIT1SoCPsheKaxK2Trmd77BWWcJKYrEqE7U/qXHZtzYy9w51DuC5cdlUgA96FcKy51S+0bITglqAOP8rwuIRjcjiE9cQLahcle8sYknG6RR5j1pl2yTI1hmONdNqiA5b9hg3VImGX/I4OeFiTY X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MWHPR11MB0062.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(366004)(6916009)(5660300002)(82960400001)(2906002)(38100700002)(316002)(66946007)(66556008)(66476007)(33964004)(6486002)(508600001)(6506007)(6512007)(6666004)(8676002)(53546011)(15650500001)(8936002)(83380400001)(107886003)(2616005)(26005)(186003)(4326008)(36756003)(86362001)(31696002)(31686004)(21314003)(43740500002)(45980500001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?OEZhbzVBUk41QTl1R0lkTUVtNXVzbWRnTktvWHk4L25STHhhbnprdkNPSDdO?= =?utf-8?B?MXNZK01GQzkveUhxMnRFWW9wZHhsQllHME1QK0pYdWo5S0lOdEo5MmRiYXlq?= =?utf-8?B?RmxIcmpjQWw5KzRuTys2SC9SQS9GU2FvKzlaUzR2RFhSb0IxYzlXWU9QNmdI?= =?utf-8?B?NFJQd1lZelpQYmgyeVFEdERrTGpaVm91blB2V2tRMWZvclNBc08wUGlFbUR1?= =?utf-8?B?L0Z5N0dHTTExV1JHZm1nQmIvdW5adGxLVTdSejlIQkN4V0hqZnNIVWxPWDRo?= =?utf-8?B?UWluMFhQTUM3MTYxZVZ6L2hlcTUvTERCdDRLS2FEUHNwRHpZQllKWGk3UlU1?= =?utf-8?B?TlNUVUZqT01rdVZhaVk4ZUVNT2MvZU5pV0d4L3BRVkpyTWZYSUVWYnkyZWVW?= =?utf-8?B?WXZHdTVqQ3NMWjdBdTNmNHR2R1JUVlE5U2RzZ2N1eTJaZExIYVZndHZmbFJE?= =?utf-8?B?ekhhNGNmeHREVEUxckNvdVl1WGw3a0JNSXpjeENWNGxqUHJpZUs1am5uV21t?= =?utf-8?B?TmdnNjduUkluUkV4ZmJxWGk0ODRKRm9qRGdBMXJqOTR5bTRKQUYrSFp6bmdI?= =?utf-8?B?bm9NYWt0TmpWT3dVbVJaazRKcHFIZkdoaDZsMzJMcVNXMmF0STNEOTgzK002?= =?utf-8?B?M0FmSUNQbnVHektqNWhQbFpMby9EcndjL2NIQy9SMnoyVGdoYzBnQ1g5Zzlt?= =?utf-8?B?b2JDeUhIZklRUzcvZWNFdTNQSkRMTXQrQ1RFbjBrcXJNTnV2SmJKMThYVHhH?= =?utf-8?B?a3hKU2IyYUlKb3NEc3E2QWI4eTN4NW5DQ1FSNnllV3NiVEU2VGRlSDRacWhR?= =?utf-8?B?dzMyVkxhYXdoejEzeTNwTEFldXNxTmRzeGdBQStzZGZObjBWZ21PQUNiZjVu?= =?utf-8?B?TjRLUEhlMDZ3SVJsVVlHeGprTExBbzBMelFSaUI2T3BzRisvZENsek1IUVMx?= =?utf-8?B?czd6QkkrY3NKUmNSYVJCUTNGL3dkZmV5a1psVDRCNm9TSlNJM3QrU1pTVnY3?= =?utf-8?B?RkRHcitBUHdKbHo5am40SUFVTm9jeXo5NHZBWmZvTVBQNTY1d0QzRFA4TmpS?= =?utf-8?B?L2x1Q1c4V0NRSXYrOVN6RmU1VCtZd3BobTA5Z0wwMStja3dhM3daN3lVM29I?= =?utf-8?B?YkJJblJkaUJQR1R5WDU2dnNDYUdGeW5tTDdpWmFGRDBQamQzdjZ4QlVRWTlx?= =?utf-8?B?a2wzbzJZeHdsc3NxRzFBUzltWUtZV0M1R1o4cy9JK1VrcmVvMFFqMzZGNnFO?= =?utf-8?B?Nkc2eFJXUUg4N1h4Rk9HbWszdWYvQVUrQTY4b2ZFV0cvR2tuTjV5OG1ibENy?= =?utf-8?B?U1g0S1dLOHZmcnR4YUpKRHdhYnRhTkRiZmpQSnIwYWplYXhzeStaL0RHd3Nr?= =?utf-8?B?M0Rlcm1MSENyQTcxMW9laElzTTdTWDdyTVdFZXY0am1ZNFhXV0RoclNRRVRk?= =?utf-8?B?VjdCMHYwdmljR2h2L2dxQS9wL0FyU1Juemo1RGF2WEJSTTQ5VkNMckN4ZTFE?= =?utf-8?B?ZlphM2FrYW5QQ09jaGEzYU1EYTUwb2h6RTdVMTJGaFJnMmkxV2dqMzQzU1BW?= =?utf-8?B?Z2oraVEzUjhmOHN5WHBJYklVQk5QT1JGTC9jalVSSUpNUmJuS0RoT2lra2Z3?= =?utf-8?B?NzZYSjYvelA1UFV3K2F3U3hqV2dKT2JuTXRSek1VZ1JlTy94ZFRRQklTSGJ4?= =?utf-8?B?RURWOXRaYU8wb25JazMvUVpObXdPNlRKWGFRQURPck05TnV4M2JWRVBrcjhZ?= =?utf-8?B?d1lSc3RQZVNYdUc5aWRNS0prbzhzV1lRa0syb2dnUGw2UnhOcmZEbmViazBu?= =?utf-8?B?TGZqN1ROUDAwRFI3aU1TQi9OUEtBM3duTmZZK3JRakdoU3l2cFV3SVhWa2Fn?= =?utf-8?B?UmhkZ2V5cTRuRkVQNGoxNERhK3VFcVB3VnBqcFk3RERnSjJ0TEg3RWp2b1lT?= =?utf-8?B?LzJUSDBoc0VNZEZmNURCMUR3aTVLeTVuUDdvSjFYT2hMb0gxUjdvaXAybTRQ?= =?utf-8?B?VkdpM1d5R0ZzakFYaTUvY2ZhM2VkanhtRHptUzZ0RW1CZ3o4NjBPZWEyS2Mw?= =?utf-8?B?d2JrbzJFMTBwUWh2THBNZmNUaTNVWUs4ZEk3aE95eGNvTXdDVzdRbzJBWUxp?= =?utf-8?B?bU55N0xOa2JaVk5aTGd5OW5nYWcvdzhyRlVLQW40SDlOTVR0Sm9Rd3h2dDlq?= =?utf-8?B?My9UOTZlSjRpM3F6UDFjNlYxNWhkbFJMb1hoZndoVG50Zk5ad2NQK21qQnRy?= =?utf-8?Q?Eh7INCmdLTo52mDm1xfqlTda54reHkduuVJCOxDi3E=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: 03dc79b2-1e97-4fe2-e74e-08d9ec98ff6a X-MS-Exchange-CrossTenant-AuthSource: MWHPR11MB0062.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Feb 2022 13:26:51.8234 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 2NK/8cxndgcREE50ueNZHNqrIltt0i3ghk7rqZEj39ZvSaGuAoMNciM+da/jkxAZdwWIg1DXLWh5+Dj3xPCMGR16nBaj6G4oRRmEYx3EW+w= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR11MB3797 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org --------------tt4uBsox2EA27gdPwCs20aoo Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit On 2/4/2022 1:17 PM, Thomas Monjalon wrote: > 04/02/2022 07:13, Singh, Aman Deep: >> Hi Thomas >> >> On 2/3/2022 2:31 AM, Thomas Monjalon wrote: >>> 23/01/2022 18:20, Aman Singh: >>>> Added two specific exceptions for ETH_SPEED_10G >>>> and ETH_SPEED_25G to avoid there name change. >>>> Added check for ETH_TUNNEL_FILTER and ETH_RSS_RETA >>> Please could you explain why? >> These two macro's ETH_SPEED_10G & ETH_SPEED_25G are used by ifpga >> driver and script should no change these. >> There are multiple ETH_SPEED_NUM_xxx macro that need to be changed >> to RTE_ETH_SPEED_NUM_xxx. So added above two as specific exceptions. > Why doing this exception? What is special with ifpga? These two macro's are defined in 'ifpga/base/opae_eth_group.h' we don't intend to change these. Target is ethdev namespace only. > >> The other two patterns ETH_TUNNEL_FILTER & ETH_RSS_RETA were missed before. >> The script should change these to RTE_ETH_TUNNEL_FILTER & RTE_ETH_RSS_RETA > The explanations should be part of the commit log please. Sure, if this explanation is fine? Will update in next version. > > > --------------tt4uBsox2EA27gdPwCs20aoo Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: 7bit


On 2/4/2022 1:17 PM, Thomas Monjalon wrote:
04/02/2022 07:13, Singh, Aman Deep:

Hi Thomas

On 2/3/2022 2:31 AM, Thomas Monjalon wrote:

23/01/2022 18:20, Aman Singh:

Added two specific exceptions for ETH_SPEED_10G
and ETH_SPEED_25G to avoid there name change.
Added check for ETH_TUNNEL_FILTER and ETH_RSS_RETA

Please could you explain why?

These two macro's ETH_SPEED_10G & ETH_SPEED_25G are used by ifpga
driver and script should no change these.
There are multiple ETH_SPEED_NUM_xxx macro that need to be changed
to RTE_ETH_SPEED_NUM_xxx. So added above two as specific exceptions.

Why doing this exception? What is special with ifpga?
These two macro's are defined in 'ifpga/base/opae_eth_group.h'
we don't intend to change these. Target is ethdev namespace only.



The other two patterns ETH_TUNNEL_FILTER & ETH_RSS_RETA were missed before.
The script should change these to RTE_ETH_TUNNEL_FILTER & RTE_ETH_RSS_RETA

The explanations should be part of the commit log please.
Sure, if this explanation is fine? Will update in next version.
--------------tt4uBsox2EA27gdPwCs20aoo--