From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2A3D243EA1; Thu, 18 Apr 2024 23:41:59 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D9F06402D0; Thu, 18 Apr 2024 23:41:58 +0200 (CEST) Received: from NAM02-DM3-obe.outbound.protection.outlook.com (mail-dm3nam02on2042.outbound.protection.outlook.com [40.107.95.42]) by mails.dpdk.org (Postfix) with ESMTP id BFEE6402D9; Thu, 18 Apr 2024 23:41:56 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=e/Yu02tGhBZO4LwGic4eQ6xjlN8/NE3gNe1aRX2NrtgpLFFvXdlcIDD13PdS8Cxxra/CaQ0WNI5nIV8wDACjDr0Xovy505gl4MkzXv5J8Rq64ACP8vO3OsSEH+VBxbLf8uchs/5PCC2ZtQ8Azr1GUIggraOKUQlku12CElcIT941/BYqsD+Mte+VFsZEWslmED/Mc/O5/2ffxKMLAS3Os2+9MvUlJMztrZeYkVnsJ4uNumUpIKoDTNRQO6wlBPTBEiVU4ai39DI3dl8qFv/5FwtgIMBHkxj9XMJWqS26GGSOulOlylb2zo3Z/OI0ZssXPiskKUXaipjymVueEUMp1Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=G1glC084oBReLfHwmTHvVcyG9Ci4i44FcNm9TptA258=; b=S6q3fektzxSBQLegeIzhOkpz0U1KJPsFZ/pu29M8o9qABeJHNpd+rFQuK7X1wVM1PvXkbmV2uHqOo3QTWTxe2428r5f4OZqskdmS5SgoH1AJZJyCMwZo9VusKzs+nLBXhmGz2IJ5dYbQ3S8AsPWUwA8fWtV1GAHdL4qvIUEWXvA226zvZbA1Zxjq7FKIxhd3fz8XpU+HIg0fRnRpO7dhoFcwVVQvGWK5ENXrfv4dUR9T37DW8qXIqrYXvkMnuQdRdnr96OWaax4oNTCG3QPYRRvZIGZOtpKps96g+S0UkCXhcfQeq9TFqyjS808yjXRLi3qnXXwBYt8ncIu66eQ3Ww== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=G1glC084oBReLfHwmTHvVcyG9Ci4i44FcNm9TptA258=; b=cFdog5N8aubTNt9i+nw0TQg6MZQi53WgR9UNULG3DDmvwOpDwvBwHEiuJi6U8XkAMkmzZQ81QaOQdW134M7k5dlX6bqgqPgmH4MrP65Y/pobflGjveip3IJ6plCVvDeEmKFaYgokjTFucWCKdZLFEVu85d8jnaPhsOy1UjOZbk0= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) by SN7PR12MB7417.namprd12.prod.outlook.com (2603:10b6:806:2a4::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7452.55; Thu, 18 Apr 2024 21:41:54 +0000 Received: from CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::282f:29d3:cac1:cde3]) by CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::282f:29d3:cac1:cde3%7]) with mapi id 15.20.7452.049; Thu, 18 Apr 2024 21:41:54 +0000 Message-ID: Date: Thu, 18 Apr 2024 22:41:49 +0100 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2] app/testpmd: fix releasing action handle flush memory To: Bing Zhao , dmitry.kozliuk@gmail.com, dev@dpdk.org Cc: aman.deep.singh@intel.com, yuying.zhang@intel.com, matan@nvidia.com, stable@dpdk.org, Dariusz Sosnowski References: <20240319093249.307606-1-bingz@nvidia.com> <20240325105826.393231-1-bingz@nvidia.com> Content-Language: en-US From: Ferruh Yigit Autocrypt: addr=ferruh.yigit@amd.com; keydata= xsFNBGJDD3EBEAC/M7Tk/DfQSmP1K96vyzdhfSBzlCaGtcxNXorq4fALruqVsD3oi0yfyEz9 4YN8x7py0o9EL8ZdpOX0skc0AMCDAaw033uWhCn0GLMeGRKUbfOAPvL6ecSDvGD7CJIO9j0J eZUvasBgPdM/435PEr9DmC6Ggzdzt8IuG4PoLi5jpFSfcqxZFCCxLUDEo/w0nuguk2FTuYJg B2zEZ4JTBZrw7hIHiFh8D8hr6YA6a5uTofq1tr+l048lbtdFUl8TR0aIExVzE4Z8qKZlcE+9 RQaewjK5Al1jLE4sHdmd3GN+IvgDF3D/fLsi25SKJDeGSdeHkOmaX0qGeM4WKIfU6iARRCiQ N3AmBIxZ/A7UXBKLaOyZ+/i3sE6Wb53nrO4i8+0K2Qwyh6LjTeiJAIjYKN43ppxz3DaI+QwQ vI+uyHr4Gg0Da9EPPz/YyKauSeOZCfCB5gIfICO0j6x0SCl8uQ2nLpjxcZkf0gjcwUzP3h+S 3x6NfDji9YEij0zczW/dcSpGgZ6vsFpPrtnP9ZXy6J53yp0kJtOJoOlkEFFdU2yCZnCDseum CoudmGLZVvS0/DzHDJejq+3kK3FDGktZBOxZIIpal+nFqS7lVgOZc4+huVv3jyhzoAUOEyXA XK5j6o7g8STUY+z33QNnHpdLvecMwuzmvqy0jR54yAbZ64mB9QARAQABzSNGZXJydWggWWln aXQgPGZlcnJ1aC55aWdpdEBhbWQuY29tPsLBlwQTAQgAQQIbAwULCQgHAgYVCgkICwIEFgID AQIeAQIXgAIZARYhBEm7aYjps5XGsPHCElRTPtCKKm/6BQJkdyEEBQkE3meNAAoJEFRTPtCK Km/6UdcP/0/kEp49aIUhkRnQfmKmNVpcBEs4NqceNCWTQlaXdEwL1lxf1L49dsF5Jz1yvWi3 tMtq0Mk1o68mQ7q8iZAzIeLxGQAlievMNE0BzLWPFmuX+ac98ITBqKdnUAn6ig5ezR+jxrAU 58utUszDl16eMabtCu76sINL5izB8zCWcDEUB4UqM8iBSQZ7/a7TSBVS0jVBldAORg1qfFIs cGMPQn/skhy3QqbK3u3Rhc44zRxvzrQJmhY6T1rpeniHSyGOeIYqjpbpnMU5n1VWzQ4NXvAD VDkZ4NDw6CpvF4S2h2Ds7w7GKvT6RRTddrl672IaLcaWRiqBNCPm+eKh4q5/XkOXTgUqYBVg Ors8uS9EbQC/SAcp9VHF9fB+3nadxZm4CLPe5ZDJnSmgu/ea7xjWQYR8ouo2THxqNZtkercc GOxGFxIaLcJIR/XChh9d0LKgc1FfVARTMW8UrPgINVEmVSFmAVSgVfsWIV+NSpG9/e90E4SV gMLPABn1YpJ8ca/IwqovctqDDXfxZOvCPOVWTzQe/ut767W+ctGR1kRkxWcz470SycOcY+PW VRPJd91Af0GdLFkwzZgNzkd6Gyc9XXcv4lwwqBLhWrBhqPYB0aZXIG1E/cVTiRp4dWpFHAFD DcuLldjIw93lCDsIeEDM9rBizGVMWEoeFmqSe7pzGTPXzsFNBGJDD3EBEAC8fBFQHej8qgIG CBzoIEd1cZgPIARlIhRudODXoNDbwA+zJMKtOVwol3Hh1qJ2/yZP11nZsqrP4fyUvMxrwhDe WBWFVDbWHLnqXMnKuUU1vQMujbzgq/4Rb9wSMW5vBL6YxhZng+h71JgS/9nVtzyaTtsOTrJi 6nzFSDx6Wbza2jYvL9rlK0yxJcMEiKwZQ/if4KcOesD0rtxomU/iSEv6DATcJbGXP6T93nPl 90XksijRKAmOwvdu3A8IIlxiSSVRP0lxiHOeR35y6PjHY2usfEDZZOVOfDfhlCVAIBZUZALv VmFOVSTYXeKgYa6Ooaf72+cHM3SgJIbYnevJfFv8YQW0MEAJ/IXE7B1Lk+pHNxwU3VBCrKnA fd/PTvviesuYRkrRD6qqZnINeu3b2DouVGGt2fVcGA38BujCd3p8i7azoGc7A6cgF7z9ETnr ANrbg1/dJyDmkDxOxVrVquTBbxJbDy2HaIe9wyJTEK2Sznpy62DaHVY+gfDQzexBXM10geHC IIUhEnOUYVaq65X3ZDjyAQnNDBQ4uMqSHZk8DpJ22X+T+IMzWzWl+VyU4UZXjkLKPvlqPjJk 1RbKScek5L2GhxHQbPaD76Hx4Jiel0vm2G+4wei8Ay1+0YRFkhySxogU/uQVXHTv63KzQMak oIfnN/V2R0ucarsvMBW+gwARAQABwsF8BBgBCAAmAhsMFiEESbtpiOmzlcaw8cISVFM+0Ioq b/oFAmR3IPsFCQTeZ44ACgkQVFM+0Ioqb/qINhAAtcor9bevHy22HvJvXX17IOpPSklZJAeQ Az43ZEo5kRlJ8mElc2g3RzYCvL/V3fSiIATxIsLq/MDtYhO8AAvklxND/u2zeBd7BkRZTZZX W1V1cM3oTvfx3LOhDu4f2ExQzCGdkzbXTRswSJIe1W0qwsDp+YPekbrsKp1maZArGeu+6FuW honeosIrWS98QJmscEhP8ooyJkLDCCOgEk+mJ/JBjzcJGuYn6+Iy/ApMw/vqiLGL1UWekcTA g18mREHqIR+A3ZvypIufSFB52oIs1zD/uh/MgmL62bY/Cw6M2SxiVxLRsav9TNkF6ZaNQCgn GqifliCEMvEuLZRBOZSYH2A/PfwjYW0Ss0Gyfywmb2IA990gcQsXxuCLG7pAbWaeYazoYYEQ NYmWatZNMAs68ERI2zvrVxdJ/fBWAllIEd0uQ4P05GtAHPdTIDQYp545+TPV7oyF0LfXcsQs SFVZE6igdvkjfYmh+QOrHGZvpWXLTmffVf/AQ81wspzbfxJ7sYM4P8Mg5kKOsaoUdyA/2qVe cMh1CLUHXF1GlofpGbe1lj4KUJVse5g3qwV7i9VrseA8c4VIZewdIjkzAhmmbxl+8rM/LKBH dZUMTzME5PFCXJIZ83qkZQ795MTe2YScp9dIV7fsS5tpDwIs7BZNVM1l3NAdK+DLHqNxKuyO 8Zk= In-Reply-To: <20240325105826.393231-1-bingz@nvidia.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LNXP265CA0038.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:5c::26) To CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB4294:EE_|SN7PR12MB7417:EE_ X-MS-Office365-Filtering-Correlation-Id: c687e922-78fa-45f9-dae3-08dc5ff05d39 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: WOQhBEun0LmQM8WRYo3Sy7Px6wEvTDfDUGiCx4W5cqDcIMFBxNRtbW6YrUkGMcCDjiW10QJ6XMGVbRvVfrw9wtq9RxVlkARV+OQ4nvlkkGGVISydbcQ1buMsScsLRR9hMvyPz9dIVz6y0PbVn35KuLaMZ8PTJHF7dSXCze24WD2//J/y27WtADpo5zlvQI5n5JKu7KThLVOJYICERNELXnJHYM3ZHwedkj1aWzqSgR96CEORkpkajskyhFRqYR4ScMkjmRVrfcdhKqwIV8CmbYQ6E40fYswg0jbvtWPNq1aWNotqk2JZ3FsOhGoYq31s+gSygU/gkGHEOuIu/cY8NLAT+11QTBSbLHDkL/nDqAD3z6oBoVynJho0ofOsAtkj04DUGrvZoZNPM2ccSl/OJpdoo3N+FPzsdFB82RGoZ1tYRV2k1aq+BHigqu+XPhhZQknNcFCIjRXMhY3wJsuwCktGSatndyqTvCKfuUxrlf26e+vlz63tDqSp95CLtB89mQYtmevf4AUI/pKw5DfyOg1G3X67C4skqPW9tAzv0o0avLjuoDV4He3l/vWfIJeNQ04j2JUcKa+eQkWKkhpeHPe+EBDYgVfV/MO2g9E9sFGsh7G9SMglz4fMTPKVT3pj72P59Jqc4sKnJggy41HIcHWcUCW9B2zFRpSaH/44/cM= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH2PR12MB4294.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(376005)(1800799015)(366007); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?QzZKL3RKNnc0MmtyeTR1NC8wdjZOWlFoMVNCc1hrMXRQd2kvRVFqcksyRzRu?= =?utf-8?B?YXp6UzZGZWMyTmVQeDFzOVZ2QTZnOVpnSWNxZlhQU0hZa3lwVzJoMGsxSlRs?= =?utf-8?B?UU9xd3pvblFpRTRmLy92c3FmcGlsR1B2ZStRRTZRUzZKZ09ud01QTGNBOHph?= =?utf-8?B?UzdBeTJhK0RTVE4xZ3duVlJocy9JdUVuNGFoWUFxaEwrN09BakdWWWhzYVdU?= =?utf-8?B?TzdoWVV0cnY5Qk03TndTdnVLZTBVUnQzUHZTMG14MTM2SnVXNGZuekgyOU9K?= =?utf-8?B?RUVzcnVLWDdaU3hkbUlXOEtBUEsvazZHRGsrL1ZSajFqZy9MbzdGTHlJRlJM?= =?utf-8?B?UjF5N1VlK3NXVlBTR3pkWlVwWHVXSmhrWTdPcFVZbzlTS2thTkpWUVEyRzFF?= =?utf-8?B?bWtnYmdkYUhENEp5cVZ5MGQwNTJRdXZWNzRaakxXM3Fma3pMcjMvRG5rcFpJ?= =?utf-8?B?eDlweEhYSk9jM0VvdEdaUGNZYkZocjdKUng1L28yNTlyYjQrdmpzR25wZFQ2?= =?utf-8?B?T0JkNDIwL212RTBUWVlPSEpCT1dKNTFZY2plVTFjTlF1bnZHTldQMXZTOVZC?= =?utf-8?B?T2J2TkdLSi9VMzVaM0NDT3QyQ09TN3V6ZUo1a3JSMmE1Q3k3a2hLZVFKN1Bq?= =?utf-8?B?aDlMa2lOVmNTQTlSQnkzUjJtRncybEtUbkVBQmM2ZW1NRk5JVWdPQ1NVdVVF?= =?utf-8?B?NWYvQUF6YldoZ25GNDFkd1hCTVI5blRiWlZvalM0R2VXTEZiYXRsOHdsMmlx?= =?utf-8?B?SFBEUElsV2ZwTmdNZHdjdVR0TFhUV0Y3TWNrMG5hTmtnc1RIdjdQV0pXS0ha?= =?utf-8?B?eHd0Ny93QXQ1QmlmdXArSjBPTzZvNDRTdFloT2duV1dsOElLYlNReFFwYVYw?= =?utf-8?B?NWVzVDFMbEJvWC9TNTRseDRPR1pkR0FoTG5wWXc2cW44WlNFMmFQL21oMnN5?= =?utf-8?B?N2I3VWR3VngwaWNWSnJLc3hXejFtbmtQL2duclJGSUhnRUhkeklIcFZaa2Fu?= =?utf-8?B?MlhXTDllQ2YxYkRoOXgveEJVOEpjbzk2bXNHV250UzdKRHhoUmwvaUgyMVBi?= =?utf-8?B?aWY0clQya3M0WDdoaXJpZ1hlSHJ3NmY0VXhzNzY0bWpjWncvWXNya2ZQRlR6?= =?utf-8?B?OEFWOEszUHd2SytGZm93a2wwSENSWTg5OTJXK3VBVHBxdjd6SnBQaklYZHNa?= =?utf-8?B?d0Zyd05HSDNGakE3ZmhCL3NvTkNRR0NwV0poYUs2Rm82V0d4dFczVVA3aWxN?= =?utf-8?B?YXVuUm5VMHVpMCtNcXRUVS9saldiS2ZQeXZCOCtRVHk1bnREM1FJWUxmcUtY?= =?utf-8?B?N01HNXJIY3AxdlB4UUhyNXpPRWtuQW8wMTQ5clVnNmsxOHA2VkFxRW1lTVFU?= =?utf-8?B?T21zdmVZV0NJcWcvYTJXWHZVYWkvV3pDMnpweW5LbkdPKzR5NHVDSDB0SHRI?= =?utf-8?B?ZnIyWHF4cUZtSjVBQU5wUEhxaTdBMkp4SHhyM0VvMFhjb1RUa3JRZldSSVZ5?= =?utf-8?B?SEJSQW9US3c2ODVXL08xbmF3TjdSS1o5YUQrdUpRYmZCZDV4TjhBMGxBVG1o?= =?utf-8?B?Qk92STZSNkp2MWpST1JrelNnZGdPLzltUmNEM2RBWnFMWDk2eHlqTWo4M05z?= =?utf-8?B?SWtXdVExVHhuaFozbHNNTmduSHh2cmtEYVpHekdyYTIzSXhYcXNwRGEyQlFn?= =?utf-8?B?Z2YyZ3NqT2JpTlhRbzh0ajJQaHhzWVhtSDF6QlN6MThiNHhhZmVrNHhaMFFT?= =?utf-8?B?Qi9WbzdtNCtseWRLYzFyK3N3aU5EZmViTnYwT1M2bEg0M1hhY3Z6OExiY3Uw?= =?utf-8?B?eEdkUklaMGlMYWZIRGhJMnhLL3pTK0wyWlN3TllXTjZGRGQzd1plR21kRUhB?= =?utf-8?B?SlR5dzNrYytGQktkS2l0RWN0TmNHdWhMSkNvWSsyRURhQ1ZidEpjYjRMVXBD?= =?utf-8?B?V3FoWWxHZzF3ZUs2Y0JJR1NBVzMyOE1FSFRDL3BSRFBLdFIxM0tiYzdSY2d6?= =?utf-8?B?a1dETlg4aUxIdzhPRWppUVhmNlNWM1J6Z2U0cVZBZ0JjRG54UEY2RWFTU1Rs?= =?utf-8?B?V1ZyZFd6QU8wNERoZWxPdGEzY3BUQ3loeTkySUxrUE04ZkRvZlBOQ3JhQ3Ra?= =?utf-8?Q?d8qqUb7b8Yt2qMGvOSKHD7IOi?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: c687e922-78fa-45f9-dae3-08dc5ff05d39 X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB4294.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Apr 2024 21:41:54.2025 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: boZV93SutBJkd/wqSXEu0nE8UdCBv2+7oEhuqh7gYXPgigJTaqBW8c6jE9xTmW1q X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR12MB7417 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 3/25/2024 10:58 AM, Bing Zhao wrote: > The memory of the indirect action handles should be freed after > being destroyed in the flush. The behavior needs to be consistent > with the single handle destroy port_action_handle_destroy(). > > Or else, there would be some memory leak when closing / detaching a > port without quitting the application. In the meanwhile, since the > action handles are already destroyed, it makes no sense to hold the > indirect action software resources anymore. > > Fixes: f7352c176bbf ("app/testpmd: fix use of indirect action after port close") > Cc: dmitry.kozliuk@gmail.com > Cc: stable@dpdk.org > > Signed-off-by: Bing Zhao > Reviewed-by: Dariusz Sosnowski > Acked-by: Ferruh Yigit Applied to dpdk-next-net/main, thanks.