Re: [dpdk-dev] [PATCH] vdpa/mlx5: fix completion queue polling

[Maxime Coquelin <maxime.coquelin@redhat.com>]

On 9/10/20 9:20 AM, Matan Azrad wrote:
> The CQ polling is done in order to notify the guest about new traffic
> bursts and to release FW resources for the next bursts management.
> 
> When HW is faster than SW, it may be that all the FW resources are busy
> in SW due to late polling.
> In this case, due to wrong WQE counter masking, the fullness
> calculation of the completions number is 0 while the queue is full.
> 
> Change the WQE counter masking to 16-bit wideness instead of the CQ
> size mask as defined by the CQE format.
> 
> Fixes: c5f714e50b0e ("vdpa/mlx5: optimize completion queue poll")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Matan Azrad <matan@nvidia.com>
> Acked-by: Xueming Li <xuemingl@nvidia.com>
> ---
>  drivers/vdpa/mlx5/mlx5_vdpa_event.c | 7 +++----
>  1 file changed, 3 insertions(+), 4 deletions(-)
> 


Reviewed-by: Maxime Coquelin <maxime.coquelin@redhat.com>

Thanks,
Maxime