From: Ferruh Yigit <ferruh.yigit@amd.com>
To: Huzaifa Rahman <huzaifa.rahman@emumba.com>,
Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
Cc: Joyce Kong <Joyce.Kong@arm.com>,
"jgrajcia@cisco.com" <jgrajcia@cisco.com>,
"dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [PATCH] memif: memif driver does not crashes when there's different N of TX and RX queues
Date: Thu, 10 Nov 2022 14:20:20 +0000 [thread overview]
Message-ID: <c4d1d4f2-5af6-e05d-251b-75c33bace7fa@amd.com> (raw)
In-Reply-To: <CANVhzTjU8m=D9i=LbO8_D5A1WfT9o9po+2zX2f+J_H_Uj89rsg@mail.gmail.com>
On 11/10/2022 10:02 AM, Huzaifa Rahman wrote:
> Hi,
>
> Is there any other work/changes required for this patch to be submitted?
>
Hi Huzaifa,
Patch seems already merged by Andrew and pulled to main repo:
https://git.dpdk.org/dpdk/commit/?id=231435a5e6c7fa915697d8f84a91b44176
So it will in oncoming 22.11 release.
> Thanks
>
>
> On Tue, Oct 4, 2022 at 7:53 PM Andrew Rybchenko
> <andrew.rybchenko@oktetlabs.ru <mailto:andrew.rybchenko@oktetlabs.ru>>
> wrote:
>
> On 8/8/22 13:39, Joyce Kong wrote:
> > Hi Huzaifa,
> >
> > This patch looks good to me.
> > And would you please help review my memif patches?
> >
> https://patches.dpdk.org/project/dpdk/cover/20220701102815.1444223-1-joyce.kong@arm.com/ <https://patches.dpdk.org/project/dpdk/cover/20220701102815.1444223-1-joyce.kong@arm.com/>
> >
> > Thanks,
> > Joyce
> >
> >> -----Original Message-----
> >> From: huzaifa.rahman <huzaifa.rahman@emumba.com
> <mailto:huzaifa.rahman@emumba.com>>
> >> Sent: Tuesday, July 26, 2022 6:16 PM
> >> To: jgrajcia@cisco.com <mailto:jgrajcia@cisco.com>
> >> Cc: dev@dpdk.org <mailto:dev@dpdk.org>; huzaifa.rahman
> <huzaifa.rahman@emumba.com <mailto:huzaifa.rahman@emumba.com>>
> >> Subject: [PATCH] memif: memif driver does not crashes when there's
> >> different N of TX and RX queues
> > net/memif: fix memif crash with different Tx Rx queues
> >
> >>
> >> Bugzilla ID: 734
> >>
> >> there's a bug in memif_stats_get() function due to confusion
> between C2S
> >> (client->server) and S2C (server->client) rings, causing a crash
> if there's a
> >> different number of RX and TX queues.
> >>
> >> this is fixed by selectiing the correct rings for RX and TX i.e
> for RX, S2C rings
> >> are selected and for TX, C2S rings are selected.
> >>
> > Fixes: 09c7e63a71f9 ("net/memif: introduce memory interface PMD")
> > Cc: stable@dpdk.org <mailto:stable@dpdk.org>
> >
> >> Signed-off-by: huzaifa.rahman <huzaifa.rahman@emumba.com
> <mailto:huzaifa.rahman@emumba.com>>
> > Reviewed-by: Joyce Kong <joyce.kong@arm.com
> <mailto:joyce.kong@arm.com>>
>
> Fixed above on applying.
>
> Applied to dpdk-next-net/main, thanks.
>
>
prev parent reply other threads:[~2022-11-10 14:20 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-26 10:16 huzaifa.rahman
2022-08-08 10:39 ` Joyce Kong
2022-10-04 14:53 ` Andrew Rybchenko
2022-11-10 10:02 ` Huzaifa Rahman
2022-11-10 14:20 ` Ferruh Yigit [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c4d1d4f2-5af6-e05d-251b-75c33bace7fa@amd.com \
--to=ferruh.yigit@amd.com \
--cc=Joyce.Kong@arm.com \
--cc=andrew.rybchenko@oktetlabs.ru \
--cc=dev@dpdk.org \
--cc=huzaifa.rahman@emumba.com \
--cc=jgrajcia@cisco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).