From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Kathleen Capella <Kathleen.Capella@arm.com>,
Wenzhuo Lu <wenzhuo.lu@intel.com>,
Xiaoyun Li <xiaoyun.li@intel.com>,
Bernard Iremonger <bernard.iremonger@intel.com>
Cc: Honnappa Nagarahalli <Honnappa.Nagarahalli@arm.com>,
"thomas@monjalon.net" <thomas@monjalon.net>, nd <nd@arm.com>,
"dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH v2] app/testpmd: remove unused struct member
Date: Fri, 19 Feb 2021 18:50:08 +0000 [thread overview]
Message-ID: <c4d60669-0e9d-3b40-bcfd-82c884604dbd@intel.com> (raw)
In-Reply-To: <DBAPR08MB5752C322717D9D8CD5D561F087849@DBAPR08MB5752.eurprd08.prod.outlook.com>
On 2/19/2021 5:25 PM, Kathleen Capella wrote:
> The iol-testing warning on this patch seems to be unrelated to the patch.
>
Yep, it looks unrelated, spdk build is failing, I tried to trigger build again,
please check after some time if status changes.
> On February 9, 2021 10:40 AM, Kathleen Capella wrote
>> The tx_queue member of the fwd_lcore struct is unused as it is already part of the fwd_stream
>> structure. Deleting helps improve code readability.
>
>> Signed-off-by: Kathleen Capella <kathleen.capella@arm.com>
>> Reviewed-by: Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>
>> Acked-by: Thomas Monjalon <thomas@monjalon.net>
>> ---
>> app/test-pmd/testpmd.h | 1 -
>> 1 file changed, 1 deletion(-)
>
>> diff --git a/app/test-pmd/testpmd.h b/app/test-pmd/testpmd.h index 5f2316210..f805f1b4d 100644
>> --- a/app/test-pmd/testpmd.h
>> +++ b/app/test-pmd/testpmd.h
>> @@ -247,7 +247,6 @@ struct fwd_lcore {
>> streamid_t stream_idx; /**< index of 1st stream in "fwd_streams" */
>> streamid_t stream_nb; /**< number of streams in "fwd_streams" */
>> lcoreid_t cpuid_idx; /**< index of logical core in CPU id table */
>> - queueid_t tx_queue; /**< TX queue to send forwarded packets */
>> volatile char stopped; /**< stop forwarding when set */
>> };
>
>> --
>> 2.17.1
>
next prev parent reply other threads:[~2021-02-19 18:50 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-09 15:40 Kathleen Capella
2021-02-19 17:25 ` Kathleen Capella
2021-02-19 18:50 ` Ferruh Yigit [this message]
2021-02-22 18:20 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c4d60669-0e9d-3b40-bcfd-82c884604dbd@intel.com \
--to=ferruh.yigit@intel.com \
--cc=Honnappa.Nagarahalli@arm.com \
--cc=Kathleen.Capella@arm.com \
--cc=bernard.iremonger@intel.com \
--cc=dev@dpdk.org \
--cc=nd@arm.com \
--cc=thomas@monjalon.net \
--cc=wenzhuo.lu@intel.com \
--cc=xiaoyun.li@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).