From: Dekel Peled <dekelp@mellanox.com>
To: adrien.mazarguil@6wind.com, wenzhuo.lu@intel.com,
jingjing.wu@intel.com, bernard.iremonger@intel.com,
yskoh@mellanox.com, shahafs@mellanox.com,
viacheslavo@mellanox.com, arybchenko@solarflare.com
Cc: dev@dpdk.org, orika@mellanox.com
Subject: [dpdk-dev] [PATCH v10 1/3] ethdev: add actions to modify TCP header fields
Date: Tue, 2 Jul 2019 17:44:26 +0300 [thread overview]
Message-ID: <c4db0791c7576911dab42f59692042d1dab5e39b.1562078184.git.dekelp@mellanox.com> (raw)
In-Reply-To: <cover.1562078184.git.dekelp@mellanox.com>
Add actions:
- INC_TCP_SEQ - Increase sequence number in the outermost TCP header.
- DEC_TCP_SEQ - Decrease sequence number in the outermost TCP header.
- INC_TCP_ACK - Increase acknowledgment number in the outermost TCP
header.
- DEC_TCP_ACK - Decrease acknowledgment number in the outermost TCP
header.
Original work by Xiaoyu Min.
This patch uses the new approach introduced by [1], using a simple
integer instead of using an action-specific structure for each of
the new actions.
[1] http://patches.dpdk.org/patch/55882/
Signed-off-by: Dekel Peled <dekelp@mellanox.com>
Acked-by: Andrew Rybchenko <arybchenko@solarflare.com>
---
doc/guides/prog_guide/rte_flow.rst | 32 ++++++++++++++++++++++
lib/librte_ethdev/rte_flow.c | 4 +++
lib/librte_ethdev/rte_flow.h | 56 ++++++++++++++++++++++++++++++++++++++
3 files changed, 92 insertions(+)
diff --git a/doc/guides/prog_guide/rte_flow.rst b/doc/guides/prog_guide/rte_flow.rst
index 67deed7..bbe32db 100644
--- a/doc/guides/prog_guide/rte_flow.rst
+++ b/doc/guides/prog_guide/rte_flow.rst
@@ -2346,6 +2346,38 @@ Otherwise, RTE_FLOW_ERROR_TYPE_ACTION error will be returned.
| ``mac_addr`` | MAC address |
+--------------+---------------+
+Action: ``INC_TCP_SEQ``
+^^^^^^^^^^^^^^^^^^^^^^^
+
+Increase sequence number in the outermost TCP header.
+Value to increase TCP sequence number by is a big-endian 32 bit integer.
+
+Using this action on non-matching traffic will result in undefined behavior.
+
+Action: ``DEC_TCP_SEQ``
+^^^^^^^^^^^^^^^^^^^^^^^
+
+Decrease sequence number in the outermost TCP header.
+Value to decrease TCP sequence number by is a big-endian 32 bit integer.
+
+Using this action on non-matching traffic will result in undefined behavior.
+
+Action: ``INC_TCP_ACK``
+^^^^^^^^^^^^^^^^^^^^^^^
+
+Increase acknowledgment number in the outermost TCP header.
+Value to increase TCP acknowledgment number by is a big-endian 32 bit integer.
+
+Using this action on non-matching traffic will result in undefined behavior.
+
+Action: ``DEC_TCP_ACK``
+^^^^^^^^^^^^^^^^^^^^^^^
+
+Decrease acknowledgment number in the outermost TCP header.
+Value to decrease TCP acknowledgment number by is a big-endian 32 bit integer.
+
+Using this action on non-matching traffic will result in undefined behavior.
+
Negative types
~~~~~~~~~~~~~~
diff --git a/lib/librte_ethdev/rte_flow.c b/lib/librte_ethdev/rte_flow.c
index 3277be1..0c9f6c6 100644
--- a/lib/librte_ethdev/rte_flow.c
+++ b/lib/librte_ethdev/rte_flow.c
@@ -143,6 +143,10 @@ struct rte_flow_desc_data {
MK_FLOW_ACTION(SET_TTL, sizeof(struct rte_flow_action_set_ttl)),
MK_FLOW_ACTION(SET_MAC_SRC, sizeof(struct rte_flow_action_set_mac)),
MK_FLOW_ACTION(SET_MAC_DST, sizeof(struct rte_flow_action_set_mac)),
+ MK_FLOW_ACTION(INC_TCP_SEQ, sizeof(rte_be32_t)),
+ MK_FLOW_ACTION(DEC_TCP_SEQ, sizeof(rte_be32_t)),
+ MK_FLOW_ACTION(INC_TCP_ACK, sizeof(rte_be32_t)),
+ MK_FLOW_ACTION(DEC_TCP_ACK, sizeof(rte_be32_t)),
};
static int
diff --git a/lib/librte_ethdev/rte_flow.h b/lib/librte_ethdev/rte_flow.h
index 2232856..bc41023 100644
--- a/lib/librte_ethdev/rte_flow.h
+++ b/lib/librte_ethdev/rte_flow.h
@@ -1651,6 +1651,62 @@ enum rte_flow_action_type {
* See struct rte_flow_action_set_mac.
*/
RTE_FLOW_ACTION_TYPE_SET_MAC_DST,
+
+ /**
+ * Increase sequence number in the outermost TCP header.
+ *
+ * Action configuration specifies the value to increase
+ * TCP sequence number as a big-endian 32 bit integer.
+ *
+ * @p conf type:
+ * @code rte_be32_t * @endcode
+ *
+ * Using this action on non-matching traffic will result in
+ * undefined behavior.
+ */
+ RTE_FLOW_ACTION_TYPE_INC_TCP_SEQ,
+
+ /**
+ * Decrease sequence number in the outermost TCP header.
+ *
+ * Action configuration specifies the value to decrease
+ * TCP sequence number as a big-endian 32 bit integer.
+ *
+ * @p conf type:
+ * @code rte_be32_t * @endcode
+ *
+ * Using this action on non-matching traffic will result in
+ * undefined behavior.
+ */
+ RTE_FLOW_ACTION_TYPE_DEC_TCP_SEQ,
+
+ /**
+ * Increase acknowledgment number in the outermost TCP header.
+ *
+ * Action configuration specifies the value to increase
+ * TCP acknowledgment number as a big-endian 32 bit integer.
+ *
+ * @p conf type:
+ * @code rte_be32_t * @endcode
+
+ * Using this action on non-matching traffic will result in
+ * undefined behavior.
+ */
+ RTE_FLOW_ACTION_TYPE_INC_TCP_ACK,
+
+ /**
+ * Decrease acknowledgment number in the outermost TCP header.
+ *
+ * Action configuration specifies the value to decrease
+ * TCP acknowledgment number as a big-endian 32 bit integer.
+ *
+ * @p conf type:
+ * @code rte_be32_t * @endcode
+ *
+ * Using this action on non-matching traffic will result in
+ * undefined behavior.
+ */
+ RTE_FLOW_ACTION_TYPE_DEC_TCP_ACK,
};
/**
--
1.8.3.1
next prev parent reply other threads:[~2019-07-02 14:46 UTC|newest]
Thread overview: 116+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-21 14:18 [dpdk-dev] [PATCH 0/3] add actions to modify " Dekel Peled
2019-03-21 14:18 ` Dekel Peled
2019-03-21 14:18 ` [dpdk-dev] [PATCH 1/3] ethdev: add actions to modify TCP " Dekel Peled
2019-03-21 14:18 ` Dekel Peled
2019-03-26 9:24 ` Dekel Peled
2019-03-26 9:24 ` Dekel Peled
2019-03-29 13:58 ` Adrien Mazarguil
2019-03-29 13:58 ` Adrien Mazarguil
2019-03-31 13:09 ` Dekel Peled
2019-03-31 13:09 ` Dekel Peled
2019-03-21 14:18 ` [dpdk-dev] [PATCH 2/3] app/testpmd: " Dekel Peled
2019-03-21 14:18 ` Dekel Peled
2019-03-29 13:58 ` Adrien Mazarguil
2019-03-29 13:58 ` Adrien Mazarguil
2019-03-31 13:10 ` Dekel Peled
2019-03-31 13:10 ` Dekel Peled
2019-03-21 14:18 ` [dpdk-dev] [PATCH 3/3] net/mlx5: update modify header using Direct Verbs Dekel Peled
2019-03-21 14:18 ` Dekel Peled
2019-04-02 15:13 ` [dpdk-dev] [PATCH v2 0/3] add actions to modify header fields Dekel Peled
2019-04-02 15:13 ` Dekel Peled
2019-04-10 11:26 ` [dpdk-dev] [PATCH v3 " Dekel Peled
2019-04-10 11:26 ` Dekel Peled
2019-04-10 11:26 ` [dpdk-dev] [PATCH v3 1/3] ethdev: add actions to modify TCP " Dekel Peled
2019-04-10 11:26 ` Dekel Peled
2019-04-10 11:26 ` [dpdk-dev] [PATCH v3 2/3] app/testpmd: " Dekel Peled
2019-04-10 11:26 ` Dekel Peled
2019-04-10 11:26 ` [dpdk-dev] [PATCH v3 3/3] net/mlx5: update modify header using Direct Verbs Dekel Peled
2019-04-10 11:26 ` Dekel Peled
2019-04-10 11:50 ` [dpdk-dev] [PATCH v4 0/3] add actions to modify header fields Dekel Peled
2019-04-10 11:50 ` Dekel Peled
2019-04-10 11:50 ` [dpdk-dev] [PATCH v4 1/3] ethdev: add actions to modify TCP " Dekel Peled
2019-04-10 11:50 ` Dekel Peled
2019-04-18 12:30 ` Adrien Mazarguil
2019-04-18 12:30 ` Adrien Mazarguil
2019-04-22 7:15 ` Dekel Peled
2019-04-22 7:15 ` Dekel Peled
2019-04-10 11:50 ` [dpdk-dev] [PATCH v4 2/3] app/testpmd: " Dekel Peled
2019-04-10 11:50 ` Dekel Peled
2019-04-10 11:50 ` [dpdk-dev] [PATCH v4 3/3] net/mlx5: update modify header using Direct Verbs Dekel Peled
2019-04-10 11:50 ` Dekel Peled
2019-04-22 11:22 ` [dpdk-dev] [PATCH v5 0/3] add actions to modify header fields Dekel Peled
2019-04-22 11:22 ` Dekel Peled
2019-04-22 11:22 ` [dpdk-dev] [PATCH v5 1/3] ethdev: add actions to modify TCP " Dekel Peled
2019-04-22 11:22 ` Dekel Peled
2019-04-22 11:22 ` [dpdk-dev] [PATCH v5 2/3] app/testpmd: " Dekel Peled
2019-04-22 11:22 ` Dekel Peled
2019-04-22 11:22 ` [dpdk-dev] [PATCH v5 3/3] net/mlx5: update modify header using Direct Verbs Dekel Peled
2019-04-22 11:22 ` Dekel Peled
2019-06-02 8:18 ` [dpdk-dev] [PATCH v5 0/3] add actions to modify header fields Dekel Peled
2019-06-04 5:13 ` Dekel Peled
2019-06-04 8:14 ` Dekel Peled
2019-06-17 6:12 ` [dpdk-dev] [PATCH v6 " Dekel Peled
2019-06-17 6:12 ` [dpdk-dev] [PATCH v6 1/3] ethdev: add actions to modify TCP " Dekel Peled
2019-06-17 6:12 ` [dpdk-dev] [PATCH v6 2/3] app/testpmd: " Dekel Peled
2019-06-17 6:12 ` [dpdk-dev] [PATCH v6 3/3] net/mlx5: update modify header using Direct Verbs Dekel Peled
2019-06-27 17:39 ` [dpdk-dev] [PATCH v7 0/3] add actions to modify header fields Dekel Peled
2019-06-30 7:59 ` [dpdk-dev] [PATCH v8 " Dekel Peled
2019-06-30 7:59 ` [dpdk-dev] [PATCH v8 1/3] ethdev: add actions to modify TCP " Dekel Peled
2019-07-01 8:55 ` Adrien Mazarguil
2019-07-01 9:58 ` Dekel Peled
2019-06-30 7:59 ` [dpdk-dev] [PATCH v8 2/3] app/testpmd: " Dekel Peled
2019-06-30 7:59 ` [dpdk-dev] [PATCH v8 3/3] net/mlx5: update modify header using Direct Verbs Dekel Peled
[not found] ` <cover.1561656977.git.dekelp@mellanox.com>
2019-06-27 17:39 ` [dpdk-dev] [PATCH v7 1/3] ethdev: add actions to modify TCP header fields Dekel Peled
2019-06-27 17:54 ` Andrew Rybchenko
2019-06-28 16:18 ` Adrien Mazarguil
2019-06-27 17:39 ` [dpdk-dev] [PATCH v7 2/3] app/testpmd: " Dekel Peled
2019-06-27 17:39 ` [dpdk-dev] [PATCH v7 3/3] net/mlx5: update modify header using Direct Verbs Dekel Peled
2019-04-02 15:13 ` [dpdk-dev] [PATCH v2 1/3] ethdev: add actions to modify TCP header fields Dekel Peled
2019-04-02 15:13 ` Dekel Peled
2019-04-02 16:33 ` Ori Kam
2019-04-02 16:33 ` Ori Kam
2019-04-03 9:14 ` Adrien Mazarguil
2019-04-03 9:14 ` Adrien Mazarguil
2019-04-03 10:49 ` Dekel Peled
2019-04-03 10:49 ` Dekel Peled
2019-04-03 12:49 ` Adrien Mazarguil
2019-04-03 12:49 ` Adrien Mazarguil
2019-04-04 9:01 ` Ori Kam
2019-04-04 9:01 ` Ori Kam
2019-04-04 13:25 ` Adrien Mazarguil
2019-04-04 13:25 ` Adrien Mazarguil
2019-04-05 11:54 ` Andrew Rybchenko
2019-04-05 11:54 ` Andrew Rybchenko
2019-04-08 13:36 ` Dekel Peled
2019-04-08 13:36 ` Dekel Peled
2019-04-08 13:53 ` Andrew Rybchenko
2019-04-08 13:53 ` Andrew Rybchenko
2019-04-08 14:21 ` Adrien Mazarguil
2019-04-08 14:21 ` Adrien Mazarguil
2019-04-02 15:13 ` [dpdk-dev] [PATCH v2 2/3] app/testpmd: " Dekel Peled
2019-04-02 15:13 ` Dekel Peled
2019-04-02 16:33 ` Ori Kam
2019-04-02 16:33 ` Ori Kam
2019-04-02 15:13 ` [dpdk-dev] [PATCH v2 3/3] net/mlx5: update modify header using Direct Verbs Dekel Peled
2019-04-02 15:13 ` Dekel Peled
2019-04-02 16:34 ` Ori Kam
2019-04-02 16:34 ` Ori Kam
2019-04-03 8:27 ` Shahaf Shuler
2019-04-03 8:27 ` Shahaf Shuler
2019-07-01 15:43 ` [dpdk-dev] [PATCH v9 0/3] add actions to modify header fields Dekel Peled
2019-07-01 15:43 ` [dpdk-dev] [PATCH v9 1/3] ethdev: add actions to modify TCP " Dekel Peled
2019-07-02 8:14 ` Andrew Rybchenko
2019-07-02 9:52 ` Dekel Peled
2019-07-02 10:33 ` Adrien Mazarguil
2019-07-02 12:01 ` Dekel Peled
2019-07-01 15:43 ` [dpdk-dev] [PATCH v9 2/3] app/testpmd: " Dekel Peled
2019-07-01 15:43 ` [dpdk-dev] [PATCH v9 3/3] net/mlx5: update modify header using Direct Verbs Dekel Peled
2019-07-02 14:44 ` [dpdk-dev] [PATCH v10 0/3] add actions to modify header fields Dekel Peled
2019-07-02 14:44 ` Dekel Peled [this message]
2019-07-03 5:04 ` [dpdk-dev] [PATCH v10 1/3] ethdev: add actions to modify TCP " Slava Ovsiienko
2019-07-02 14:44 ` [dpdk-dev] [PATCH v10 2/3] app/testpmd: " Dekel Peled
2019-07-03 6:30 ` Slava Ovsiienko
2019-07-02 14:44 ` [dpdk-dev] [PATCH v10 3/3] net/mlx5: update modify header using Direct Verbs Dekel Peled
2019-07-03 6:30 ` Slava Ovsiienko
2019-07-02 15:15 ` [dpdk-dev] [PATCH v10 0/3] add actions to modify header fields Adrien Mazarguil
2019-07-03 14:59 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c4db0791c7576911dab42f59692042d1dab5e39b.1562078184.git.dekelp@mellanox.com \
--to=dekelp@mellanox.com \
--cc=adrien.mazarguil@6wind.com \
--cc=arybchenko@solarflare.com \
--cc=bernard.iremonger@intel.com \
--cc=dev@dpdk.org \
--cc=jingjing.wu@intel.com \
--cc=orika@mellanox.com \
--cc=shahafs@mellanox.com \
--cc=viacheslavo@mellanox.com \
--cc=wenzhuo.lu@intel.com \
--cc=yskoh@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).