From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 81397426CC; Fri, 6 Oct 2023 09:54:42 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 6EFB3402A8; Fri, 6 Oct 2023 09:54:42 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id C9BB04014F for ; Fri, 6 Oct 2023 09:54:40 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1696578880; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=wYMRGwIWSI8Ey8V5hks98RbtS1iMPmimkbwwMDerw1E=; b=SdrzQL8cWtTfu8FiXxh5uOiH+NtuXFisIrNUVEECaGmv78ZXeKLR6VjWXWEUs49BdRGGll i7cLWPb2nuf2G2TTa0Vd1h+54Sv2ThKh3px5hu823aihGTJsfnNY8F4LbRF7JKGoAOYddv +W1D0ZNJm8+/+/7YVEbsJV5vftI5A1w= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-263-vOTXDF2qP6CgSTH-QATTcw-1; Fri, 06 Oct 2023 03:54:17 -0400 X-MC-Unique: vOTXDF2qP6CgSTH-QATTcw-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.rdu2.redhat.com [10.11.54.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id AA8EB802C1A; Fri, 6 Oct 2023 07:54:16 +0000 (UTC) Received: from [10.39.208.34] (unknown [10.39.208.34]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 9AE8F140E950; Fri, 6 Oct 2023 07:54:15 +0000 (UTC) Message-ID: Date: Fri, 6 Oct 2023 09:54:14 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.15.1 Subject: Re: [PATCH v5 01/12] bbdev: add FFT window width member in driver info To: Nicolas Chautru , dev@dpdk.org Cc: hemant.agrawal@nxp.com, david.marchand@redhat.com, hernan.vargas@intel.com References: <20231005194907.557517-1-nicolas.chautru@intel.com> <20231005194907.557517-2-nicolas.chautru@intel.com> From: Maxime Coquelin In-Reply-To: <20231005194907.557517-2-nicolas.chautru@intel.com> X-Scanned-By: MIMEDefang 3.1 on 10.11.54.7 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 10/5/23 21:48, Nicolas Chautru wrote: > This exposes the width of each windowing shape being configured on > the device. This allows to distinguish different version of the > flexible pointwise windowing applied to the FFT and expose > this platform configuration to the application. > This also add the total number of windows supported in the capability. > > The SRS processing chain > (https://doc.dpdk.org/guides/prog_guide/bbdev.html#bbdev-fft-operation) > includes a pointwise multiplication by time window whose shape width > needs to be exposed, notably for accurate SNR estimate. > Using that mechanism user application can retrieve information related > to what has been dynamically programmed on any bbdev device > supporting FFT windowing operation. > > Signed-off-by: Nicolas Chautru > --- > lib/bbdev/rte_bbdev.h | 2 ++ > lib/bbdev/rte_bbdev_op.h | 2 ++ > 2 files changed, 4 insertions(+) > > diff --git a/lib/bbdev/rte_bbdev.h b/lib/bbdev/rte_bbdev.h > index 2985c9f42b..d12e2e7fbc 100644 > --- a/lib/bbdev/rte_bbdev.h > +++ b/lib/bbdev/rte_bbdev.h > @@ -349,6 +349,8 @@ struct rte_bbdev_driver_info { > const struct rte_bbdev_op_cap *capabilities; > /** Device cpu_flag requirements */ > const enum rte_cpu_flag_t *cpu_flag_reqs; > + /** FFT windowing width for 2048 FFT - size defined in capability. */ > + uint16_t *fft_window_width; > }; > > /** Macro used at end of bbdev PMD list */ > diff --git a/lib/bbdev/rte_bbdev_op.h b/lib/bbdev/rte_bbdev_op.h > index 693baa8386..369ac331bf 100644 > --- a/lib/bbdev/rte_bbdev_op.h > +++ b/lib/bbdev/rte_bbdev_op.h > @@ -905,6 +905,8 @@ struct rte_bbdev_op_cap_fft { > uint16_t num_buffers_src; > /** Num output code block buffers. */ > uint16_t num_buffers_dst; > + /** Number of FFT windows supported. */ > + uint16_t fft_windows_num; > }; > > /** List of the capabilities for the MLD */ I am Ok to move forwards with this, even if I would have liked feedback from Hemant. However, I think you need to add some documentation around it, as what is in the commit message is important and won't be visible to the end- user. Thanks, Maxime