From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 1606743709;
	Sat, 16 Dec 2023 10:26:12 +0100 (CET)
Received: from mails.dpdk.org (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id A40A7402AA;
	Sat, 16 Dec 2023 10:26:11 +0100 (CET)
Received: from shelob.oktetlabs.ru (shelob.oktetlabs.ru [91.220.146.113])
 by mails.dpdk.org (Postfix) with ESMTP id 1B18F402A8
 for <dev@dpdk.org>; Sat, 16 Dec 2023 10:26:10 +0100 (CET)
Received: from [192.168.38.17] (aros.oktetlabs.ru [192.168.38.17])
 (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)
 key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256)
 (No client certificate requested)
 by shelob.oktetlabs.ru (Postfix) with ESMTPSA id 5CC5466;
 Sat, 16 Dec 2023 12:26:09 +0300 (MSK)
DKIM-Filter: OpenDKIM Filter v2.11.0 shelob.oktetlabs.ru 5CC5466
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=oktetlabs.ru;
 s=default; t=1702718769;
 bh=bzQyYE5Io0EVsEMN7Seo+fbhpISfA2Wnr4U/n+s4uIw=;
 h=Date:Subject:To:Cc:References:From:In-Reply-To:From;
 b=XWb3rilGTWR1RZSES2dcxYCgmwoUTOqse9mzXmWUhwkt99NhKs7jUeHxHe4ti9v4p
 sKHlown+NJYO6vOzqHTCi9We7ynPXWBJWhPrGJub2BHsZvz3BTb5dwNWhwujQTW52v
 C4hLolsyESE3/68Sub9q8CDb++jFrVqF1yqPIZU0=
Message-ID: <c4eb553f-221e-43d6-b240-33397b8c164b@oktetlabs.ru>
Date: Sat, 16 Dec 2023 12:26:08 +0300
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [RFC v2 08/14] lib: simplify multilines log messages
Content-Language: en-US
To: Stephen Hemminger <stephen@networkplumber.org>,
 David Marchand <david.marchand@redhat.com>
Cc: dev@dpdk.org, thomas@monjalon.net, ferruh.yigit@amd.com,
 bruce.richardson@intel.com, mb@smartsharesystems.com,
 Konstantin Ananyev <konstantin.v.ananyev@yandex.ru>,
 Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>,
 Narcisa Ana Maria Vasile <navasile@linux.microsoft.com>,
 Dmitry Malloy <dmitrym@microsoft.com>,
 Pallavi Kadam <pallavi.kadam@intel.com>
References: <20231117131824.1977792-1-david.marchand@redhat.com>
 <20231208145950.2184940-1-david.marchand@redhat.com>
 <20231208145950.2184940-9-david.marchand@redhat.com>
 <20231208090524.01c93717@hermes.local>
From: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
Organization: OKTET Labs
In-Reply-To: <20231208090524.01c93717@hermes.local>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org

On 12/8/23 20:05, Stephen Hemminger wrote:
> On Fri,  8 Dec 2023 15:59:42 +0100
> David Marchand <david.marchand@redhat.com> wrote:
> 
>> Those error log messages don't need to span on multiple lines.
>>
>> Signed-off-by: David Marchand <david.marchand@redhat.com>
>> ---
>>   lib/acl/tb_mem.c                |  2 +-
>>   lib/bpf/bpf_stub.c              |  4 ++--
>>   lib/eal/windows/eal_hugepages.c |  4 ++--
>>   lib/ethdev/rte_ethdev.c         | 14 +++++++-------
>>   4 files changed, 12 insertions(+), 12 deletions(-)
> 
> Could you fix these messages to not cross source lines as well?

+1

> Feel free to shorten the wording as necessary.