From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by dpdk.org (Postfix) with ESMTP id 8968B2B92 for ; Fri, 31 Mar 2017 11:23:51 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=intel.com; i=@intel.com; q=dns/txt; s=intel; t=1490952231; x=1522488231; h=subject:to:references:cc:from:message-id:date: mime-version:in-reply-to:content-transfer-encoding; bh=jugNRigiYKUifp/pXHkuaYHlQ05E3q/SviSLYpglgl4=; b=RSNWYRaXlNvbu/KRDKfLnGkq9Xn0Ir2xuU5hOjkp/tAve7dQVWW25rkn m9juezL15vVg/NmSywyPDTj5pUe5Nw==; Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 31 Mar 2017 02:23:45 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.36,251,1486454400"; d="scan'208";a="840346957" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.237.220.122]) ([10.237.220.122]) by FMSMGA003.fm.intel.com with ESMTP; 31 Mar 2017 02:23:44 -0700 To: Yongseok Koh , Shahaf Shuler References: <20170330080645.30973-1-shahafs@mellanox.com> <69708566-2900-4781-B12A-AFFC7C7B2896@mellanox.com> Cc: =?UTF-8?Q?N=c3=a9lio_Laranjeiro?= , Adrien Mazarguil , "dev@dpdk.org" From: Ferruh Yigit Message-ID: Date: Fri, 31 Mar 2017 10:23:44 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: <69708566-2900-4781-B12A-AFFC7C7B2896@mellanox.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH] net/mlx5: remove not needed query if and rd from create qp X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 31 Mar 2017 09:23:52 -0000 On 3/30/2017 6:03 PM, Yongseok Koh wrote: > > Hi, > >> On Mar 30, 2017, at 1:06 AM, Shahaf Shuler wrote: >> >> Since mlx5 PMD data path is on top of PRM, such verbs calls are >> no longer needed. >> >> Signed-off-by: Shahaf Shuler >> Acked-by: Nelio Laranjeiro > > Acked-by: Yongseok Koh > > I ack the code change but one small suggestion regarding the commit header. > It looks like 'if' means interface, 'rd' means the Resource Domain, and > 'qp' means the Queue Pair. which are all mellanox specific terms and > acronyms. My suggestion is: > > net/mlx5: remove unnecessary Verbs library calls > > And how about moving the details into the message body: > > Remove unnecessary interface queries and the Resource Domain when creating > the Queue Pair. Since mlx5 PMD data path is on top of native APIs, such > Verbs library calls are no longer needed. Can you please send a new version of the patch with suggested updates? (Keeping the Ack) Thanks, ferruh > > Thanks, > Yongseok >