From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id DF16FA0A05; Wed, 20 Jan 2021 15:27:59 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id C50FA140D38; Wed, 20 Jan 2021 15:27:59 +0100 (CET) Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by mails.dpdk.org (Postfix) with ESMTP id 6EEEB140D0A; Wed, 20 Jan 2021 15:27:57 +0100 (CET) IronPort-SDR: J3YZidJaIhRG4EzbZDoKXhtgqE6k1pX+SHQqv6nkNU5AVZnHjOaW1ykdM/sSUPAEw7pMvZwde1 8FKQXQlNL0kA== X-IronPort-AV: E=McAfee;i="6000,8403,9869"; a="175608570" X-IronPort-AV: E=Sophos;i="5.79,361,1602572400"; d="scan'208";a="175608570" Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Jan 2021 06:27:56 -0800 IronPort-SDR: 7jELpQSXC14XQijiLlPcOtMV5Qt/VigT9KSnMFTYgZ/aJlBP2/GGIY03+7inOqQ+G+I9TQ70pK cMXvK+jq6rRA== X-IronPort-AV: E=Sophos;i="5.79,361,1602572400"; d="scan'208";a="351061671" Received: from aburakov-mobl.ger.corp.intel.com (HELO [10.213.240.112]) ([10.213.240.112]) by orsmga003-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Jan 2021 06:27:53 -0800 To: David Hunt , dev@dpdk.org Cc: stable@dpdk.org, Bruce Richardson References: <20210108143048.23755-2-david.hunt@intel.com> <20210120135556.33763-1-david.hunt@intel.com> <20210120135556.33763-4-david.hunt@intel.com> From: "Burakov, Anatoly" Message-ID: Date: Wed, 20 Jan 2021 14:27:51 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:68.0) Gecko/20100101 Thunderbird/68.12.0 MIME-Version: 1.0 In-Reply-To: <20210120135556.33763-4-david.hunt@intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v3 3/6] power: rename public structs X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 20-Jan-21 1:55 PM, David Hunt wrote: > From: Bruce Richardson > > rename the public structs to have an rte_power_ prefix. > > Fixes: 210c383e247b ("power: packet format for vm power management") > Fixes: cd0d5547e873 ("power: vm communication channels in guest") > Cc: stable@dpdk.org > > Signed-off-by: Bruce Richardson > Signed-off-by: David Hunt > --- > RTE_LOG(ERR, GUEST_CLI, "Error receiving message.\n"); > @@ -293,14 +294,15 @@ cmd_query_caps_list_parsed(void *parsed_result, > { > struct cmd_query_caps_result *res = parsed_result; > unsigned int lcore_id; > - struct channel_packet_caps_list pkt_caps_list; > - struct channel_packet pkt; > + struct rte_power_channel_packet_caps_list pkt_caps_list; > + struct rte_power_channel_packet pkt; > bool query_list = false; > int ret; > char *ep; > > - memset(&pkt, 0, sizeof(struct channel_packet)); > - memset(&pkt_caps_list, 0, sizeof(struct channel_packet_caps_list)); > + memset(&pkt, 0, sizeof(struct rte_power_channel_packet)); > + memset(&pkt_caps_list, 0, > + sizeof(struct rte_power_channel_packet_caps_list)); Here and in other places where you do sizeof(), you might want to avoid future changes by replacing it with sizeof(*pkt) instead? -- Thanks, Anatoly