From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 37023A0350; Tue, 30 Jun 2020 07:26:04 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id A89712C01; Tue, 30 Jun 2020 07:26:03 +0200 (CEST) Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by dpdk.org (Postfix) with ESMTP id 694202AB for ; Tue, 30 Jun 2020 07:26:01 +0200 (CEST) IronPort-SDR: nvO1vCWJKrHeN4jaUEPKmtaVnYg8Ri9lb/jGZO4S01XKqEaEhCX6mPrSmuXhYGNn+TBMm6eVm2 rp/CBkqcZDHg== X-IronPort-AV: E=McAfee;i="6000,8403,9666"; a="126273771" X-IronPort-AV: E=Sophos;i="5.75,296,1589266800"; d="scan'208,217";a="126273771" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga006.jf.intel.com ([10.7.209.51]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 Jun 2020 22:26:00 -0700 IronPort-SDR: xFcXupO50nZzLKrlQmfhFM52q9IoD05mcXmQAz4AGzICzsrUL8DXHAPWnY5sph2Kg8r1NXmVFy PtGkbHr1Wq2Q== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.75,296,1589266800"; d="scan'208,217";a="281105549" Received: from jguo15x-mobl.ccr.corp.intel.com (HELO [10.67.68.180]) ([10.67.68.180]) by orsmga006.jf.intel.com with ESMTP; 29 Jun 2020 22:25:58 -0700 To: Chenxu Di , dev@dpdk.org Cc: beilei.xing@intel.com, Yang Qiming References: <20200611060142.75465-1-chenxux.di@intel.com> <20200615021858.13985-1-chenxux.di@intel.com> <20200615021858.13985-3-chenxux.di@intel.com> From: Jeff Guo Message-ID: Date: Tue, 30 Jun 2020 13:25:57 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.9.0 MIME-Version: 1.0 In-Reply-To: <20200615021858.13985-3-chenxux.di@intel.com> Content-Language: en-US Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [PATCH v2 2/5] net/ixgbe: add private APIs X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" hi, chenxu On 6/15/2020 10:18 AM, Chenxu Di wrote: > The legacy filter API will be superseded by rte_flow. > There are also several small features which can not be > implemented in rte_flow. This patch re-implemented these > features as private API. > Two APIs are added: > rte_pmd_ixgbe_get_fdir_info. > rte_pmd_ixgbe_get_fdir_stats. > > Signed-off-by: Chenxu Di > --- > drivers/net/ixgbe/ixgbe_ethdev.h | 4 +++ > drivers/net/ixgbe/ixgbe_fdir.c | 8 ++--- > drivers/net/ixgbe/rte_pmd_ixgbe.c | 33 +++++++++++++++++++++ > drivers/net/ixgbe/rte_pmd_ixgbe.h | 33 +++++++++++++++++++++ > drivers/net/ixgbe/rte_pmd_ixgbe_version.map | 2 ++ > 5 files changed, 74 insertions(+), 6 deletions(-) > > diff --git a/drivers/net/ixgbe/ixgbe_ethdev.h b/drivers/net/ixgbe/ixgbe_ethdev.h > index 3d78b2ee2..9bdef87fb 100644 > --- a/drivers/net/ixgbe/ixgbe_ethdev.h > +++ b/drivers/net/ixgbe/ixgbe_ethdev.h > @@ -697,6 +697,10 @@ int ixgbe_fdir_set_flexbytes_offset(struct rte_eth_dev *dev, > int ixgbe_fdir_filter_program(struct rte_eth_dev *dev, > struct ixgbe_fdir_rule *rule, > bool del, bool update); > +void ixgbe_fdir_info_get(struct rte_eth_dev *dev, > + struct rte_eth_fdir_info *fdir_info); > +void ixgbe_fdir_stats_get(struct rte_eth_dev *dev, > + struct rte_eth_fdir_stats *fdir_stats); > > void ixgbe_configure_dcb(struct rte_eth_dev *dev); > > diff --git a/drivers/net/ixgbe/ixgbe_fdir.c b/drivers/net/ixgbe/ixgbe_fdir.c > index 166dae1e0..6faaa8f06 100644 > --- a/drivers/net/ixgbe/ixgbe_fdir.c > +++ b/drivers/net/ixgbe/ixgbe_fdir.c > @@ -109,10 +109,6 @@ static int ixgbe_add_del_fdir_filter(struct rte_eth_dev *dev, > bool del, > bool update); > static int ixgbe_fdir_flush(struct rte_eth_dev *dev); > -static void ixgbe_fdir_info_get(struct rte_eth_dev *dev, > - struct rte_eth_fdir_info *fdir_info); > -static void ixgbe_fdir_stats_get(struct rte_eth_dev *dev, > - struct rte_eth_fdir_stats *fdir_stats); > > /** > * This function is based on ixgbe_fdir_enable_82599() in base/ixgbe_82599.c. > @@ -1414,7 +1410,7 @@ ixgbe_fdir_flush(struct rte_eth_dev *dev) > } > > #define FDIRENTRIES_NUM_SHIFT 10 > -static void > +void > ixgbe_fdir_info_get(struct rte_eth_dev *dev, struct rte_eth_fdir_info *fdir_info) > { > struct ixgbe_hw *hw = IXGBE_DEV_PRIVATE_TO_HW(dev->data->dev_private); > @@ -1473,7 +1469,7 @@ ixgbe_fdir_info_get(struct rte_eth_dev *dev, struct rte_eth_fdir_info *fdir_info > (uint8_t)((info->mask.flex_bytes_mask & 0xFF00) >> 8); > } > > -static void > +void > ixgbe_fdir_stats_get(struct rte_eth_dev *dev, struct rte_eth_fdir_stats *fdir_stats) > { > struct ixgbe_hw *hw = IXGBE_DEV_PRIVATE_TO_HW(dev->data->dev_private); > diff --git a/drivers/net/ixgbe/rte_pmd_ixgbe.c b/drivers/net/ixgbe/rte_pmd_ixgbe.c > index 9bff557f9..d2f708242 100644 > --- a/drivers/net/ixgbe/rte_pmd_ixgbe.c > +++ b/drivers/net/ixgbe/rte_pmd_ixgbe.c > @@ -1139,3 +1139,36 @@ rte_pmd_ixgbe_mdio_unlocked_write(uint16_t port, uint32_t reg_addr, > } > return 0; > } > + > +int > +rte_pmd_ixgbe_get_fdir_info(uint16_t port, struct rte_eth_fdir_info *fdir_info) > +{ > + struct rte_eth_dev *dev; > + > + RTE_ETH_VALID_PORTID_OR_ERR_RET(port, -ENODEV); > + > + dev = &rte_eth_devices[port]; > + if (!is_ixgbe_supported(dev)) > + return -ENOTSUP; > + > + ixgbe_fdir_info_get(dev, fdir_info); > + > + return 0; > +} > + > +int > +rte_pmd_ixgbe_get_fdir_stats(uint16_t port, > + struct rte_eth_fdir_stats *fdir_stats) Please check the alignment and other places. > +{ > + struct rte_eth_dev *dev; > + > + RTE_ETH_VALID_PORTID_OR_ERR_RET(port, -ENODEV); > + > + dev = &rte_eth_devices[port]; > + if (!is_ixgbe_supported(dev)) > + return -ENOTSUP; > + > + ixgbe_fdir_stats_get(dev, fdir_stats); > + > + return 0; > +} > diff --git a/drivers/net/ixgbe/rte_pmd_ixgbe.h b/drivers/net/ixgbe/rte_pmd_ixgbe.h > index f62fd761d..8b6bb99a5 100644 > --- a/drivers/net/ixgbe/rte_pmd_ixgbe.h > +++ b/drivers/net/ixgbe/rte_pmd_ixgbe.h > @@ -726,4 +726,37 @@ enum { > __rte_experimental > int > rte_pmd_ixgbe_upd_fctrl_sbp(uint16_t port, int enable); > + > +/** > + * Get port fdir info > + * > + * @param port > + * The port identifier of the Ethernet device. > + * @param fdir_info > + * The fdir info of the port > + * @return > + * - (0) if successful. > + * - (-ENODEV) if *port* invalid. > + * - (-ENOTSUP) if operation not supported. > + */ > +__rte_experimental > +int > +rte_pmd_ixgbe_get_fdir_info(uint16_t port, struct rte_eth_fdir_info *fdir_info); > + > +/** > + * Get port fdir status > + * > + * @param port > + * The port identifier of the Ethernet device. > + * @param fdir_stats > + * The fdir status of the port > + * @return > + * - (0) if successful. > + * - (-ENODEV) if *port* invalid. > + * - (-ENOTSUP) if operation not supported. > + */ > +__rte_experimental > +int > +rte_pmd_ixgbe_get_fdir_stats(uint16_t port, > + struct rte_eth_fdir_stats *fdir_stats); > #endif /* _PMD_IXGBE_H_ */ > diff --git a/drivers/net/ixgbe/rte_pmd_ixgbe_version.map b/drivers/net/ixgbe/rte_pmd_ixgbe_version.map > index 21534dbc3..911f8083f 100644 > --- a/drivers/net/ixgbe/rte_pmd_ixgbe_version.map > +++ b/drivers/net/ixgbe/rte_pmd_ixgbe_version.map > @@ -38,6 +38,8 @@ DPDK_20.0 { > EXPERIMENTAL { > global: > > + rte_pmd_ixgbe_get_fdir_info; > + rte_pmd_ixgbe_get_fdir_stats; > rte_pmd_ixgbe_mdio_lock; > rte_pmd_ixgbe_mdio_unlock; > rte_pmd_ixgbe_mdio_unlocked_read;